hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge branch 'pr-1891'

Browse Source
This commit is contained in:
Andreas Dangel
2019-06-27 20:30:05 +02:00
parent e7427a3db0 7c90c42fe5
commit d631c153a8
3 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/pages/release_notes.md
View File

@ -46,6 +46,8 @@ datetime field.
### Fixed Issues
* apex
* [#1664](https://github.com/pmd/pmd/issues/1664): \[apex] False positive ApexSharingViolationsRule, unsupported Apex feature
* java
* [#1848](https://github.com/pmd/pmd/issues/1848): \[java] Local classes should preserve their modifiers
* java-bestpractices

3
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsRule.java
View File

@ -96,7 +96,8 @@ public class ApexSharingViolationsRule extends AbstractApexRule {
* @return
*/
private boolean isSharingPresent(ASTUserClass node) {
return node.getModifiers().isWithoutSharing() || node.getModifiers().isWithSharing();
return node.getModifiers().isWithoutSharing() || node.getModifiers().isWithSharing()
|| node.getModifiers().isInheritedSharing();
}
}

11
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexSharingViolations.xml
View File

@ -97,4 +97,15 @@ public without sharing class Foo {
]]></code>
</test-code>
<test-code>
<description>Apex class with inherited sharing doing a safe SOQL query</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public inherited sharing class MyClass {
public List<Contact> getAllTheSecrets(){
return [SELECT Name FROM Contact];
}
}
]]></code>
</test-code>
</test-data>