hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[core] Report exceptions thrown during rule execution

Browse Source
This commit is contained in:
Andreas Dangel
2018-05-01 16:41:26 +02:00
parent c6716388b9
commit d85db07196
2 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pmd-core/src/main/java/net/sourceforge/pmd/RuleSet.java
View File

@ -504,6 +504,7 @@ public class RuleSet implements ChecksumAware {
}
} catch (RuntimeException e) {
if (ctx.isIgnoreExceptions()) {
ctx.getReport().addError(new Report.ProcessingError(e, ctx.getSourceCodeFilename()));
if (LOG.isLoggable(Level.WARNING)) {
LOG.log(Level.WARNING, "Exception applying rule " + rule.getName() + " on file "
+ ctx.getSourceCodeFilename() + ", continuing with next rule", e);

44
pmd-core/src/test/java/net/sourceforge/pmd/RuleSetTest.java
View File

@ -22,6 +22,7 @@ import java.util.Set;
import org.junit.Test;
import net.sourceforge.pmd.Report.ProcessingError;
import net.sourceforge.pmd.RuleSet.RuleSetBuilder;
import net.sourceforge.pmd.lang.Dummy2LanguageModule;
import net.sourceforge.pmd.lang.DummyLanguageModule;
@ -30,6 +31,7 @@ import net.sourceforge.pmd.lang.ast.DummyNode;
import net.sourceforge.pmd.lang.ast.Node;
import net.sourceforge.pmd.lang.rule.MockRule;
import net.sourceforge.pmd.lang.rule.RuleReference;
import net.sourceforge.pmd.util.CollectionUtil;
public class RuleSetTest {
@ -507,4 +509,46 @@ public class RuleSetTest {
nodes.add(node);
return nodes;
}
@Test
public void ruleExceptionShouldBeReported() {
RuleSet ruleset = createRuleSetBuilder("ruleExceptionShouldBeReported")
.addRule(new MockRule() {
@Override
public void apply(List<? extends Node> nodes, RuleContext ctx) {
throw new RuntimeException("Test exception while applying rule");
}
})
.build();
RuleContext context = new RuleContext();
context.setReport(new Report());
context.setLanguageVersion(LanguageRegistry.getLanguage(DummyLanguageModule.NAME).getDefaultVersion());
context.setSourceCodeFilename(RuleSetTest.class.getName() + ".ruleExceptionShouldBeReported");
context.setIgnoreExceptions(true); // the default
ruleset.apply(makeCompilationUnits(), context);
assertTrue("Report should have processing errors", context.getReport().hasErrors());
List<ProcessingError> errors = CollectionUtil.toList(context.getReport().errors());
assertEquals("Errors expected", 1, errors.size());
assertEquals("Wrong error message", "Test exception while applying rule", errors.get(0).getMsg());
assertTrue("Should be a RuntimeException", errors.get(0).getError() instanceof RuntimeException);
}
@Test(expected = RuntimeException.class)
public void ruleExceptionShouldBeThrownIfNotIgnored() {
RuleSet ruleset = createRuleSetBuilder("ruleExceptionShouldBeReported")
.addRule(new MockRule() {
@Override
public void apply(List<? extends Node> nodes, RuleContext ctx) {
throw new RuntimeException("Test exception while applying rule");
}
})
.build();
RuleContext context = new RuleContext();
context.setReport(new Report());
context.setLanguageVersion(LanguageRegistry.getLanguage(DummyLanguageModule.NAME).getDefaultVersion());
context.setSourceCodeFilename(RuleSetTest.class.getName() + ".ruleExceptionShouldBeThrownIfNotIgnored");
context.setIgnoreExceptions(false);
ruleset.apply(makeCompilationUnits(), context);
}
}