hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[core] Use concurrent hash map in ParameterizedMetricKey

Browse Source
This commit is contained in:
Andreas Dangel
2020-02-16 10:43:35 +01:00
parent 4566567e5e
commit dfb1315ff5
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pmd-core/src/main/java/net/sourceforge/pmd/lang/metrics/ParameterizedMetricKey.java
View File

@ -4,8 +4,8 @@
package net.sourceforge.pmd.lang.metrics;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import net.sourceforge.pmd.annotation.InternalApi;
import net.sourceforge.pmd.lang.ast.Node;
@ -24,7 +24,7 @@ import net.sourceforge.pmd.util.DataMap.DataKey;
@Deprecated
public final class ParameterizedMetricKey<N extends Node> implements DataKey<ParameterizedMetricKey<N>, Double> {
private static final Map<ParameterizedMetricKey<?>, ParameterizedMetricKey<?>> POOL = new HashMap<>();
private static final ConcurrentMap<ParameterizedMetricKey<?>, ParameterizedMetricKey<?>> POOL = new ConcurrentHashMap<>();
/** The metric key. */
public final MetricKey<N> key;
@ -72,9 +72,7 @@ public final class ParameterizedMetricKey<N extends Node> implements DataKey<Par
public static <N extends Node> ParameterizedMetricKey<N> getInstance(MetricKey<N> key, MetricOptions options) {
// sharing instances allows using DataMap, which uses reference identity
ParameterizedMetricKey<N> tmp = new ParameterizedMetricKey<>(key, options);
if (!POOL.containsKey(tmp)) {
POOL.put(tmp, tmp);
}
POOL.putIfAbsent(tmp, tmp);
@SuppressWarnings("unchecked")
ParameterizedMetricKey<N> result = (ParameterizedMetricKey<N>) POOL.get(tmp);