hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

more restrictive regexp in AvoidUsingHardCodedIP to limit false positives

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5579 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Xavier Le Vourch
2007-10-25 01:12:51 +00:00
parent d83c4ec977
commit e28103ddfa
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml
View File

@ -47,4 +47,18 @@ public class Foo {
} }
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description><![CDATA[
Not an ip address string
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
String ID_MD5 = "1.2.840.113549.2.5";
String bar = "testing 1.2.3.4";
}
]]></code>
</test-code>
</test-data> </test-data>

2
pmd/rulesets/basic.xml
View File

@ -1025,7 +1025,7 @@ public class Test {
</description> </description>
<priority>3</priority> <priority>3</priority>
<properties> <properties>
<property name="pattern" description="Regular Expression" value="[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}"/> <property name="pattern" description="Regular Expression" value='^"[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}"$'/>
</properties> </properties>
<example> <example>
<![CDATA[ <![CDATA[