hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Add a bit of doc

Browse Source
This commit is contained in:
Clément Fournier
2021-05-28 12:23:03 +02:00
parent f06fd8e807
commit eb8e7c2756
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/metrics/impl/internal/CognitiveComplexityVisitor.java
View File

@ -99,6 +99,28 @@ public class CognitiveComplexityVisitor extends JavaParserVisitorAdapter {
void callMethod(ASTMethodDeclaration calledMethod) {
if (methodStack.contains(calledMethod)) {
// This means it's a recursive call.
// Note that we consider the entire stack and not just the top.
// This is an arbitrary decision that may cause FPs...
// Specifically it matters when anonymous classes are involved.
// void outer() {
// Runnable r = new Runnable(){
// public void run(){
// outer();
// }
// };
//
// r = () -> outer();
// }
//
// If we only consider the top of the stack, then within the anonymous class, `outer()`
// is not counted as a recursive call. This means the anonymous class
// has lower complexity than the lambda (because in the lambda the top
// of the stack is `outer`).
//
// TODO Arguably this could be improved by adding a complexity point
// for anonymous classes, because they're syntactically heavyweight.
// This would incentivize using lambdas.
fundamentalComplexity();
}
}