hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,518 Commits 16 Branches 123 Tags
Commit Graph

4518 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Allan Caplan
0e8bf7c3ab Implemented RFE 1566313 - allow minimumpriority attribute to be set at command line 
used same attribute as the ant task, minimumpriority, but used all lower case to keep in line with other command line params


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4682 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 19:10:42 +00:00
Allan Caplan
da63ae1c76 Applied patch 1565532 Java NCSS checks from Jason Bennett 
Changes made:
- Changed classes to Ncss* to maintain consistency between them and the rule name
- Added JUnit tests. Ran against NCSS current release to validate code size
- Moved to codesize package


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4681 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 15:42:45 +00:00
Allan Caplan
2378d27100 Implemented patch 1577540 from Jason Bennet 
Patch is for Feature Request ] 1434274 - UseCollectionIsEmpty
Thanks Jason!

Some small tweaks: Moved some null checks around for performance, added JUnit test.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4680 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 14:40:51 +00:00
Tom Copeland
d366791ce8 Trying to get under the SF quota 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4679 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 14:24:48 +00:00
Allan Caplan
d71a09c431 Testing for bug 1432595 :False +: MissingStaticMethodInNonInstantiatableClass 
Not reproducable


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4678 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:35:18 +00:00
Tom Copeland
b3ae8d05cf More complexity measurement cleanups from Jason Bennett; thanks Jason! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4677 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:25:23 +00:00
Allan Caplan
3975d821c3 Adding tests for defect report: http://sourceforge.net/tracker/index.php?func=detail&aid=1531158&group_id=56262&atid=479921 
Could not reproduce - issue may have been fixed


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4676 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 13:15:40 +00:00
Tom Copeland
cdc30a26d1 More tweaks from Peter 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4675 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:56:31 +00:00
Tom Copeland
e1871526ed Er, I mean, a better 'create rule XML' panel from _Peter Van de Voorde_ 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4674 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:54:29 +00:00
Tom Copeland
0560184d06 A better 'create rule XML' panel from Sven Jacob 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4673 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 12:52:11 +00:00
Brian Remedios
ee22ca56c2 minor optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4672 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 04:03:18 +00:00
Brian Remedios
3e8266b96a updated rule with property descriptors 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4671 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-16 02:11:24 +00:00
Tom Copeland
55a9139f46 Fixed ORO Maven reference name, thanks to Dave Brosius for the tip! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4670 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 18:40:23 +00:00
Brian Remedios
662189f644 minor updates 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4669 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 06:22:05 +00:00
Brian Remedios
810ae42392 Documentation for the property handling framework 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4668 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 05:56:16 +00:00
Brian Remedios
73262fea13 updated rule with property descriptors 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4667 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 05:31:22 +00:00
Tom Copeland
ab83afb522 Fixed bug 1566547 - Annotations with an empty MemberValueArrayInitializer are now parsed properly. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4666 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 05:20:41 +00:00
Brian Remedios
084fb9f924 property framework addition - revised rule superclasses to use it 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4665 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 05:18:17 +00:00
Brian Remedios
1c7b95bb55 new property management framework - not activated yet 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4664 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 05:05:58 +00:00
Brian Remedios
4be25d55e9 StringBuffer use optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4663 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 01:38:02 +00:00
Allan Caplan
37bc14d37b Tweaking JUnit tests to be more complete 
Adding this test to validate current working code doesn't break I've been
trying to locate the article referenced. The code stresses the NPath
rule, and according to its current style, runs 2 tests, one pass and one
fail.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4662 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 01:27:06 +00:00
Allan Caplan
fbbf3bc58d Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4661 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 00:47:24 +00:00
Allan Caplan
bb7e04f5d7 Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4660 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 00:31:11 +00:00
Xavier Le Vourch
a9c8f02a94 import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4659 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 00:21:48 +00:00
Allan Caplan
d21442b15c Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4658 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-15 00:16:15 +00:00
Allan Caplan
302788631a Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4657 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 23:56:10 +00:00
Xavier Le Vourch
303f3f5bfc undo/redo added to text areas in designer. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4656 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 23:12:21 +00:00
Tom Copeland
32da061555 Added Alan's article 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4655 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 22:43:14 +00:00
Xavier Le Vourch
ec24b90757 results Text area made non editable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4654 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 22:26:45 +00:00
Tom Copeland
e9ae40d1ba tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4653 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 17:08:40 +00:00
Brian Remedios
ec157c53a2 new facilities in prep for property management framework 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4652 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:52:37 +00:00
Brian Remedios
26f2a5fdfe Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4651 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:36:10 +00:00
Brian Remedios
6433ace8b7 Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4650 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:26:23 +00:00
Brian Remedios
e31e3387e5 Comment cleanup for bug #1512374 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4649 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 16:15:01 +00:00
Tom Copeland
80c477cb32 Fixed typo, thx to A.M. Berg for the report 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4648 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 04:52:42 +00:00
Tom Copeland
29a652acdf Renamed file to avoid confusing the Ant unit test globber 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4647 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 04:42:11 +00:00
Allan Caplan
8b577f11d6 Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4646 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 01:25:19 +00:00
Allan Caplan
07a82e37ca Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4645 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 01:16:57 +00:00
Allan Caplan
736a3560ea Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4644 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 00:56:57 +00:00
Allan Caplan
dd9da8fc4e Tweaking JUnit tests to be more complete 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4643 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-14 00:38:37 +00:00
Allan Caplan
b32e7fbd6b Improving JUnit tests 
I went over the output, it looks correct. For many, having a test will help down the road to throw a flag if anything changes


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4642 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 23:49:38 +00:00
Tom Copeland
3525293786 Fix from Jason Bennett: Fixed bug 1371753 - UnnecessaryLocalBeforeReturn is now less aggressive in its reporting. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4641 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 22:02:21 +00:00
Allan Caplan
8609d6de90 assertion for code fragment appended PMD.EOL. This would be correct, except on Windows systems it appears that the Dom is not using the system's carriage return, rather it always uses \n's. 
This test runs A-OK on linux, was failing on Windows. Runs A-OK for me on both now.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4640 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 21:05:16 +00:00
Allan Caplan
7e2877ec84 Added some JUnit tests, fixed comment in rule 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4639 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 20:54:08 +00:00
Allan Caplan
0d2aec583c Added some JUnit tests 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4638 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:32:12 +00:00
Tom Copeland
2c76cab7c7 Added new NpathComplexity rule from Jason Bennett 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4637 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:30:22 +00:00
Tom Copeland
730234d7ae Added new NpathComplexity rule from Jason Bennett 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4636 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 13:30:21 +00:00
Allan Caplan
36803bc9f6 Doing a JUnit review - checking tests with low coverage for what they're missing 
ExcessivePublicCount Rule looks OK, just added some missing JUnit tests


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4635 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 02:04:34 +00:00
Xavier Le Vourch
d60c00c5ab useless ; in java code removed 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4634 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 02:01:41 +00:00
Allan Caplan
8189d97f05 Doing a JUnit review - checking tests with low coverage for what they're missing 
ArrayIsStoredDirectly is documented as finding constructors, as well as methods, but only methods were tested. Adding a constructor to the test revealed a failed JUnit test - fixed rule.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4633 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-13 01:37:33 +00:00