hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
4,515 Commits 16 Branches 123 Tags
Commit Graph

4515 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Allan Caplan
b1460476ed Clearing up deprecations 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4779 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-06 01:41:06 +00:00
Allan Caplan
8580efe567 Moving test cases from xml deffinition into JUnit test 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4778 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-06 00:55:16 +00:00
Tom Copeland
71334e29c3 *** empty log message *** 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4777 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-03 04:03:14 +00:00
Tom Copeland
f7dc5ebd7b Removed Xalan jars. Since we're using JDK 1.4 we can just use javax.xml.blah. Note the Designer FIXME; still need to take care of that. But this trims things down quite nicely; yay JDK 1.4! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4776 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-03 03:52:41 +00:00
Jiger Patel
49d5dccc4d Fixed changes in JEditPMDRule as per new methods in Rule interface 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4775 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-02 07:11:26 +00:00
Xavier Le Vourch
c36123e401 asm updated to official 3.0 release 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4774 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-11-01 22:35:57 +00:00
Xavier Le Vourch
dcf23bb385 regression bug fix: pattern.matches threw NPE on null string. A pattern is overkill to test first char only 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4773 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 19:41:27 +00:00
Radim Kubacki
7544ffe9a5 mentioning JDk1.5 dep 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4772 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 08:41:40 +00:00
Radim Kubacki
4af0abfd2c fixing test deps 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4771 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 08:40:52 +00:00
Tom Copeland
26e199f98f Fixed spelling 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4770 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 07:11:53 +00:00
Tom Copeland
17d8d3c2bb Tightening up a bit on JDK 1.5 usage 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4769 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 07:04:25 +00:00
Radim Kubacki
be5faa39b6 generics 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4768 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 06:56:35 +00:00
Radim Kubacki
0bd8ce3bc2 need to cast with NB5.5 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4767 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 06:55:49 +00:00
Tom Copeland
5314563be6 Replaced Jakarta ORO with built-in java.util.regex. I think all these changes are correct - at least, all the tests pass - but if anyone notices anything awry, please let me know... thanks! 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4766 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 06:38:09 +00:00
Tom Copeland
e912255b43 One more tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4765 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 02:33:54 +00:00
Tom Copeland
f42be14252 That's more like it 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4764 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 01:38:04 +00:00
Allan Caplan
a6b80bb594 Removing patch 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4763 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-31 01:20:59 +00:00
Radim Kubacki
607ad3080d Switching source level to 1.5 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4762 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-30 21:44:57 +00:00
Radim Kubacki
76d6c7a1ac builds against trunk (no org.openide.src) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4761 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-30 19:42:27 +00:00
Tom Copeland
91b574d971 Er, that's not right... reverting my last checkin 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4760 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-29 20:09:35 +00:00
Tom Copeland
e1f2b92783 We can just call iterater(); no need to call isEmpty() first 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4759 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-29 20:05:06 +00:00
Tom Copeland
15d1c24887 findChildrenOfType never returns null; it just returns an empty List if there aren't any found 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4758 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-29 20:04:12 +00:00
Allan Caplan
da00dd2a2b Applied patch 1583167 - Better test code management from Wouter 
Made one small change - initial patch had resources in the same directory. Changed to look in current directory + xml. So, core rules are test.net.sf.pmd.rules.xml

If anyone disagrees with this I'm not 100% set on this decision - it made it cleaner to me


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4757 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-27 02:01:25 +00:00
Allan Caplan
523da8ab31 Removed unused and duplicate test. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4756 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-27 01:03:49 +00:00
Allan Caplan
a5a1a02cd6 ReportTest had a bunch of tests that weren't working commented out. Fixed 'em up, all green. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4755 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-27 01:02:19 +00:00
Xavier Le Vourch
21ba3d8e22 annotation before package could not be parsed 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4754 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-27 00:59:54 +00:00
Xavier Le Vourch
75664112cf PMD on PMD: UseCollectionIsEmpty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4753 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 23:55:50 +00:00
Xavier Le Vourch
3e7b44fb80 Bug fixes in UseCollectionIsEmpty: detect > 0, size() in expression is not valid ( .size() % mod == 0), NPE on jdk 6 source code 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4752 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 23:20:16 +00:00
Xavier Le Vourch
2e3a00b084 PMD on PMD: UseCollectionIsEmpty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4751 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:41:49 +00:00
Xavier Le Vourch
b022eaf244 PMD on PMD: import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4750 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:28:36 +00:00
Xavier Le Vourch
abb5dcd8ce Fixed bug in UselessOverridingMethod: false + when adding synchronization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4749 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 18:15:30 +00:00
Allan Caplan
afb64b04a6 Fixed UseCollectionIsEmpty rule to only fire on Collection types. Made the code abstract since it's very similar to InefficientEmptyStringCheck. 
The code also only found lst.size() == 0, and not 0 == lst.size(), that's fixed too.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4748 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 17:28:59 +00:00
Xavier Le Vourch
6c5338fdaf Fixed array handling in UnusedFormalParameter 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4747 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 16:56:14 +00:00
Brian Remedios
ffc5bcb052 minor tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4746 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 05:38:35 +00:00
Xavier Le Vourch
babfc20c39 Fixed array handling in AvoidReassigningParameters 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4745 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 05:29:52 +00:00
Allan Caplan
6215d97b9e Checkin of the Type Resolution Facility 
Re-implemented LooseCoupling as a new rule - new or changed type resolution rules should go in typeresolution to be separated.

I have not added this to 39.xml!

Sorry about the lack of comments, will go through and try and get important things commented.

There's a couple TODO's that if addressed should help performance.

Remember, to run compiled classes must be in the CLASSPATH!


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4744 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-26 02:35:38 +00:00
Xavier Le Vourch
15abbd44ae bug fix: incorrect detection of top level classes/interfaces (crashed on jdk 1.5 and 1.6 source code) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4743 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 23:21:30 +00:00
Xavier Le Vourch
9bad2be979 Fixed several rules (annotations related exceptions for on jdk 1.5 and jdk 1.6 source code) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4742 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 19:40:45 +00:00
Xavier Le Vourch
70a6550716 Fixed several rules (exceptions on jdk 1.5 and jdk 1.6 source code). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4741 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 02:26:36 +00:00
Xavier Le Vourch
3afd463075 fixed 1.5 parsing bugs: hex floating points, annotations before enum constants 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4740 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 01:59:11 +00:00
Allan Caplan
d8d36f0796 Type Resolution Code. Posting for comments. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4739 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 01:45:49 +00:00
Tom Copeland
c2e36685a7 Removed unused script element, thanks to Jason Bennett for the good catch 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4738 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-25 00:52:31 +00:00
Xavier Le Vourch
de7a4f1f70 NPE in rule LocalVariableCouldBeFinal on jdk 1.5 source code (RegexParser.java) 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4737 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-24 03:05:39 +00:00
Brian Remedios
833427e74f refactored common functionality 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4736 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 14:50:06 +00:00
Xavier Le Vourch
8cc36876c1 Fixed several rules (exceptions on jdk 1.5 source code). 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4735 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 07:05:21 +00:00
Xavier Le Vourch
5287ab72a2 Performance Refactoring, XPath rules re-written as Java: MoreThanOneLogger 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4734 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 05:42:36 +00:00
Xavier Le Vourch
b90fba9662 Performance Refactoring, XPath rules re-written as Java: AssignmentInOperand AvoidDollarSigns SuspiciousHashcodeMethodName UselessStringValueOf 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4733 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-23 00:17:58 +00:00
Xavier Le Vourch
e67a4521bc import cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4732 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 19:07:32 +00:00
Brian Remedios
b24b73850d + deprecation tag 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4731 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:54:46 +00:00
Brian Remedios
76fff7b62a updated 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4730 51baf565-9d33-0410-a72c-fc3788e3496d
 2006-10-21 14:50:36 +00:00