Commit Graph
6958 Commits
Author SHA1 Message Date
Andreas Dangel 2f53a3e795 pmd: fix #999 Law of Demeter: False positives and negatives 2013-03-17 11:03:02 +01:00
Andreas Dangel c8bf5d46a8 pmd: fix #975 false positive in ClassCastExceptionWithToArray 2013-03-17 10:11:02 +01:00
Andreas Dangel d7bdb79cdd pmd: fix #968 Issues with JUnit4 @Test annotation with expected exception
Thanks to Yiannis Paschalidis
2013-03-17 09:56:02 +01:00
Andreas Dangel 7947282704 pmd: verify #962 MethodReturnsInternalArray: False positive using a ternary operator 2013-03-16 22:09:36 +01:00
Andreas Dangel 4388806404 pmd: fix #976 UselessStringValueOf wrong when appending character arrays 2013-03-16 19:51:06 +01:00
Andreas Dangel 8ea9d29f31 pmd: fix #977 MisplacedNullCheck makes false positives 2013-03-16 19:17:48 +01:00
Andreas Dangel 72d07a8e7e pmd: fix #985 Suppressed methods shouldn't affect avg CyclomaticComplexity 2013-03-16 18:09:25 +01:00
Andreas Dangel c3e148174c pmd: fix #984 Cyclomatic complexity should treat constructors like methods 2013-03-16 17:15:40 +01:00
Andreas Dangel 22a2db080f pmd (site): add links to the rules from the rule index page 2013-03-16 15:22:31 +01:00
Andreas Dangel 0125e7a03b pmd (site): add missing default values of properties for documentation 2013-03-16 13:58:32 +01:00
Andreas Dangel 370ed23e01 pmd: fix #991 AvoidSynchronizedAtMethodLevel for static methods 2013-03-16 12:22:10 +01:00
Andreas Dangel dcaf06303c pmd: fix #997 Rule NonThreadSafeSingleton gives analysis problem 2013-03-16 12:05:05 +01:00
Andreas Dangel 54cab5de42 pmd: fix #992 Class java.beans.Statement triggered in CloseResource rule 2013-03-16 11:40:15 +01:00
Andreas Dangel bb083a7685 pmd: fix NPE in ConstructorCallsOverridableMethodRule 2013-03-15 21:54:02 +01:00
Andreas Dangel ea06bd063f pmd: switch to java 1.6
we already depend on it, e.g. jcommander requires a java 1.6 JRE
2013-03-15 21:49:28 +01:00
Andreas Dangel 7ae1e9c6dc pmd: fix #1032 ImmutableField Rule: Private field in inner class gives false positive
Improved symbol table resolution to check inner classes, too.
2013-03-15 21:37:02 +01:00
Andreas Dangel 2c5b6e1fdb pmd: verify #254 False+ : UnusedImport with Javadoc @link 2013-03-14 21:47:06 +01:00
Andreas Dangel 0739c2f601 pmd: fix #1005 False + for ConstructorCallsOverridableMethod - overloaded methods
It won't be perfect, but for constructor calls and method calls a
simple check of the argument types is done. Primitive types are
distinguished, reference types not.
In order to support all cases, full symbol resolution is needed.
2013-03-14 20:48:05 +01:00
Andreas Dangel 3ce242c179 pmd: cleanup design test cases 2013-03-13 20:31:33 +01:00
Andreas Dangel 3bf8eb9d1f pmd: #1002 False +: FinalFieldCouldBeStatic on inner class 2013-03-13 20:02:22 +01:00
Andreas Dangel 511fd6fb58 pmd: fix #1073 Hard coded violation messages CommentSize 2013-03-10 09:48:11 +01:00
Andreas Dangel 4f1cfd6125 pmd: fix #1074 rule priority doesn't work on group definitions
and verify #1067 Custom Ruleset doesn't import the complete ruleset anymore by reference
2013-03-09 17:51:06 +01:00
Andreas Dangel 6426deca6b pmd: add versions maven plugin 2013-03-05 22:32:53 +01:00
Andreas Dangel 5b3405d93b pmd: fix changelog version info 2013-03-05 22:32:44 +01:00
Andreas Dangel 9623d61310 pmd: fixed #1064 Exception running PrematureDeclaration 2013-03-05 22:30:03 +01:00
Romain PELISSE d675790e58 Redesign GuardLogStatement:
Turns out that the implementation based on the one published by Heiko Rupp
could simply not catch all the case in our test suite. I therefore opted to
backport the previous implementation - a simple Xpath rule, from GuardDebugLogStmt
into a java class.
Performance are not as good as the one based on Heiko's proposal, but it still
twice faster as the simple GuardDebogLogStmt (instead of five times faster). However,
correctness is in this case more important.
2013-03-03 19:19:51 -05:00
Romain PELISSE bac738c01a GuardLogStatement: small docs fixes 2013-03-01 18:29:48 -07:00
Romain PELISSE 6576056eaf Merge changelog 2013-03-01 18:20:44 -07:00
Romain PELISSE 42d51ad423 Enhance GuardDebugLogging:
- replace xpath implementation by newly created GuardLogStatementRule
- increase performance by 5 (from 0.5s to 0.1s)
2013-03-01 18:19:31 -07:00
Romain PELISSE f2f31990aa Enhance GuardLogStatement:
- add property support to specify which statement needs to be checked
- move out of the java logging to be placed in logging-jakarta
2013-03-01 18:19:31 -07:00
Romain PELISSE 4bce034c33 Add GuardLogStatement
Based on Heiko Rupp implemetation: http://pilhuhn.blogspot.com/2008/09/pmd-rule-to-check-for-unguarded.html
2013-03-01 13:34:00 -07:00
Andreas Dangel 45d10aaa7c pmd: fixed #1068 CPD fails on broken symbolic links 2013-03-01 19:52:41 +01:00
Andreas Dangel d9f8e62d3c pmd: verify #1047 False Positive in 'for' loops for LocalVariableCouldBeFinal 2013-03-01 19:06:01 +01:00
Romain PELISSE a90e9fed0b Add new ecmascript rules to changelog 2013-02-28 16:34:48 -07:00
Romain PELISSE c36b3c47c9 ecmascript: UseBaseWithParseInt
Add a new rule called UseBaseWithParseInt in the basic
new ruleset, for EcmaScript.

Done while during the Java Posse Round up 2013 workshop:
'Make Javascript a better world with PMD'
2013-02-28 16:34:27 -07:00
Romain PELISSE 148a1016fb ecmascript: AvoidWithStatement
Add a new rule called AvoidWithStatement along with a
new ruleset, Controversial, for EcmaScript.

Done while during the Java Posse Round up 2013 workshop:
'Make Javascript a better world with PMD'
2013-02-28 16:18:41 -07:00
Andreas Dangel 7712690d55 pmd: update release docu 2013-02-03 19:20:18 +01:00
Andreas Dangel 3438796471 pmd: update website for 5.0.2 2013-02-03 19:19:58 +01:00
Andreas Dangel 5e522fccd1 pmd: set release date for 5.0.2 2013-02-03 18:26:21 +01:00
Andreas Dangel c3f3adbd4c pmd: update changelog for 5.0.2/5.1.0 2013-02-03 15:30:20 +01:00
Andreas Dangel b0e6810b58 pmd: verify empty if statement example 2013-02-03 15:18:52 +01:00
Torsten Kleiber 0524752248 Fix for bug #1056 "Error while processing" while running on xml file with DOCTYPE reference
Change the initial value of XINCLUDE_AWARE_DESCRIPTOR to false
This does validate an invalid doctype reference as in some ide generated xml files exist.
Any xml rule, which needs this property should overwrite this value with true.
2013-01-31 21:52:13 +01:00
Romain PELISSE db05bcb8a7 pmd: AntTask support for language
- fix  #1004 targetjdk isn't attribute of PMD task
- introduce a new element, called <language>, that replaces the already existing <version/> element
2013-01-29 12:22:08 +01:00
Romain PELISSE 9954f1d8e1 pmd: fix typo in ReadMe.txt 2013-01-28 00:54:18 +01:00
Romain PELISSE b1cae214cd pmd: fix #1004 targetjdk isn't attribute of PMD task 2013-01-28 00:53:41 +01:00
Romain PELISSE 5ffb5bc8c2 Merge branch 'master' of github.com:pmd/pmd 2013-01-26 20:23:50 +01:00
Romain PELISSE 167c4da9ba pmd: fix #1049 Errors in "How to write a rule" 2013-01-26 20:23:36 +01:00
Andreas Dangel 302bfe41fd pmd: configure surefire to run tests in alphabetical order, so that test failure are better reproducible 2013-01-26 20:03:39 +01:00
Andreas Dangel 6e01b91a73 pmd: fix #1030 CPD Java.lang.IndexOutOfBoundsException: Index: 2013-01-26 20:01:14 +01:00
Andreas Dangel 3f10a9ecb8 pmd: verify #946 ImmutableField false + 2013-01-26 15:50:56 +01:00