Andreas Dangel
3449c9a372
Merge branch 'pr-2478'
...
[java] New rule: LiteralsFirstInComparisons #2478
2020-05-18 20:17:23 +02:00
Andreas Dangel
526526be47
[java] Reformat (whitespaces) LiteralsFirstInComparisons.xml
2020-05-18 20:16:41 +02:00
Andreas Dangel
7138d2e4d4
[doc] Update release notes, refs #2478
2020-05-18 20:11:45 +02:00
Andreas Dangel
3305eeedd2
[core] Add new rule to releases ruleset for 6.24.0
2020-05-18 20:11:25 +02:00
Andreas Dangel
0fa0c4a70c
[java] add new rule in quickstart.xml
2020-05-18 20:11:04 +02:00
Andreas Dangel
979d81c02e
Merge branch 'pr-2481'
...
[java] Fix JUnitSpellingRule false positive #2481
2020-05-18 19:57:45 +02:00
Andreas Dangel
33e3bc24c4
[doc] Update release notes, fixes #2477 , refs #2481
2020-05-18 19:57:05 +02:00
Andreas Dangel
dfd5e608d6
[java] Remove unnecessary CDATA in JUnitSpelling.xml
2020-05-18 19:55:39 +02:00
Artem Krosheninnikov
ad68cdda24
Fix review remarks
2020-05-16 23:26:24 +03:00
Clément Fournier
382a1a15f6
Merge branch 'improve-alias-api'
2020-05-16 19:22:10 +02:00
Clément Fournier
35e9f7d1bd
Doc
2020-05-16 19:19:48 +02:00
Clément Fournier
c5f73d137a
Add test for invalid language version NPE
...
Refs https://github.com/pmd/pmd/pull/2486#discussion_r425381773
2020-05-16 19:07:09 +02:00
Clément Fournier
e1a22282d0
Merge branch 'master' into improve-alias-api
2020-05-16 18:56:54 +02:00
Juan Martín Sotuyo Dodero
465dead81c
Optimize imports
2020-05-15 11:44:09 -03:00
John Teng
72128e1476
fixed the rule version, removed CDATA tags from descriptions
2020-05-15 10:43:51 -04:00
Juan Martín Sotuyo Dodero
0f552ee620
Further refine the addVersion API
2020-05-15 11:42:28 -03:00
Juan Martín Sotuyo Dodero
d1e0f8c5fa
Bring back binary compatibility
2020-05-14 16:30:06 -03:00
Juan Martín Sotuyo Dodero
8c7a49eb69
[core] Revamp the language version alias APIs
...
- The old experimental API allowed calls such as
`addVersions(langHandler, false)` which were not only invalid, but would
throw an `ArrayIndexOutOfBoundsException`, so we split the name
(required) and the aliases (varargs, and therefore optional)
- In doing so, I was bothered by parameter order. The version name is
the most significant change when setting 2 versions for a language, so I
liked it being first as the old `addVersion` method did, so I moved
that ahead.
- With that, I now had 2 methods that where equivalent, except one
allowed for varargs and the other didn't… so I merged them. This is not
100% binary compatible, but it is source compatible (that is, unless you
used reflection, all valid calls to the old non-experimental method
still work).
2020-05-14 16:03:45 -03:00
Andreas Dangel
0196ca7a0c
Merge branch 'pr-2479'
...
[java] False positive with Hamcrest's assertThat #2479
2020-05-14 20:36:02 +02:00
Andreas Dangel
a9dda0336d
[doc] Update release notes, fixes #2288 , refs #2479
2020-05-14 20:30:29 +02:00
Andreas Dangel
8fce3a300f
[java] Small refactoring for JUnitTestsShouldIncludeAssertRule
2020-05-14 20:30:24 +02:00
Andreas Dangel
27b2b881d7
Merge branch 'pr-2485'
...
[core] Require Java 11 #2485
2020-05-14 19:59:28 +02:00
Andreas Dangel
c739b9c14f
[doc] Update release notes, fixes #2484 , refs #2485
2020-05-14 19:59:18 +02:00
Andreas Dangel
9fd1dc9ca2
[doc] Update build instructions to require java 11 from now on
2020-05-14 19:58:08 +02:00
Juan Martín Sotuyo Dodero
900768ace5
Require Java 11
2020-05-14 12:28:25 -03:00
Clément Fournier
a12d13a1ac
Merge branch 'javascript-ast-tests'
2020-05-13 16:06:49 +02:00
Clément Fournier
ccd851dc9c
Merge branch 'master' into javascript-ast-tests
2020-05-13 16:06:24 +02:00
Artem Krosheninnikov
8b5be784fd
fix pmd violation
2020-05-13 02:05:27 +03:00
Artem Krosheninnikov
d349d66696
fix JUnitSpellingRule false positive, closes #2477 . Also add two more tests
2020-05-13 01:46:36 +03:00
andreoss
1f0d7ae620
[java] False positive with Hamcrest's assertThat
...
Fixes #2288
2020-05-12 17:51:54 -04:00
John Teng
99db8b4373
Added new rule to bestpractices category, added unit tests for all comparison cases
2020-05-12 17:07:21 -04:00
John Teng
8ff452080b
Added new rule corresponding to all string literal comparisons
2020-05-12 17:06:08 -04:00
Andreas Dangel
2bce93c8b6
Merge branch 'pr-2457'
...
[xml] Adding XML to CPD supported languages #2457
2020-05-08 10:56:52 +02:00
Andreas Dangel
8d87b9fd70
[doc] Update release notes, refs #2457
2020-05-08 10:55:55 +02:00
Andreas Dangel
9eba0a03c3
[core] AntlrTokenizer.getCharStreamFromSourceCode is now public
2020-05-08 10:55:35 +02:00
Andreas Dangel
b740225079
[doc] Update release notes, refs #2469 , fixes #2468
2020-05-08 10:30:31 +02:00
Robert Sösemann
c48e25da9e
Merge pull request #2469 from gwilymatgearset/apex/fix-false-positive-with-method-called
...
[apex] fix false positive unused variable if only a method is called
2020-05-07 21:11:22 +02:00
Fernando Cosso
4f96286902
Implementing changes from the discussion
2020-05-07 11:49:52 -04:00
Gwilym Kuiper
3571608234
Handle chained method calls.
...
This wasn't working because they had a null image. Turns out that nodes
have a method called `hasImageEqualTo` which handles the null case for
us.
2020-05-06 11:26:14 +01:00
Gwilym Kuiper
acbf53e8ab
Variable is used if method is called on it
2020-05-06 11:11:13 +01:00
Fernando Cosso
a2cd3fd8e5
Removed tab character in pom.xml
2020-04-30 16:38:03 -04:00
Fernando Cosso
3a3b0a0908
Adding antlr4 to pom, tests
2020-04-30 15:16:31 -04:00
Andreas Dangel
4d2749b697
Merge branch 'pr-2452'
...
[doc] Fix "Making Rulesets" doc sample code indentation #2452
2020-04-30 19:42:13 +02:00
Andreas Dangel
f636c1fe8c
[doc] Update release notes, refs #2452
2020-04-30 19:41:39 +02:00
Andreas Dangel
522e98b65f
Merge branch 'pr-2446'
...
[core] Update maven-compiler-plugin to 3.8.1 #2446
2020-04-30 19:29:38 +02:00
Andreas Dangel
fdabf7e25d
[doc] Update release notes, refs #2446
2020-04-30 19:28:35 +02:00
Fernando Cosso
15da8cb16a
Adding XML to CPD
2020-04-30 13:06:52 -04:00
Andreas Dangel
01c5900e7e
Merge branch 'pr-2449'
...
[plsql] Additional info in SqlStatement, FormalParameter and FetchStatement #2449
2020-04-30 18:55:44 +02:00
Andreas Dangel
6c97fb093b
[doc] Update release notes, refs #2449
2020-04-30 18:54:36 +02:00
Andreas Dangel
ad8662ccc4
[plsql] Add more tests
2020-04-30 18:52:21 +02:00