hiifong/pmd
1
0 Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
5,769 Commits 16 Branches 123 Tags
3e304984ece6d8c19d6abead25a8d010b7e67f7d
Commit Graph
5769 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Le Vourch 3e304984ec oops, previous change broke the build because of pmdOnPmd violation 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6410 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 19:43:10 +00:00
Xavier Le Vourch 98e66f6317 merged from 4.2.x: Fixed false negative in UselessOverridingMethod 
The only change is from "< 0" to "> 0", the rest if reformatting


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6409 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 19:21:56 +00:00
Ryan Gustafson 7c928df479 Formatting change, to make future diffs easier to understand. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6407 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 07:00:02 +00:00
Ryan Gustafson 182232760d Delete bogus folder Subclipse decided to helpfully create when I tried to disconnect/re-connect a Project to SVN. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6406 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 05:56:21 +00:00
Ryan Gustafson 2283c03f91 Initial import. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6405 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 05:50:16 +00:00
Brian Remedios 7f9c1d92d6 Javadoc cleanup per Checkstyle warnings 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6404 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 05:38:13 +00:00
Brian Remedios 63cfd6ccf0 Refactored IntegerProperty to gain upper/lower limits per other numeric types. Updated all rules that use them with best-guess boundary values. 
Updated changelog.txt

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6403 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 05:10:48 +00:00
Brian Remedios f7d2529a79 Javadoc cleanup only 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6402 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 02:46:43 +00:00
Brian Remedios bab5adaf81 Minor code cleanup, Javadoc tweaks, implemented choices() method on EnumeratedProperty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6401 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-26 00:55:29 +00:00
Xavier Le Vourch 630b4988c5 merged from 4.2.x branch: All comment types are now stored in ASTCompilationUnit, not just formal ones 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6399 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 19:40:40 +00:00
Xavier Le Vourch fa89131b76 code cleanup: javadoc warnings removed 
reformatting to use only spaces and not tabs


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6397 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 03:54:27 +00:00
Xavier Le Vourch 5dcf77bd74 eclipse complained about incorrect @Override annotations 
reformating to use spaces intead of tabs


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6396 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 03:13:00 +00:00
Xavier Le Vourch e57f747c43 String.isEmpty() is only available in jdk1.6, cannot be used for testing for jdk1.4 or 1.5 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6395 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 01:51:14 +00:00
Xavier Le Vourch 630aa59c83 suite() must be defined for tests using jdk 1.4 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6394 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 01:50:31 +00:00
Brian Remedios 3abcb539f3 revert previous adjustment in MethodProperty, they public static values after all 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6393 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 01:13:17 +00:00
Brian Remedios d1ed718e2b +Javadoc, minor code cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6392 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 01:03:01 +00:00
Brian Remedios c013c569da +Javadoc & rm dead constant in AbstractPackagedProperty 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6390 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 00:53:22 +00:00
Brian Remedios 22c7ac3c54 bugfix for MethodPropertyTest, rm dead code in CharacterPropertyTest, misc Javadoc in EnumPropTest. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6389 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-25 00:35:47 +00:00
Brian Remedios bfa41bb6cd Completed Method & Type property descriptors and refactored them under a common class that can filter by optional package prefixes. Matching test cases for same. 
Updated TypeMap to catch errors, new test cases.

Updated ClassUtil with new functionality for the new descriptors and restored lost indentation formatting.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6388 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-24 23:05:01 +00:00
Ryan Gustafson 3e984b1220 Added credit for Jared's patch. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6387 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-24 06:10:08 +00:00
Ryan Gustafson f7398730ef JavaCC code generation modified to include the Token class. Now the only thing not regenerated should be the AST classes. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6383 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-24 01:47:26 +00:00
Ryan Gustafson e3ffba580c Java grammar enhanced to include AnnotationMethodDeclaration as parent node of method related children of AnnotationTypeMemberDeclaration. 
JavaCC generated artifacts updated to JavaCC 4.1d1.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6382 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-23 05:50:30 +00:00
Ryan Gustafson 48df917cb6 JavaDoc warning fixes from 'qa' target. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6381 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-22 03:44:48 +00:00
Brian Remedios 6f9e4ca14b minor performance tweak 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6380 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-22 02:41:41 +00:00
Brian Remedios 16dd7f76e3 minor cleanup: new Integer() -> Integer.valueOf(), ditto for Float & Double classes as well. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6379 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-22 02:29:54 +00:00
Brian Remedios 4ee22c4c8b Minor JavaDoc cleanup and tweaks within the properties & related test classes, no functional changes 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6378 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-22 01:38:45 +00:00
Xavier Le Vourch 69bd24e811 make sure site generation doesn't keep older files 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6377 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-21 21:28:20 +00:00
Xavier Le Vourch a7fce3aa03 clover version update 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6376 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-21 20:30:48 +00:00
Brian Remedios 308c458690 bugfix for faulty randomDouble generator 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6375 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-21 02:52:13 +00:00
Brian Remedios 61070bc9cf Refactored FloatProperty under Abst.Numeric to gain bounding limits. Adjusted test cases to match. Some JavaDoc tweaks as well. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6374 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-21 01:58:41 +00:00
Brian Remedios 7c6f11dd07 Minor revision to PropertyDescriptor interface (maxValueCount -> isMultiValue) 
Reworked all property descriptors, augmented JUnit tests

Added the core get/set methods to the Rule interface, remaining Type & Method property descriptors need further refinement

Added pass-through methods on RuleDelegate per changes in Rule interface

Added new AbstractNumericProperty that captures boundary limits for external editors. DoubleProperty is subclass of it, others to follow once all is ok after this check-in

Deprecated all remaining string-based property accessors, need to figure out how to accommodate XPATH parms and the like. All rules with properties need descriptors to access them, may use alternate approach for external XPATH ones?

Minor optimization in RuleSetFactory

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6373 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-20 22:44:00 +00:00
Brian Remedios 157d89fa80 New isEmpty() method for upcoming changes, StringBuffer -> StringBuilder substitution 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6372 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-20 04:11:13 +00:00
Xavier Le Vourch 15e2eb7d9e merged from 4.2.x: Fixed bug 2056318 - False positive for AvoidInstantiatingObjectsInLoops 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6371 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-19 22:20:27 +00:00
Ryan Gustafson 3f3dab563b Added YourKit Java Profiler logo to Credits. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6368 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-15 13:32:51 +00:00
Romain Pelisse 3f306ba17c I assigned to myself some item on the TODO list in the changelog. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6367 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-11 14:55:32 +00:00
Brian Remedios f835824c53 Collect all rule property values as a map for an external editor 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6366 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-11 03:16:31 +00:00
Brian Remedios 1e8a786f0e fix for capitalization issue identified in build report 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6365 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 18:15:14 +00:00
Brian Remedios 44245a61cc typos 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6364 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 18:09:08 +00:00
Brian Remedios ba5ab3d250 typo, added description 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6363 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 18:08:12 +00:00
Brian Remedios e86724fb17 ordered descriptor properties 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6362 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 18:05:44 +00:00
Brian Remedios 9f05067482 "." -> '.' replacements, +TODO comment 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6361 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 18:03:11 +00:00
Brian Remedios b1e4e8da64 +comment: threshold property should be an int vs a string? Also the descriptor names are too generic, potential for clash with other rules. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6360 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 17:59:25 +00:00
Brian Remedios 13e6659cc6 fix for invalid use of property descriptors 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6359 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 17:57:46 +00:00
Brian Remedios bd2d407253 static initialization cleanup 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6358 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 17:56:19 +00:00
Brian Remedios fad5f31f92 Optimization: replaced StringBuffer with StringBuilder 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6357 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-10 17:06:55 +00:00
Brian Remedios f11c920a88 typos 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6356 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-09 07:59:57 +00:00
Brian Remedios d571ef2874 cleanup per issues noted in build rpt 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6355 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-09 07:12:59 +00:00
Brian Remedios 84aa5365d0 whoops..bugfix for earlier commit 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6354 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-09 06:47:36 +00:00
Brian Remedios d43c123b56 cleanup per issues noted in build break rpt 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6353 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-09 06:41:54 +00:00
Brian Remedios 92f5b2ad78 append single char vs single char string optimization 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6352 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-08-09 06:30:51 +00:00