4211 Commits

Author SHA1 Message Date
Tomasz Slota
6bdafe06b4 fixed a threading problem
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4522 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-22 12:39:39 +00:00
Tom Copeland
5f988bbe6d More DFA tweaks from Sven Jacob
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4521 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-22 02:54:03 +00:00
Tom Copeland
0db7c7d108 Adding Alan Ezust; he'll be working on the jEdit plugin with Jiger
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4520 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-21 23:20:49 +00:00
Tom Copeland
c5bfc2f410 Removed a hardcoded 'NOPMD'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4519 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-21 19:17:09 +00:00
Tom Copeland
9fb0af8b0f Rewrote the NOPMD mechanism to collect NOPMD markers as the source file is tokenized. This eliminates an entire scan of each source file.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4518 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-21 03:17:18 +00:00
Tomasz Slota
b5b423d53b increased version number, added myself to the list of authors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4517 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 06:11:10 +00:00
Tom Copeland
e65de99ef0 Fixed bug 1561784 - AbstractOptimizationRule no longer throws ClassCastExceptions on certain postfix expressions.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4516 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 03:59:54 +00:00
Tom Copeland
dc68f9a8fb Patch to fix false+ in SimplifyConditional; thanks again to Xavier!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4515 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 03:54:09 +00:00
Tom Copeland
6e45b64f82 False+ fix from Xavier
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4514 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 03:50:49 +00:00
Tom Copeland
e4662f814d Speling patch from Xavier Le Vourch
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4513 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 03:48:43 +00:00
Tom Copeland
937245f9b6 Applied patch from Brian Remedios to clean up CPD display a bit; thanks Brian!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4512 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-20 03:45:06 +00:00
Tom Copeland
341923aa48 added more detail to designer display
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4511 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-19 14:04:21 +00:00
Tom Copeland
65b7ded4a0 Made some constants uppercase
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4510 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-19 13:58:44 +00:00
Tomasz Slota
975616a0a9 - showing search results in a sortable table
- showing a number of violations found


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4509 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-18 18:53:45 +00:00
Tom Copeland
ad41625818 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4508 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-16 04:09:02 +00:00
Tom Copeland
6a8a913479 Added Tomas Slota to various places, welcome aboard Tomas!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4507 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-16 04:07:42 +00:00
Tom Copeland
3ebcb8a503 Removing the front page book advertisement
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4506 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-14 13:28:32 +00:00
Tom Copeland
a6a8d7e14a Applied patch from Xavier Le Vourch to reduce false postives from CloneMethodMustImplementCloneable.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4505 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-13 03:24:24 +00:00
Tom Copeland
fd46de18d8 Applied patch from Jason Bennett to enhance CyclomaticComplexity rule to account for conditional or/and nodes, do stmts, and catch blocks.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4504 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-13 02:50:47 +00:00
Tom Copeland
e9ed53f161 BrokenNullCheck added to various places
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4503 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-12 02:04:08 +00:00
Allan Caplan
6007383d6f Performance improvement for the NonThreadSafeSingleton rule.
Scanning PMD src goes from 45 seconds to 16 seconds. Performance improvement is huge on larger sources - 7,000 classes scanned in 3 minutes down from 7

Also fixed defect 1544565 - False Negative on NonThreadSafeSingleton. The existing rule wasn't finding any references if there was more than 1 statement in the if statement.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4502 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-12 01:09:24 +00:00
Jiger Patel
08c5a3c830 Initial Checkin. Represents on PMD Rule.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4501 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-11 05:42:09 +00:00
Tom Copeland
3338b44464 Added new rule written by Wouter Zelle - BrokenNullCheck. Thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4500 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-06 01:08:03 +00:00
Tom Copeland
f0bfc7cc65 Added WLW plugin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4499 51baf565-9d33-0410-a72c-fc3788e3496d
2006-09-06 00:33:31 +00:00
Allan Caplan
7d1ae38e9e New rule - dexter riley mentioned here http://sourceforge.net/forum/forum.php?thread_id=1548419&forum_id=188192
I had been working on it, it's Pretty Much Done, but checking in so he can give it a go


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4498 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-24 13:45:19 +00:00
Tom Copeland
dab2843293 Some fixes from Sven Jacob for the DFA layer - forgot to add this file
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4497 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-23 21:41:05 +00:00
Tom Copeland
f9ce45ff1e Some fixes from Sven Jacob for the DFA layer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4496 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-23 13:19:33 +00:00
Allan Caplan
9004416f52 1544564 - LooseCoupling rule doesn't check ArrayList
Added ArrayList and java.util.ArrayList to the list of implementation classes for this test to cover.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4495 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-22 13:25:32 +00:00
Tom Copeland
918ec92547 More CPD GUI tweaks from Brian Remedios; thanks Brian!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4494 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-17 13:29:23 +00:00
Jiger Patel
4af46645f7 1. Added new option "Print Rulename in ErrorList" which is helpful to trace down what rule is generating this error.
2. Lots of code cleanup using PMD!


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4493 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-16 09:42:52 +00:00
Tom Copeland
f67b9f269d Added a nice new XML to HTML stylesheet for CPD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4492 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-14 14:09:56 +00:00
Jiger Patel
6b6ef1e31b Removed SOP
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4491 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 09:41:39 +00:00
Jiger Patel
1cc144ac10 Changed the way Rules are managed and given for execution to PMD due to addition of new languages to PMD and was giving error due to language mismatch.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4490 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 09:25:08 +00:00
Tom Copeland
cd6b4fcb33 Fixed bug 1531236 - IdempotentOperations reports fewer false positives.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4489 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 04:44:00 +00:00
Tom Copeland
2404377dbb Fixed bug 1531152 - CloneThrowsCloneNotSupportedException now reports the proper line number.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4488 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 04:33:13 +00:00
Tom Copeland
95da3310a4 *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4487 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 04:16:57 +00:00
Tom Copeland
9626cb63c1 Modified C++ tokenizer to use the JavaCC STATIC option; this results in about a 30% speedup in tokenizing. Also improved error messages.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4486 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 04:14:41 +00:00
Tom Copeland
07376a9373 Cleaning this up so it doesn't use the deprecated methods... they will go away soon
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4485 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-09 04:14:22 +00:00
Jiger Patel
e8e04d79b6 Fixed UI Layout issues in PMD Options
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4484 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-08 11:58:44 +00:00
Tom Copeland
d30395dc3e *** empty log message ***
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4483 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-07 14:51:56 +00:00
Tom Copeland
a08ec714df rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4481 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-07 14:25:11 +00:00
Tom Copeland
5cb7088581 Fixed bug 1531593 - UnnecessaryConversionTemporary no longer reports false positives when toString() is invoked inside the call to 'new Long/Integer/etc()'.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4480 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-03 14:48:57 +00:00
Tom Copeland
656b7856ad Many improvements to CPD - mostly the GUI, but also efficiency tweaks in the renderers. Thanks to Brian Remedios for the code!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4479 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-01 21:59:19 +00:00
Tom Copeland
008c2e2ffc updating to pmd 3.7
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4478 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-01 13:28:45 +00:00
Tom Copeland
83e9e58e52 Moved JSP/JSF rulesets to rulesets/jsprulesets.properties
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4477 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-01 02:01:50 +00:00
Tom Copeland
bf2c11d7f0 Added Paul Duvall's article
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4476 51baf565-9d33-0410-a72c-fc3788e3496d
2006-08-01 01:56:30 +00:00
Tom Copeland
5a99552371 Fixed bug 1529805 - UnusedModifier no longer throws NPEs on JDK 1.5 enums.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4475 51baf565-9d33-0410-a72c-fc3788e3496d
2006-07-28 12:59:35 +00:00
Tom Copeland
f9274c68bb Added AE since they wrote the JSP integration, good stuff
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4474 51baf565-9d33-0410-a72c-fc3788e3496d
2006-07-27 21:30:05 +00:00
Allan Caplan
ad5981d3ad Fixed bug 1462189 - InsufficientStringBufferDeclaration now resets when it reaches setLength the same way it does at a Constructor
Fixed bug 1497815 - InsufficientStringBufferDeclaration rule now takes the length of the constructor into account, and adds the length of the initial string to its initial length


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4473 51baf565-9d33-0410-a72c-fc3788e3496d
2006-07-26 00:37:53 +00:00
Allan Caplan
7f1359d2b8 Performance improvement for the SingularField rule.
Scanning PMD src goes from 2minutes down to 25 seconds. Performance improvement is huge on larger sources - 7,000 classes scanned in 4 minutes down from 55!

Also fixed defect 1526530 SingularField False Negativesrule now detects problems inside static and constructor blocks


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4472 51baf565-9d33-0410-a72c-fc3788e3496d
2006-07-23 23:58:15 +00:00