hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
12,739 Commits 16 Branches 123 Tags
Commit Graph

1769 Commits

Author SHA1 Message Date
Juan Martín Sotuyo Dodero
c3dcb70e9c Further improvements 2018-05-22 01:45:13 -03:00
Karl-Philipp Richter
16ad6904bd Adjust InefficientEmptyStringCheck documentation 
InefficientEmptyStringCheckRule.java and the corresponding section
both contain information which the other doesn't. The class Javadoc and
the description section in performance.xml has thus been adjusted.
 2018-05-22 06:40:25 +02:00
Juan Martín Sotuyo Dodero
c417d68191 Merge branch 'pr-1126' 2018-05-21 17:00:10 -03:00
Andreas Dangel
4138cdc018 Merge branch 'pr-966' 2018-05-21 14:57:34 +02:00
Andreas Dangel
43f9237e63 Update release notes, fixes #955, refs #966 2018-05-21 14:55:16 +02:00
Andreas Dangel
af7a8b3eb6 Merge branch 'pr-1123' 2018-05-21 13:45:20 +02:00
Andreas Dangel
c95428d27a Merge branch 'pr-1046' 2018-05-21 13:12:24 +02:00
Andreas Dangel
b3460f6951 whitespaces, javadoc 2018-05-21 12:53:51 +02:00
Andreas Dangel
f14fbd02b5 Rework InsecureCryptoIvRule to use RuleChain on AllocationExpression 
No need for Util. Use Symbol Table instead.
 2018-05-21 12:46:29 +02:00
Andreas Dangel
e9f6668c9b Rework HardCodedCryptoKeyRule to use RuleChain on AllocationExpression and symbol table 2018-05-21 12:40:34 +02:00
Andreas Dangel
af250c3503 whitespaces 2018-05-21 11:56:23 +02:00
Andreas Dangel
ac7b94aaa2 The rule is new with 6.4.0. Sort alphabetically 2018-05-21 11:52:11 +02:00
Andreas Dangel
4d31d1fb04 whitespaces 2018-05-21 11:51:24 +02:00
Andreas Dangel
1ee12a4792 Merge branch 'pr-1080' 
Fixes #1018
 2018-05-21 11:39:21 +02:00
Karl-Philipp Richter
1f18181ef5 Improve implementation hint in InefficientEmptyStringCheck 
The alternative implementation mentions iterating over the string and
checking for whitespace which is pretty clear, however, showing the
implementation doesn't hurt, nor does the hint for Apache
commons-lang's StringUtils.isBlank which does exactly that.

The if statement in the demonstration of inefficient code can lead to
confusion because users _might_ think that the check is only
inefficient inside an if statement although it's clear from the
description that it's not.
 2018-05-21 06:15:17 +02:00
Juan Martín Sotuyo Dodero
625431f8b1 Remove unnecessary log 2018-05-20 20:33:26 -03:00
Juan Martín Sotuyo Dodero
998dd2d3ee Merge branch 'pr-1111' 2018-05-20 02:48:22 -03:00
Juan Martín Sotuyo Dodero
3bbebdcabd Fix checkstyle 2018-05-20 02:32:10 -03:00
Juan Martín Sotuyo Dodero
7a23ca638a Avoid NPE 
- Fix a bunch of errors in message building along the way
 2018-05-20 02:25:58 -03:00
Clément Fournier
a4ea6f8fb5 Multiple improvements and bug corrections in VariableDeclaratorId 2018-05-20 01:09:24 +02:00
Clément Fournier
07b8c4f9b2 Merge branch 'pr-1068' 2018-05-20 01:09:10 +02:00
Andreas Dangel
25f51db8d7 [java] Parser Error / Nullpointer when analyzing local generic class 2018-05-19 14:33:30 +02:00
Andreas Dangel
bdb48a963f whitespace 2018-05-19 14:09:32 +02:00
Andreas Dangel
f5f07220ad [java] Fix NPE in InsecureCryptoIvRule 2018-05-19 14:06:02 +02:00
Clément Fournier
c10d920248 Fix implementation of isFindBoundary, add some doc 2018-05-18 21:00:35 +02:00
Clément Fournier
eb4610c0fc Add regression test case, refs #1108 2018-05-17 23:08:25 +02:00
Andreas Dangel
69fc648edd [java] JUnit4TestShouldUseTestAnnotation 
*   use xpath 2.0
*   add new regex parameter
*   use typeof
 2018-05-17 20:35:58 +02:00
Andreas Dangel
dcf73bf91a [java] False Alarm of JUnit4TestShouldUseTestAnnotation on Predicates 
Fixes #572
 2018-05-17 16:32:47 +02:00
Clément Fournier
cb6b8277e4 Merge branch 'pr-1101' 2018-05-17 13:48:49 +02:00
Clément Fournier
b93320f723 Update release notes, refs #1101 
Closes #1021
 2018-05-17 13:47:24 +02:00
Akshat Bahety
6d1d5e5963 Code Style Changes 2018-05-17 12:44:33 +05:30
Akshat Bahety
dd3f20956f Changes 2018-05-16 23:04:42 +05:30
Juan Martín Sotuyo Dodero
d2dcbd4f1c Merge branch 'master' into issue-1051 2018-05-15 10:25:50 -03:00
Akshat Bahety
efc4644b93 Checkstyle Update 2018-05-15 17:57:18 +05:30
Andreas Dangel
03354aa92a Merge branch 'pr-1097' 2018-05-15 09:17:30 +02:00
Andreas Dangel
393cac8930 [java] Use typeResolution for AvoidThrowingRawExceptionTypes 2018-05-15 09:16:04 +02:00
Andreas Dangel
a5207b017c Merge branch 'pr-1098' 2018-05-15 09:09:51 +02:00
Andreas Dangel
bc31d9ac63 [java] Simplify ByteInstantiation and ShortInstantiation, too 
refs #1098
 2018-05-15 09:07:52 +02:00
Akshat Bahety
80d87aab0f Fixes #1021 
adding the error file for typeres
 2018-05-14 20:03:35 +05:30
Akshat Bahety
8fb843626c Merge branch 'master' of https://github.com/pmd/pmd 2018-05-14 19:52:28 +05:30
Akshat Bahety
958fd34c0f Fixes #1021 2018-05-14 19:45:41 +05:30
Juan Martín Sotuyo Dodero
13f0c8000a [java] Don't report UseUtilityClass when extending 
- Since the parent class is not a utility, we are neither (the parent
class may have non-static methods and fields).
 - Since this is more general than the original check for exception
types, we remove that
 - Fixes #824
 - Take the chance to have the rule use the rulechain
 2018-05-12 02:06:42 -03:00
Juan Martín Sotuyo Dodero
9b3fcc2608 [java] Simplify LongInstantiation and IntegerInstantiation 
- Narrow down both rule's search space (therefore making better usage
of the rulechain and reducing number of checks performed)
 - Use type resolution to simplify the rules and avoid FPs when
declaring classes with the same names
 2018-05-12 01:37:59 -03:00
Juan Martín Sotuyo Dodero
a378299978 Use type resolution for AvoidThrowingRawExceptionTypes 
- Fixes the false negatives
 - Is actually 100X faster as we avoid all those `//ImportDeclaration`
 2018-05-12 01:06:38 -03:00
Juan Martín Sotuyo Dodero
43839bd772 Failing test case for AvoidThrowingRawExceptionTypes 2018-05-12 01:03:33 -03:00
Clément Fournier
329e092e00 Make ClassNamingConventions' utility class definition more precise 
Classes which have a superclass or implement an interface are not flagged
as utility classes anymore.
 2018-05-08 19:41:17 +02:00
Clément Fournier
a8bd283545 Fix lambda qname infix in enum constants 2018-05-08 01:31:08 +02:00
Juan Martín Sotuyo Dodero
bcb3f65edb Avoid NPE 2018-05-07 02:43:34 -03:00
Juan Martín Sotuyo Dodero
fb55ca703e Also keep lambdas in a single scope 2018-05-06 20:42:51 -03:00
Juan Martín Sotuyo Dodero
c8b34b0dec Simplify test 2018-05-06 20:42:51 -03:00