5478 Commits

Author SHA1 Message Date
Xavier Le Vourch
9172c26905 code cleanup: grammar and spelling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6797 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-24 18:48:10 +00:00
Romain Pelisse
1b2063cf94 Working on bug : https://sourceforge.net/tracker2/?func=detail&aid=2410201&group_id=56262&atid=479921
I reproduced the issue and trace the problem back to the symbol table (More exactly a method of the NameOccurences class). I also added a test to reproduced the issue here. (Also added a little javadoc).

I'm not really although how to "assert" results in this test, not really sure how the symbol table should be expected to behave here.

No more time right now for this, i'll try see through this week. 

Note: I'll patch trunk when I'll have fix for good this issue.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6759 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-21 15:36:56 +00:00
Xavier Le Vourch
8c64498325 Fixed bug - JUnitTestsShouldIncludeAssert now detects Junit 4 Assert.assert... constructs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6753 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-13 00:12:54 +00:00
Xavier Le Vourch
ffb1131fe0 deprecated JRE_LIB replaced with org.eclipse.jdt.launching.JRE_CONTAINER
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6752 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-11 18:50:48 +00:00
Xavier Le Vourch
3f719b9b0f oops, NPE in previous commit...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6751 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-11 07:25:27 +00:00
Xavier Le Vourch
aea7c89175 oops, NPE in previous commit...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6749 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-11 07:09:45 +00:00
Xavier Le Vourch
0fb697a50b Fixed bug 2404700 - UseSingleton should not act on enums
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6746 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-11 06:32:25 +00:00
Xavier Le Vourch
e300a2630b Fixed bug 1955852 - false positives for UnusedPrivateMethod & UnusedLocalVariable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6744 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-11 00:48:43 +00:00
Romain Pelisse
59646f99d2 Resync the credits.xml with trunk.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6739 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 15:10:14 +00:00
Romain Pelisse
743d2da79a Adding credit entry on Sergey Pariev for his fix on Ruby CPD.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6738 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 15:08:36 +00:00
Romain Pelisse
4e8664c244 Oups, last commit included test case for bug [ 1955852 ] false positives for UnusedPrivateMethod & UnusedLocalField. Setting them to non regression test.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6737 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 12:09:32 +00:00
Romain Pelisse
5948b700b3 Oups, last commit included test case for bug [ 1955852 ] false positives for UnusedPrivateMethod & UnusedLocalField. Setting them to non regression test.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6736 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 12:09:01 +00:00
Romain Pelisse
2a8cf167b9 Remove useless addons in the Eclipse 's .classpath file.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6735 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 11:11:46 +00:00
Romain Pelisse
d4aad400d5 Fix for bug [ 2315599 ] False +: UseSingleton with class containing constructor.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6733 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-02 09:02:44 +00:00
Romain Pelisse
f7f2532566 Oups, this forget to update changelog when I applied provided patch for :
[ 2338341 ] ArrayIndexOutOfBoundsException in cpd on rails project.




git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6731 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-01 21:05:21 +00:00
Xavier Le Vourch
8cdc5bd985 code cleanup: better XPath expression for ClassWithOnlyPrivateConstructorsShouldBeFinal
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6704 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-27 17:36:03 +00:00
Xavier Le Vourch
0252a9c905 Fixed bug 2230809 - False +: ClassWithOnlyPrivateConstructorsShouldBeFinal
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6703 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-27 17:06:30 +00:00
Xavier Le Vourch
8f8afde50b Fixed bug 2315623 - @SuppressWarnings("PMD.UseSingleton") has no effect
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6701 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-24 21:00:23 +00:00
Romain Pelisse
6836ae8bcd Committing small patch for CPD (Ruby). See https://sourceforge.net/tracker/index.php?func=detail&aid=2338341&group_id=56262&atid=479921 for more details. This small fix does not break unit test, but more testing will be nice.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6698 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-24 19:04:55 +00:00
Ryan Gustafson
51ca03348c Better exception handling.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6637 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-18 21:19:11 +00:00
Ryan Gustafson
41d0550d99 Enhanced logging in the ClassTypeResolver to provide more detailed messaging.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6632 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-18 05:09:43 +00:00
Xavier Le Vourch
06bb1a6f27 Java grammar fix: TypeParameter name wasn't set
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6629 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-17 17:24:37 +00:00
Xavier Le Vourch
fc173e08c8 preparing for next version 4.2.5-SNAPSHOT
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6598 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-13 18:20:59 +00:00
Xavier Le Vourch
14461efefd sourceforge access changes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6597 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-13 08:20:45 +00:00
Xavier Le Vourch
68c1d53a59 4.2.4 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6596 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-13 04:00:45 +00:00
Xavier Le Vourch
80a7ece0bc preparing for 4.2.4 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6594 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-13 03:36:18 +00:00
Xavier Le Vourch
10f5aa8d69 Fixed patch 2075906 - Add toString() to the rule UnnecessaryWrapperObjectCreation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6591 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-11 18:38:37 +00:00
Xavier Le Vourch
9893f33977 link to snapshot web site in 'Future releases' section
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6583 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-07 23:20:34 +00:00
Ryan Gustafson
2e0bffe7a3 Correct changelog comment.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6575 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-07 02:03:56 +00:00
Ryan Gustafson
718ef77283 Set exclude marker on parser to fix NPE.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6574 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-07 01:57:12 +00:00
Xavier Le Vourch
4ac13741ab cpd ant task documentation for attributes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6555 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-03 23:43:05 +00:00
Xavier Le Vourch
f3c1227dcc code cleanup: extra '[' in <![CDATA[ removed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6515 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-26 19:05:10 +00:00
Xavier Le Vourch
7cd887ba8c merge from trunk: Fixed ClassCastException in symbol table code
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6468 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-10 19:54:21 +00:00
Xavier Le Vourch
c07f274b4e merged from trunk: Fixed ClassCastException on generic method in BeanMembersShouldSerialize
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6466 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-10 18:34:41 +00:00
Xavier Le Vourch
037cf154f7 merge from trunk:
relative paths for custom rulesets are now handled properly when ant is called
from a different directory using the "-f" option.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6448 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-04 22:54:47 +00:00
Xavier Le Vourch
69ff09410a Fixed bug 1943204 - Ant task: <ruleset> path should be relative to Ant basedir
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6442 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-03 23:38:32 +00:00
Xavier Le Vourch
39e59dd02f merged from trunk: Fixed bug 1481051 - false + UnusedNullCheckInEquals (and other false positives too)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6440 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-03 20:22:39 +00:00
Xavier Le Vourch
7ed88ed4cf merge from trunk: Dr. Wedemann isn't working in this area anymore, so removing this
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6435 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-02 16:24:17 +00:00
Xavier Le Vourch
ef13f147ce javacc updated to official 4.1 version
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6434 51baf565-9d33-0410-a72c-fc3788e3496d
2008-09-02 16:18:24 +00:00
Xavier Le Vourch
e0dbf498e2 version updated to 4.2.4-SNAPSHOT
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6430 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 21:32:19 +00:00
Xavier Le Vourch
c777f4d548 old obsolete info removed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6429 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 21:11:45 +00:00
Xavier Le Vourch
b3d2a856a8 changes for 4.2.3 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6428 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 20:30:45 +00:00
Xavier Le Vourch
59a61fb58c 4.2.3 description on web site
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6427 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 20:05:06 +00:00
Xavier Le Vourch
7e018ac3bd extra quote removed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6426 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 19:51:21 +00:00
Xavier Le Vourch
d4e6c1872d preparing 4.2.3 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6424 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-31 19:26:42 +00:00
Xavier Le Vourch
767cea113d merge from trunk:
Fixed handling of escape characters in UseIndexOfChar and AppendCharacterWithChar


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6422 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 20:27:04 +00:00
Xavier Le Vourch
5f2d71cdde Fixed bug 1556594 - Wonky detection of NullAssignment
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6418 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 01:56:07 +00:00
Xavier Le Vourch
263b91d556 Fixed bug 2050064 - False + SuspiciousOctalEscape with backslash literal
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6415 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 01:04:34 +00:00
Xavier Le Vourch
94cfdb93fd Fixed bug 1977438 - False positive for UselessStringValueOf
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6414 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-28 00:16:23 +00:00
Xavier Le Vourch
91ad44ba0a Fixed false negative in UselessOverridingMethod
using < 0 instead of > 0 in getting argument list size. Maybe we should have a rule to detect this...


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6408 51baf565-9d33-0410-a72c-fc3788e3496d
2008-08-26 19:19:14 +00:00