5064 Commits

Author SHA1 Message Date
Xavier Le Vourch
98e34e3484 all pmd-eclipse subproejcts moved to pmd-eclipse-plugin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5606 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-31 21:39:15 +00:00
Xavier Le Vourch
578e1fd822 bug fix: log level label wasn't refreshed when pressing "Restore Defaults"
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5605 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-31 21:13:33 +00:00
Xavier Le Vourch
df287f9dd5 Bug fix [ 1811828 ] RuntimeException in RuleSetFactory
At least the second part from the comments about the
ArrayIndexOutOfBoundsException is fixed by this change


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5604 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-30 04:02:49 +00:00
Xavier Le Vourch
eda9223e3c Eclipse plugin 3.2.2 changes imported from old cvs repository to amke it current
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5603 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-30 01:45:33 +00:00
Xavier Le Vourch
f3342c9052 obsolete junit report dir deleted when starting new test
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5602 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-29 21:38:32 +00:00
Xavier Le Vourch
218b023458 output directory can be set for yahtml report
-> junit testing doesn't "pollute" parent directory


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5601 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-29 21:35:58 +00:00
Xavier Le Vourch
607f5d6dcd default for outputTestResultsToFile property set to 'true' -> junit text summary displayed by default
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5600 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-29 16:45:47 +00:00
Xavier Le Vourch
5adbdcb4dc changes for jdk 1.4 support (weaved classes now behave exactly the same way as
regular classes, i.e. same number of failures):

testDtd() needs the full path for the SYSTEM ruleset.dtd even if that's not
the one used by the validator.

isJdk14 boolean set in setUp() method and used in testXmlSchema() to ignore
test as Xerces is not present.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5599 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-28 18:21:41 +00:00
Xavier Le Vourch
e2f9edae98 "Bug fix": list of method calls are sorted to provide repeatable results on
different runs. Not really a bug but useful for regression testing.

The previous code relied on the default hashCode() to provide the HashMap keys
so the order was based on memory location and thus not repeatable.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5598 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-28 17:18:46 +00:00
Xavier Le Vourch
13a5d5dad0 total test count added to junit summary
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5597 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-27 19:46:51 +00:00
Xavier Le Vourch
ef24358495 Bug fix: state info in BooleanInstantiation rule needs to be reset for each file
(stress test on jdk src wasn't giving consistent results depending on which thread
was processing files as each thread has a different set of Rule objects)


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5596 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-27 17:54:00 +00:00
Xavier Le Vourch
d7972f80d1 AvoidUsingHardCodedIP now checks for IPv6 addresses as well
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5595 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-27 17:44:43 +00:00
Xavier Le Vourch
68b3ffb069 synchronization was incorrect
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5594 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 17:22:20 +00:00
Xavier Le Vourch
3f1302fc93 code cleanup: xpath rule simplification
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5593 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 17:14:41 +00:00
Xavier Le Vourch
eef9e5ee35 code cleanup: xpath rule simplification
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5592 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 17:06:22 +00:00
Xavier Le Vourch
b4f4e3c098 code cleanup: xpath rule simplification
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5591 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 16:57:31 +00:00
Romain Pelisse
4691599f0b Removing useles restriction in test classes.
mvn test is 'almost' working... There is still a couple of tests that fails very strangely ( and they are not failing with the bin/build.xml).


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5590 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 09:48:18 +00:00
Tom Copeland
701095c41b tweak
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5589 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-26 02:08:30 +00:00
Xavier Le Vourch
05d5663109 cleanup: consistent use of tabs instead of spaces
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5588 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 23:15:59 +00:00
Xavier Le Vourch
1ae3bcd1fc Junit changes:
testAll() xml test case now tests all possible test cases even if one fails

custom JUnit runner is used to send several failures to the notifier

build.xml:
common parameterized tasks are used to run tests and reports for "test" and "test14"

if "outputTestResultsToFile" property is set, a text summary is also generated after testing
  (xsl transformation is using etc/xslt/junit-txt-output.xsl)


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5587 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 23:08:30 +00:00
Xavier Le Vourch
b4e8751acb no need to redefine testAll() and ignore it if no rule is inserted in setup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5586 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 22:53:06 +00:00
Wouter Zelle
dee7967d2a 1503099, fixed false positive for
new StringBuffer(str1.length() + str2.length());

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5585 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 14:56:24 +00:00
Tom Copeland
3fe03f18d7 git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5584 51baf565-9d33-0410-a72c-fc3788e3496d 2007-10-25 13:31:43 +00:00
Tom Copeland
5541a0397c Minor refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5583 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 13:31:36 +00:00
Wouter Zelle
54c9b32615 cleanups
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5582 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 11:11:44 +00:00
Wouter Zelle
0ac96b5f3b generics
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5581 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 11:06:06 +00:00
Xavier Le Vourch
4e1d5e3024 java 1.5 is the default
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5580 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 02:01:23 +00:00
Xavier Le Vourch
e28103ddfa more restrictive regexp in AvoidUsingHardCodedIP to limit false positives
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5579 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-25 01:12:51 +00:00
Xavier Le Vourch
d83c4ec977 Parser changes:
Java parser can now detect invalid usage of annotation in jdk 1.4
  -> ASTAnnotationTest test cases are not ignored any longer.

new DEFAULT_JDK_VERSION constant in TargetJDKVersion to get consistent
default parser version


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5578 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 23:32:25 +00:00
Xavier Le Vourch
410d902956 rule name added to assert message
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5577 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 20:11:15 +00:00
Xavier Le Vourch
2753e751c3 Jaxen exception test case moved to SimplifyStartsWith as AddEmptyString doesn't use string-length expression any longer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5576 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 19:59:23 +00:00
Xavier Le Vourch
ee020670b6 junit assert failures should not be converted into errors
AssertionError was caught by Throwable and rethrown as RuntimeException


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5575 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 18:19:19 +00:00
Xavier Le Vourch
5ba3fbbf6c javadoc comments added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5574 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 18:11:20 +00:00
Xavier Le Vourch
d752f1e9d1 test case description changed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5573 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 15:41:43 +00:00
Xavier Le Vourch
1812d7df6d Jaxen updated to 1.1.1, now Literal[@Image=''] works in XPath expressions.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5572 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 15:39:48 +00:00
Xavier Le Vourch
f8c66568a2 Fixed bug 1811506 - False - : UnusedFormalParameter (property checkall needs to be set)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5571 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 15:36:26 +00:00
Tom Copeland
871bd0a62b Fixed IDEAJ renderer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5570 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 14:11:09 +00:00
Wouter Zelle
bd86a63706 Added rulesets/design.xml/SingularField
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5569 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 08:32:26 +00:00
Xavier Le Vourch
e2f2a702a7 code refactoring: testAll() moved to parent, rules are now added in setUp() using addRule().
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5568 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 04:42:51 +00:00
Xavier Le Vourch
06ad62b318 retroweaver changes for junit tests
report outputs are generated in build/reports and build/reports14


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5567 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 02:58:38 +00:00
Xavier Le Vourch
b8565167ca FortranTokenizerTest and RubyTokenizerTest were not inserted correctly in test suite
incorrect token count in RubyTokenizerTest


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5566 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-24 00:11:56 +00:00
Xavier Le Vourch
a1f1135041 xml syntax errors fixed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5565 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-23 17:46:09 +00:00
Wouter Zelle
0acce874a8 Added properties documentation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5564 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-22 07:26:19 +00:00
Xavier Le Vourch
999e34e849 code cleanup: unused imports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5563 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 19:21:30 +00:00
Wouter Zelle
86df2dc3dd added SingularField
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5562 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 11:53:41 +00:00
Wouter Zelle
0097f87ccc Fixed false positive when the first usage is an assignment to a field of the field (x.y = 5 instead of x = 5)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5561 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 11:53:28 +00:00
Romain Pelisse
279ce698fa Adding some code changes by Pierre Mathieu to detect more cases of badly closed resources.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5560 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 09:12:59 +00:00
Romain Pelisse
2091b36be3 Adding new test case to validate a new features in CloseResourceRule
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5559 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 09:10:14 +00:00
Wouter Zelle
f0600f7922 SingularField violations fixed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5558 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 08:03:45 +00:00
Wouter Zelle
d23b3b3260 SingularField violations fixed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5557 51baf565-9d33-0410-a72c-fc3788e3496d
2007-10-19 08:03:30 +00:00