hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity
5,526 Commits 16 Branches 123 Tags 510 MiB
Commit Graph

5526 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Romain Pelisse
a73b7f1fb1 Fix bug 2832322 - cpd.xml file tag path attribute should be entity-encoded. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6988 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-16 13:18:39 +00:00
Romain Pelisse
64d3bc28cb Oups, this stateless crap of mine from my previous commit was erronous. 
Rule are NOT recreated for each new source file, we need to clean the state of this object... Therefore I add this piece of code back.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6986 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-16 01:25:30 +00:00
Romain Pelisse
8b4ade3016 While debugging I realise that PMD rules are 'stateless', so I remove my code to clean the ArrayList at each passage. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6985 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-15 18:05:52 +00:00
Romain Pelisse
60c0bcb858 finally fixing bug 'wz-pmd-report.xslt in release 4.2.5 misses file name - ID: 2609540' 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6980 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-15 17:20:10 +00:00
Romain Pelisse
0b60a2d6ff making field private and adding missing @Override 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6979 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-15 17:19:47 +00:00
Romain Pelisse
73ebf2603a Fixing bug 2826119 - False +: DoubleCheckedLocking warning with volatile field 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6978 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-15 16:40:53 +00:00
Romain Pelisse
6f427f9fa5 Fixing bug : False -: DoubleCheckedLocking with reversed null check - ID: 2835074 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6976 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-08-15 15:58:49 +00:00
Ryan Gustafson
d6b326838f Added AvoidLosingExceptionInformation from George Thomas. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6972 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-07-21 01:43:49 +00:00
Romain Pelisse
0e3a92c291 Adding link to my own article, in French, on PMD 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6968 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-06-30 12:33:10 +00:00
Romain Pelisse
bbc1d2a02f Fixing bug 2810228 : updating cpd documentation. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6965 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-06-22 14:25:55 +00:00
Xavier Le Vourch
0e1bf46e07 new Android rule DoNotHardCodeSDCard taken from my blog article on how to use PMD in Android projects 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6960 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-06-13 20:34:03 +00:00
Xavier Le Vourch
6243e25400 asm jars updated to 3.2 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6954 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-06-13 00:13:38 +00:00
Ryan Gustafson
ae499b9132 Fixed bug 2724653 - AvoidThreadGroup reports false positives 
Changed Rule to use Type Resolution.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6918 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-04-24 02:51:55 +00:00
Ryan Gustafson
c168ecc6e5 Correct -benchmark reporting of Rule visits via the RuleChain 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6912 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-04-18 08:21:27 +00:00
Xavier Le Vourch
ac439685fc Android ruleset: CallSuperLast rule now also checks for finish() redefinitions 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6891 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-03-22 23:06:42 +00:00
Xavier Le Vourch
2321376151 new rule AvoidLiteralsInIfCondition added to controversial ruleset 
Patch contributed by Nadhamuni Kothapalle

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591627&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6888 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-03-22 22:50:57 +00:00
Ryan Gustafson
f7cefa4a7d Fixed bug 2645268 - ClassCastException in UselessOperationOnImmutable.getDeclaration 
Problem was due to incorrect assumption about AST structure, when Annotations are present on a local declaration.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6879 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-03-01 09:57:16 +00:00
Xavier Le Vourch
eeb8b10892 Fixed bug 2606609 - False "UnusedImports" positive in package-info.java 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6874 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-23 17:45:51 +00:00
Romain Pelisse
2577acd87e Cleanup: Moving testcase for bug '1843273 : False - on SimplifyBooleanReturns' to the appropriate file. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6858 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-19 23:40:14 +00:00
Romain Pelisse
e3ad18317a Adding fix for bug [2317099] False + in SimplifyConditional to changelog 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6856 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-19 22:24:12 +00:00
Romain Pelisse
6bc10af45e Test case and fix for bug [2317099 ] false + in SimplifyConditional. 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6855 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-19 22:23:19 +00:00
Romain Pelisse
5a1a457eae Reproducing bug False 2606609: 'UnusedImports' positive in package-info.java 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6849 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-16 23:54:51 +00:00
Romain Pelisse
59a60be0d2 Adding Bug fix 2590258 - NPE with nicerhtml output to changelog.txt 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6848 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-16 12:17:34 +00:00
Romain Pelisse
f7aa88db54 Bug Fix: NPE in XsltRenderer 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6847 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-16 12:17:11 +00:00
Xavier Le Vourch
eb371c24a1 wrong since attribute 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6843 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-12 19:30:51 +00:00
Xavier Le Vourch
a846ccb014 New rule in strictexceptions : AvoidCatchingGenericException 
patch submitted by Nadhamuni Kothapalle

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591604&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6842 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-12 19:28:38 +00:00
Xavier Le Vourch
a31f7f3578 next dev cycle: 4.2.6-SNAPSHOT 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6838 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 02:37:38 +00:00
Xavier Le Vourch
ecb51fbac5 upload of maven files to sourceforge was not correctly done 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6837 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 02:29:08 +00:00
Xavier Le Vourch
3ab42655dc web site updates for 4.2.5 changes 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6836 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 01:54:53 +00:00
Xavier Le Vourch
c44b0c2c87 android ruleset was not in changelog 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6832 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 01:18:15 +00:00
Xavier Le Vourch
2817991f7d preparing 4.2.5 release 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6830 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 00:52:32 +00:00
Xavier Le Vourch
ce0fd33919 local.properties ignored 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6829 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 00:46:29 +00:00
Xavier Le Vourch
316ef30f5b note for Fixed bug 2027626 - False + : AvoidFinalLocalVariable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6828 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-09 00:43:32 +00:00
Romain Pelisse
7a7381829a Final fix 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6824 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-08 21:57:20 +00:00
Romain Pelisse
9e0de88bc2 Adding testcase to reproduce bug 2027626 : 'False + : AvoidFinalLocalVariable' 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6823 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-08 21:56:58 +00:00
Xavier Le Vourch
13f6224635 2009 added to copyright 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6821 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-08 21:30:56 +00:00
Xavier Le Vourch
a4e7012c63 dogfood location must be on branch or the pmd plugin complain about internal/pmdspecific.xml from the trunk 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6820 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-08 21:29:41 +00:00
Xavier Le Vourch
de924b50cf Fixed bug 2142986 - UselessOverridingMethod doesn't consider annotations 
new property 'ignoreAnnotations' to get the old behavior


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6818 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-08 19:19:33 +00:00
Romain Pelisse
605de6f7bf Bug fixing 1609038 - Xslt report generators break if path contains 'java'. 
As suggested by bug reporter i switch call to 'translate' and call to 'substring-before'.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6816 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-05 10:57:28 +00:00
Xavier Le Vourch
751ed84e0d new rule in strictexception: AvoidThrowingNewInstanceOfSameException 
contributed by George Thomas:

https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2566369&group_id=56262


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6814 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-05 03:29:15 +00:00
Xavier Le Vourch
b5a90924a7 CallSuperFirst android rule now accepts logging before call to super() 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6812 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-02-04 23:50:51 +00:00
Romain Pelisse
ca664ea719 Adding test case for bug '[2115761] False +: System.arraycopy is more efficient' 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6811 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-31 21:39:39 +00:00
Romain Pelisse
d740f68a94 Test case to reproduce [1732744] False + : basic/UselessOperationOnImmutable 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6810 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-29 13:48:18 +00:00
Romain Pelisse
d20f8f2291 Test case to reproduce [1622281 ] Loop scoping dodgy 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6809 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-29 13:21:34 +00:00
Romain Pelisse
72cc961ca8 Fix for bug 2225474 - VariableNamingConventions does not work with nonprimitives 
- Adding a test case to reproduce the issue ;
- Fix ;
- Changelog updated.
Special thanks to Markus Kling for pointing this fix to me.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6807 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-28 20:51:58 +00:00
Xavier Le Vourch
e26de08062 new ruleset for Android platform 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6803 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-27 23:52:27 +00:00
Xavier Le Vourch
9b4b50560d Recent change in UseSingleton introduced a false + for methods with annotations 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6802 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-27 23:43:03 +00:00
Xavier Le Vourch
240e548c36 new script to build snapshot: etc/generate_snapshot.sh 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6800 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-27 20:24:02 +00:00
Xavier Le Vourch
9172c26905 code cleanup: grammar and spelling 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6797 51baf565-9d33-0410-a72c-fc3788e3496d
 2009-01-24 18:48:10 +00:00
Romain Pelisse
1b2063cf94 Working on bug : https://sourceforge.net/tracker2/?func=detail&aid=2410201&group_id=56262&atid=479921 
I reproduced the issue and trace the problem back to the symbol table (More exactly a method of the NameOccurences class). I also added a test to reproduced the issue here. (Also added a little javadoc).

I'm not really although how to "assert" results in this test, not really sure how the symbol table should be expected to behave here.

No more time right now for this, i'll try see through this week. 

Note: I'll patch trunk when I'll have fix for good this issue.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6759 51baf565-9d33-0410-a72c-fc3788e3496d
 2008-12-21 15:36:56 +00:00