Commit Graph

2228 Commits

Author SHA1 Message Date
Juan Martín Sotuyo Dodero
db2348baec Merge branch 'pr-1637' 2019-02-02 13:58:39 -03:00
Juan Martín Sotuyo Dodero
422f44cf1a Add todo for follow up improvements 2019-02-02 13:56:29 -03:00
Shubham
1e1d6aafae code review changes 2019-02-02 20:38:23 +05:30
Phokham Nonava
f0830eb973 Update instead of override classHasLombokAnnotation flag
Fixes issues where inner classes would override this flag.
2019-02-01 22:59:04 +01:00
Shubham
23ce8435e4 all compile time constants are avoided by AccessorMethodGenerationRule 2019-02-01 19:36:51 +05:30
Shubham
7a5ed78a73 constants initialized by literals avoided by AccessorMethodGenerationRule
Compile time constants with literals only expression avoiding AccessorMethodGenerationRule.
2019-01-31 15:40:22 +05:30
Juan Martín Sotuyo Dodero
e2a4b744fd Merge branch 'pr-1634' 2019-01-30 12:27:17 -03:00
Shubham
0547897934 Reviewed code updated 2019-01-30 19:43:09 +05:30
Shubham
cb0c70f1ac Review changes implemented 2019-01-30 18:58:47 +05:30
Shubham
d1c75ccff4 Unused Formatter need not be checked for synchronization. 2019-01-30 14:57:39 +05:30
Shubham
149f85a7e4 #1633 [java] UnsynchronizedStaticFormatter reports commons lang FastDateFormat
Thread safe formatter org.apache.commons.lang3.time.FastDateFormat can not avoid UnsynchronizedStaticFormatterRule.
2019-01-30 14:02:17 +05:30
Shubham
9532552eaa BeanMembersShouldSerializeRule aware of lombok accessors
Extended AbstractLombokAwareRule to make BeanMembersShouldSerializeRule aware of lombok annotations. Checking if class or any of the variables have lombok annotations and avoid BeanMembersShouldSerializeRule on these variables.
2019-01-30 11:09:44 +05:30
Juan Martín Sotuyo Dodero
8a7913a30d Merge branch 'pr-1628' 2019-01-29 00:04:40 -03:00
Juan Martín Sotuyo Dodero
add4a78b57 Merge branch 'pr-1625' 2019-01-29 00:00:11 -03:00
Juan Martín Sotuyo Dodero
081ee17349 Simplify test 2019-01-28 23:59:19 -03:00
Shubham
6f2cd5fe29 Test cases added
Updated testcases.
2019-01-28 23:02:59 +05:30
Shubham
746dc4e602 Code review changes
All overridden methods are ignored now.
2019-01-28 20:51:06 +05:30
Shubham
1b9e63b4f4 #1543 [java] LinguisticNaming should ignore overriden methods
Overriden methods are ignored from LinguisticNamingRule.
2019-01-28 16:50:51 +05:30
Shubham
189bb46ea1 UnusedImports false positive for method parameter type in @see Javadoc
Updated SEE_PATTERN regex pattern.
2019-01-28 14:39:08 +05:30
Bobby Wertman
ea022f0e68 [java] Fix lombok.AllArgsConstructor support 2019-01-27 10:55:45 -05:00
Andreas Dangel
63cd6d0f5c [maven-release-plugin] prepare for next development iteration 2019-01-27 13:25:00 +01:00
Andreas Dangel
ea2776f70c [maven-release-plugin] prepare release pmd_releases/6.11.0 2019-01-27 13:24:51 +01:00
Andreas Dangel
8609aa314f Merge branch 'pr-1558' 2019-01-26 18:45:06 +01:00
Andreas Dangel
b521126130 Merge branch 'pr-1550' 2019-01-14 18:50:17 +01:00
Juan Martín Sotuyo Dodero
f218518089 Merge pull request #1535 from adangel/unsynchronizedstaticformatter
[java] New rule: UnsynchronizedStaticFormatter
2019-01-13 00:44:41 -03:00
Andreas Dangel
5f34190851 [java] Private field is detected as public inside nested classes in interfaces
Fixes #1578
2019-01-11 17:14:47 +01:00
Juan Martín Sotuyo Dodero
c8c5708b70 Merge branch 'master' into unsynchronizedstaticformatter 2019-01-10 17:27:55 -03:00
Andreas Dangel
38cff531c4 Add missing constructor call 2019-01-10 20:59:39 +01:00
Juan Martín Sotuyo Dodero
4354baacaf Merge branch 'pr-1551' 2019-01-08 20:43:28 -03:00
Andreas Dangel
11d949436e [doc] Add note which rules replace the deprecated rule. 2019-01-07 21:02:12 +01:00
Clément Fournier
fe96101055 Handle null provider 2019-01-06 17:25:48 +01:00
Clément Fournier
5f2a5bb678 Implement for Java 2019-01-06 03:08:45 +01:00
Clément Fournier
dc7e023644 Default methods are not abstract 2019-01-05 22:57:58 +01:00
Robbie Martinus
a26aaac415 Moved logger message pattern to a field
Fixes gh-1549
2019-01-03 05:58:59 +11:00
Robbie Martinus
d35e7398ba Moved logger to a field
Fixes gh-1549
2019-01-02 21:14:37 +11:00
Robbie Martinus
98b23d5420 InvalidSlf4jMessageFormatRule should not throw NPE for enums
Fixes gh-1549
2019-01-02 18:27:51 +11:00
Clément Fournier
ad078fad59 Deprecate StatisticalRule 2018-12-30 16:34:57 +01:00
Andreas Dangel
0cb627a67b Adjust priority of new rule UseDiamondOperator 2018-12-27 10:39:24 +01:00
Andreas Dangel
a81403c842 Merge branch 'pr-1534' 2018-12-27 10:30:24 +01:00
Andreas Dangel
db25def6b0 Update release notes, refs #1534, fixes #1517 2018-12-27 10:29:28 +01:00
hemanshu070
e00b0b83fa This commit is regarding the addition of the example tag to codestyle.xml and addition of the licence in the test class "UseDiamondOperator.java" 2018-12-24 18:50:17 +05:30
hemanshu070
5b6ac1b2fb This commit is regarding the addition of the since and the externalInfo URL and update the message to be more descriptive. 2018-12-23 20:04:43 +05:30
Andreas Dangel
61a82c369d Merge branch 'pr-1530' 2018-12-22 23:27:18 +01:00
Andreas Dangel
2021dfe247 Fix externalInfoUrl for ForLoopVariableCount 2018-12-22 23:14:31 +01:00
Andreas Dangel
b210618f79 Merge branch 'pr-1520' 2018-12-22 23:09:45 +01:00
Andreas Dangel
f35fab2774 Move new rule ForLoopVariableCount to bestpractices 2018-12-22 23:03:18 +01:00
hemanshu070
8810e58a31 This is the change regarding the usediamondoperator #1517 2018-12-20 23:13:52 +05:30
Andreas Dangel
df64fd4d72 [java] New Rule UnsynchronizedStaticFormatterRule
This rule replaces UnsynchronizedStaticDateFormatterRule
2018-12-20 18:27:45 +01:00
Andreas Dangel
38be3d09a4 [java] UnsynchronizedStaticDateFormatterRule
* Use typeresolution
* Use rule chain
2018-12-20 18:09:56 +01:00
Kristian Scheibe
cbebef552a AvoidReassigningLoopVariables: fixes and additional test cases for: FN when changing the condition/expression of a flow control statement, FP when accessing arrays using the loop variable or if the loop variable is an array being accessed 2018-12-20 14:31:39 +01:00