3613 Commits

Author SHA1 Message Date
Radim Kubacki
dd5514a1f7 release 1.3 preparation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3881 51baf565-9d33-0410-a72c-fc3788e3496d
2005-10-02 19:56:50 +00:00
Tom Copeland
9e481330c7 A big refactoring so that RuleViolation has a reference to the AST Node object that's responsible for the RuleViolation; this simplifies some of the code and gets us closer to being able to suppress PMD warnings using annotations. It's possible that this may break some custom rules that are written in Java, but it should be only a small code change to the way the rule add RuleViolations to the Report to fix these breakages.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3880 51baf565-9d33-0410-a72c-fc3788e3496d
2005-10-01 00:47:55 +00:00
Tom Copeland
230106c18b Removing more Modifier nodes from the AST; this should work better with Annotations now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3879 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-30 03:27:16 +00:00
Tom Copeland
abe181465a Modified to use default LineMark for PMD warnings
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3878 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-30 01:57:48 +00:00
Tom Copeland
cfa917c96f Fixed bug 1306180 - AvoidConcatenatingNonLiteralsInStringBuffer no longer reports false positives on certain StringBuffer usages.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3877 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-29 13:14:28 +00:00
Tom Copeland
8229be508a rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3875 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 20:12:53 +00:00
Tom Copeland
46c3790418 More old file cleanups
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3874 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 20:08:05 +00:00
Tom Copeland
bf1a4efd43 Removing duplicated images
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3873 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 20:05:58 +00:00
Tom Copeland
da658c597d Added release announcement notes; thx to Lori Olson for the tip
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3872 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 19:08:40 +00:00
Tom Copeland
08f2335854 Added 'check all open files' to Tools menu options
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3871 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 17:52:53 +00:00
Tom Copeland
565c6235f2 moved check open files from package to project node
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3870 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 16:57:58 +00:00
Tom Copeland
1da02e6418 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3869 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 13:12:41 +00:00
Tom Copeland
a032e0069f rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3868 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 12:58:38 +00:00
Tom Copeland
4c874fe171 Implemented RFE 714950 - Now there's an option to check all the open files in a project.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3867 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-28 12:53:21 +00:00
Tom Copeland
8a8659432c Updating to use 3.3
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3866 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-27 19:52:17 +00:00
Tom Copeland
81338b565c A little more refactoring on DFA
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3865 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-26 23:49:25 +00:00
Tom Copeland
fc49a7b543 Fixed bug 1304739 - StringInstantiation no longer crashes on certain String constructor usages.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3864 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-26 21:38:40 +00:00
Tom Copeland
edd1d893d4 Moving more code out of DAAPathFinder; now need to make those attributes private and migrate over some methods
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3863 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-24 00:30:33 +00:00
Tom Copeland
d5883cd331 More refactoring; inlining some methods, preparing to do a wrapper class for DefaultMutableTreeNode
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3862 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-24 00:20:14 +00:00
Tom Copeland
f48a87851f Refactoring a bit; DAAPathFinder is a bit easier to read now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3861 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-24 00:05:41 +00:00
Tom Copeland
67bc087812 Moving some of the methods into a class... trying to break this down a bit
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3860 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-23 23:56:09 +00:00
Tom Copeland
3cc106aad8 Adding Wouter Zelle's NonThreadSafeSingleton rule, thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3859 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-21 21:18:17 +00:00
Tom Copeland
9ae510f0ea Added Wouter Zelle's DefaultPackage rule, thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3858 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-20 20:28:21 +00:00
Tom Copeland
79a0e71c52 Added JDK 1.3/1.4/1.5 version menu, removed extraneous whitespace ant whatnot
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3857 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-20 20:16:58 +00:00
Tom Copeland
94a81c5492 Added cover image
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3856 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-20 17:17:54 +00:00
Tom Copeland
0bbb350130 Fixed bug 1296544 - TooManyFields no longer checks the wrong property value.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3855 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-20 16:17:54 +00:00
Tom Copeland
c872939bfd Fixed bug 1291353 - ASTMethodDeclaration isPublic/isAbstract methods are always return true. The syntactical modifier - i.e., whether or not 'public' was used in the source code in the method declaration - is available via 'isSyntacticallyPublic' and 'isSyntacticallyAbstract'
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3854 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-20 00:27:43 +00:00
Tom Copeland
451b04524f Fixed bug 1293277 - Messages that used 'pluginname' had duplicated messages.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3853 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 21:38:15 +00:00
Tom Copeland
67e06088ca Fixed bug 1293157 - UnusedPrivateMethod no longer reports false positives for private methods which are only invoked from static initializers.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3852 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 18:59:24 +00:00
Tom Copeland
1a55076414 UselessAssignment was reporting bug on wrong line
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3851 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 18:24:26 +00:00
Tom Copeland
a774b7119f Fixed bug 1292689 - Description wrong for UnnecessaryLocalBeforeReturn
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3850 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 14:53:12 +00:00
Tom Copeland
ee29940b5a Fixed bug 1292609 - The JDK 1.3 parser now correctly handles certain 'assert' usages. Also added a 'JDK 1.3' menu item to the Designer.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3849 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 14:47:02 +00:00
Tom Copeland
19c54df991 Fixed bug 1292745 - Removed unused source file ExceptionTypeChecking.java
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3848 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-16 13:34:37 +00:00
Tom Copeland
47ef76ba02 tweaks here and there
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3846 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-15 22:38:26 +00:00
Tom Copeland
a03e1d5f08 Rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3845 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-15 21:31:48 +00:00
Tom Copeland
9dca8b5a40 Upgraded to Jaxen 1.1beta7
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3844 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-15 14:34:24 +00:00
Tom Copeland
d79e2298af Checking in Wouter Zelle's conversion of UselessOverridingMethod from XPath to Java, thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3843 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-15 14:00:24 +00:00
Tom Copeland
561743ad2b Some cleanups of UselessAssignment; still many problems, though. This rule should probably be pulled from the production rulesets for the 3.3 release...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3842 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-14 13:42:46 +00:00
Tom Copeland
49196668f0 More cases for UnnecessaryCaseChange
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3841 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-14 10:25:52 +00:00
Tom Copeland
0cfbefc171 Fixed bug 1290718 - Command line parameter documentation is now correct for targetjdk options.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3840 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-14 09:19:15 +00:00
Tom Copeland
19724396b5 Restructuring a bit; trying to find a nicer way to write this rule
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3839 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-13 13:53:24 +00:00
Tom Copeland
97a297f041 Minor cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3838 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-12 12:59:53 +00:00
Tom Copeland
8117ae92b9 Fixed unit tests
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3837 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-10 16:41:42 +00:00
Tom Copeland
452799f7bb Lazily loading attribute values now; this reduces Method.invoke() calls by about an order of magnitude. Total time savings for a 'basic' ruleset run is now about 8-10 percent.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3836 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-10 16:33:29 +00:00
Tom Copeland
44ce21d7bc Another microoptimization... ordering the type checks based on frequency
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3835 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-09 21:04:25 +00:00
Tom Copeland
d3ce406402 More preprocessing of the Method objects; speedup is still at about 5%
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3834 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-09 00:20:16 +00:00
Tom Copeland
550bc4c8be tweak
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3833 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-08 23:57:52 +00:00
Tom Copeland
7863dc6c78 Preprocessing methods to select out the attribute methods, about 5% faster overall processing now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3832 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-08 23:37:30 +00:00
Tom Copeland
991b4757cf Optimizing Jaxen integration; caching the node methods knocks about half a second off a 'basic' ruleset run on the java/lang/ source code
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3831 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-08 21:51:11 +00:00
Tom Copeland
4d4eb1fbf9 Update to rule creation docs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3830 51baf565-9d33-0410-a72c-fc3788e3496d
2005-09-07 15:31:16 +00:00