2817 Commits

Author SHA1 Message Date
Philippe Herlin
f96c317f94 Smooth the violation view icons
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3040 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-21 21:43:48 +00:00
Philippe Herlin
c0e3faf5b4 Keep tracks of those who have contributed to the plugin.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3039 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-21 21:42:35 +00:00
Philippe Herlin
990150d236 Applying Command and CommandProcessor patterns
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3038 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-21 21:39:45 +00:00
Philippe Herlin
b1f6e9ae94 Continue applying MVC.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3037 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-21 21:38:43 +00:00
Philippe Herlin
9cbecabc35 Refactoring to apply MVC.
The goal is to test the refactoring before a complete refactoring for all GUI


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3036 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-18 23:54:27 +00:00
Tom Copeland
c06e85fa56 Added an ELLIPSIS token
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3035 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-10 21:34:16 +00:00
Tom Copeland
c5f791eb09 Implemented new JDK 1.5 for loop syntax in the grammar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3034 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-10 17:34:37 +00:00
Tom Copeland
21ce3b2f93 Added support for JDK 5 varargs to grammar
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3033 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-08 20:59:04 +00:00
Tom Copeland
872d6cfb48 Optimized CloseConnection a bit - now we bail out even earlier if no java.sql imports exist
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3032 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-04 20:39:22 +00:00
Tom Copeland
5cacf77535 Fixed a typo in the Ant task docs, thanks to Lars Gregori for the report!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3031 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-04 14:51:29 +00:00
Tom Copeland
99661ba88c Fixed a possible NPE, thanks to Olaf Heimburger for the report
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3030 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-03 17:16:58 +00:00
Tom Copeland
ba3f2a8555 Made some stabs at making annotations worked, but backed them out because they were taking too long to get right. I'll leave the unit test in here for future reference, though
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3029 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-03 17:03:29 +00:00
Tom Copeland
26ac8f4989 Test gardening
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3028 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 21:06:58 +00:00
Tom Copeland
91266485eb Continued working on JDK 1.5 compatibility - added support for static import statements.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3027 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 21:02:11 +00:00
Tom Copeland
e3604d3017 A handy text snippet
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3026 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 20:45:54 +00:00
Tom Copeland
04aa57f340 Refactored away some more duplicate code. This class has now gone from 410 lines to 320 lines, while increasing functionality. All good.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3025 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 20:28:54 +00:00
Tom Copeland
7df5bc69b3 Refactored away some duplicate code
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3024 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 19:41:45 +00:00
Tom Copeland
1ab1817b47 Added 'override in ref rules' patch from Ryan Gustafson, thanks Ryan!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3023 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-02 19:17:20 +00:00
Tom Copeland
5115a64bf6 Implemented RFE 1058042 - XML output is more readable now.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3022 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-01 21:04:48 +00:00
Tom Copeland
208228f2e7 Implemented RFE 1058033 - Renamed run.[sh|bat] to pmd.[sh|bat]. Also cleaned up import stmts.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3021 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-01 20:54:09 +00:00
Tom Copeland
b545151f5c Thanks to Eric Olander for the DFAPanel cleanup!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3020 51baf565-9d33-0410-a72c-fc3788e3496d
2004-11-01 20:01:58 +00:00
Tom Copeland
084a35f018 Fixed for Win32... should really write more tests for this for other encoding... but how?
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3019 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-30 14:41:57 +00:00
Tom Copeland
28f92c8472 Fixed for Win32... should really write more tests for this for other encoding... but how?
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3018 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-30 00:37:13 +00:00
Tom Copeland
08f4239575 Fixed a problem with multi-char EOLS - i.e. Win32 CRLF
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3017 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-29 21:29:28 +00:00
Tom Copeland
d11f0a1f17 Fixed bug 1055930 - CouplingBetweenObjectsRule no longer throws a NPE on interfaces
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3016 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-28 19:31:13 +00:00
Tom Copeland
6305fce56f Fixed bug 1055346 - ImmutableFieldRule no longer reports false positive on preinc/predecrement expressions.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3015 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-27 17:27:28 +00:00
Tom Copeland
68538b0349 Fixed JDK 1.3 incompatibilities, thanks to Ryan Gustavson for the nice patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3014 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-27 14:21:23 +00:00
Tom Copeland
2afa452cee A new rule from Eric Olander - AvoidProtectedFieldInFinalClass
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3013 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-26 21:10:07 +00:00
Tom Copeland
ee6ff0e885 Fixed path
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3012 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-26 19:03:55 +00:00
Tom Copeland
2bbfffd522 Tweaked YAHTMLRenderer to throw a RuntimeException vs an Ant-specific BuildException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3011 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-26 18:24:11 +00:00
Tom Copeland
d96749bd4e Tweaked YAHTMLRenderer to throw a RuntimeException vs an Ant-specific BuildException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3010 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-26 17:38:52 +00:00
Tom Copeland
e63ee46e4a Fixed bug 1053663 - SuspiciousConstantFieldName no longer reports false positives for interface members.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3009 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-26 17:24:47 +00:00
Jiger Patel
77c9a7ff59 Upgraded to PMD 2.0 and removed inconsistencies pointed out by running PMD!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3008 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-25 06:31:10 +00:00
Tom Copeland
b5fe5d9df1 Refactored out some Reader reading
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3007 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-22 18:13:25 +00:00
Tom Copeland
43cda6c623 Rewrote SourceCode to accept something that can load and reload code - this makes it easier to test, and the SoftReference to the loaded code is preserved
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3006 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-22 18:08:11 +00:00
Tom Copeland
78583ee897 Fixed a predecrement problem
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3005 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-22 16:31:58 +00:00
Tom Copeland
6df0a964e8 More work on Postfix nodes... another wrinkle in used/not used
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3004 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-22 14:57:16 +00:00
Tom Copeland
11e21f42d5 Fixed bug 1050295 - ImmutableFieldRule no longer reports false positives for fields which are incremented by postfix operators.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3003 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-21 20:47:25 +00:00
Tom Copeland
4b3086135c Removed old class; was replaced by VariableAccessVisitor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3002 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-21 20:08:19 +00:00
Tom Copeland
6f5239ab2f Removed some commented out code
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3001 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-21 18:03:59 +00:00
Tom Copeland
6f8b9ddd90 Eric's fix for 1050286
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3000 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-21 17:52:52 +00:00
Tom Copeland
94275a63a2 A fix for Postfix expressions using LOOKAHEAD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2999 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-21 17:43:50 +00:00
Tom Copeland
3802438172 Oops, needed to fix it for Windows line endings as well
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2998 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-20 20:35:49 +00:00
Tom Copeland
23e69d5762 Fixed bug 1039963 - CPD no longer fails to parse C++ files with multi-line macros.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2997 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-20 20:17:07 +00:00
Tom Copeland
6f595888c6 Removed unused local
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2996 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 19:23:43 +00:00
Tom Copeland
2dccbe6d95 Fixed bug 1041739 - EmptyStatementNotInLoop no longer reports false positives for nested class declarations in methods.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2995 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 18:50:49 +00:00
Tom Copeland
a405d23dfb Fixed bug 1050173 - ImmutableFieldRule no longer reports false positives for static fields. Also fixed version number in PMD.java, argh.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2994 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 18:43:27 +00:00
Tom Copeland
a830d8fcb9 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2992 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 15:19:48 +00:00
Tom Copeland
87ba090e73 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2991 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 15:17:22 +00:00
Tom Copeland
4dc3b7e7ab rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2990 51baf565-9d33-0410-a72c-fc3788e3496d
2004-10-19 15:05:21 +00:00