ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

acl-plugin: fix coverity error in acl_test.c

Browse Source 
Attempting to supply within a VAT CLI to add the ACLs a rule count
override with no rules to add would result in null pointer dereference
as we attempt to copy those rules to the message.
Add the check to avoid copy if the source pointer is null
(i.e. if there are no rules to copy from).
This commit fixes coverity errors 166797 and 166792.

Change-Id: Icabe060d961ba07dc41f63b8e17fca12ff82aa29
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
This commit is contained in:
Andrew Yourtchenko
2017-06-07 12:30:48 +02:00
committed by Damjan Marion
parent 539ed4fee5
commit 0018a3e54e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/acl/acl_test.c
View File

@ -480,7 +480,7 @@ static int api_acl_add_replace (vat_main_t * vam)
memset (mp, 0, msg_size); memset (mp, 0, msg_size);
mp->_vl_msg_id = ntohs (VL_API_ACL_ADD_REPLACE + sm->msg_id_base); mp->_vl_msg_id = ntohs (VL_API_ACL_ADD_REPLACE + sm->msg_id_base);
mp->client_index = vam->my_client_index; mp->client_index = vam->my_client_index;
if (n_rules > 0) if ((n_rules > 0) && rules)
clib_memcpy(mp->r, rules, n_rules*sizeof (vl_api_acl_rule_t)); clib_memcpy(mp->r, rules, n_rules*sizeof (vl_api_acl_rule_t));
if (tag) if (tag)
{ {
@ -934,7 +934,7 @@ static int api_macip_acl_add (vat_main_t * vam)
memset (mp, 0, msg_size); memset (mp, 0, msg_size);
mp->_vl_msg_id = ntohs (VL_API_MACIP_ACL_ADD + sm->msg_id_base); mp->_vl_msg_id = ntohs (VL_API_MACIP_ACL_ADD + sm->msg_id_base);
mp->client_index = vam->my_client_index; mp->client_index = vam->my_client_index;
if (n_rules > 0) if ((n_rules > 0) && rules)
clib_memcpy(mp->r, rules, n_rules*sizeof (mp->r[0])); clib_memcpy(mp->r, rules, n_rules*sizeof (mp->r[0]));
if (tag) if (tag)
{ {