ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make public fields final where possible

Browse Source 
Class fields initialized via the constructor should be final.

Also mark leaking byte[] instances with a FIXME. API users consider them
immutable, but they are vulnerable to System.arrayCopy().

Also fixes constructor arguments so they do not use underscores, which
is prohibited by Java 9.

Change-Id: I393d55ed7234149cb3604bc92b2cb1d1207c55dc
Signed-off-by: Robert Varga <nite@hq.sk>
This commit is contained in:
Robert Varga
2016-01-31 12:25:45 +01:00
committed by Dave Wallace
parent 52a3a4de07
commit 004da76d2b
7 changed files with 92 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java
View File

@ -16,8 +16,9 @@
package org.openvpp.vppjapi;
public class vppIPv6Address {
public byte[] ip;
public byte prefixLength;
// FIXME: this is dangerous
public final byte[] ip;
public final byte prefixLength;
public vppIPv6Address(byte[] _ip, byte _prefixLength) {
ip = _ip;