VPP-972: fix coverity warnings in the stats scraper

Change-Id: I8843e57105c6c29bcdaf1e6e3bf8e9caf6bfd2ec
Signed-off-by: Dave Barach <dave@barachs.net>
This commit is contained in:
Dave Barach
2017-09-13 09:18:08 -04:00
parent 68ec940a46
commit 0eacfa3268

View File

@ -1495,7 +1495,7 @@ static void
} }
rp = pool_elt_at_index (sm->stats_registrations, p[0]); rp = pool_elt_at_index (sm->stats_registrations, p[0]);
if (!rp->stats_registrations & INTERFACE_COMBINED_COUNTERS) // Client but doesn't want this. if (!(rp->stats_registrations & INTERFACE_COMBINED_COUNTERS)) // Client but doesn't want this.
{ {
clib_warning clib_warning
("pid %d: already disabled for interface COMBINED stats...", ("pid %d: already disabled for interface COMBINED stats...",
@ -1576,7 +1576,7 @@ vl_api_want_ip4_fib_stats_t_handler (vl_api_want_ip4_fib_stats_t * mp)
} }
rp = pool_elt_at_index (sm->stats_registrations, p[0]); rp = pool_elt_at_index (sm->stats_registrations, p[0]);
if (!rp->stats_registrations & IP4_FIB_COUNTERS) // Client but doesn't want this. if (!(rp->stats_registrations & IP4_FIB_COUNTERS)) // Client but doesn't want this.
{ {
clib_warning ("pid %d: already disabled for interface ip4 fib...", clib_warning ("pid %d: already disabled for interface ip4 fib...",
mp->pid); mp->pid);
@ -1656,7 +1656,7 @@ vl_api_want_ip6_fib_stats_t_handler (vl_api_want_ip6_fib_stats_t * mp)
} }
rp = pool_elt_at_index (sm->stats_registrations, p[0]); rp = pool_elt_at_index (sm->stats_registrations, p[0]);
if (!rp->stats_registrations & IP6_FIB_COUNTERS) // Client but doesn't want this. if (!(rp->stats_registrations & IP6_FIB_COUNTERS)) // Client but doesn't want this.
{ {
clib_warning ("pid %d: already disabled for interface ip6 fib...", clib_warning ("pid %d: already disabled for interface ip6 fib...",
mp->pid); mp->pid);