rdma: two small improvements for rdma interface

- fix branch prediction for checking rdma ERROR flag
- add the missing right angle bracket to help message

Type: improvement
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Reviewed-by: Lijian Zhang <lijian.zhang@arm.com>
Reviewed-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I2ce667631b3e3f60939069e2a16ddba0ff12a695
This commit is contained in:
Jieqiang Wang
2022-05-05 12:33:57 +00:00
committed by Beno�t Ganne
parent 0499d8839d
commit 4ebcd95e62
2 changed files with 5 additions and 5 deletions

View File

@@ -48,10 +48,10 @@ rdma_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
VLIB_CLI_COMMAND (rdma_create_command, static) = { VLIB_CLI_COMMAND (rdma_create_command, static) = {
.path = "create interface rdma", .path = "create interface rdma",
.short_help = "create interface rdma <host-if ifname> [name <name>]" .short_help = "create interface rdma <host-if ifname> [name <name>]"
" [rx-queue-size <size>] [tx-queue-size <size>]" " [rx-queue-size <size>] [tx-queue-size <size>]"
" [num-rx-queues <size>] [mode <auto|ibv|dv]" " [num-rx-queues <size>] [mode <auto|ibv|dv>]"
" [no-multi-seg] [no-striding]" " [no-multi-seg] [no-striding]"
" [max-pktlen <size>]", " [max-pktlen <size>]",
.function = rdma_create_command_fn, .function = rdma_create_command_fn,
}; };
/* *INDENT-ON* */ /* *INDENT-ON* */

View File

@@ -1028,7 +1028,7 @@ VLIB_NODE_FN (rdma_input_node) (vlib_main_t * vm,
if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ADMIN_UP) == 0) if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ADMIN_UP) == 0)
continue; continue;
if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ERROR)) if (PREDICT_FALSE (rd->flags & RDMA_DEVICE_F_ERROR))
continue; continue;
if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_MLX5DV)) if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_MLX5DV))