ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Coverty error: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT)

Browse Source 
While the code is correct (assignment was intended) I have rewritten
it for readability.

Change-Id: I5f6fd7d7377c3904e74de4edfd478322a75af612
Signed-off-by: Ole Troan <ot@cisco.com>
This commit is contained in:
Ole Troan
2016-08-04 10:19:17 +02:00
committed by Dave Barach
parent da76de2304
commit 58a90a4b16
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
vnet/vnet/map/map.c
View File

@ -1099,12 +1099,19 @@ map_params_reass_command_fn (vlib_main_t * vm, unformat_input_t * input,
while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
{ {
if (!unformat (line_input, "lifetime %u", &lifetime) && if (unformat (line_input, "lifetime %u", &lifetime))
!unformat (line_input, "ht-ratio %lf", &ht_ratio) && ;
!unformat (line_input, "pool-size %u", &pool_size) && else if (unformat (line_input, "ht-ratio %lf", &ht_ratio))
!unformat (line_input, "buffers %llu", &buffers) && ;
!((unformat (line_input, "ip4")) && (ip4 = 1)) && else if (unformat (line_input, "pool-size %u", &pool_size))
!((unformat (line_input, "ip6")) && (ip6 = 1))) ;
else if (unformat (line_input, "buffers %llu", &buffers))
;
else if (unformat (line_input, "ip4"))
ip4 = 1;
else if (unformat (line_input, "ip6"))
ip6 = 1;
else
{ {
unformat_free (line_input); unformat_free (line_input);
return clib_error_return (0, "invalid input"); return clib_error_return (0, "invalid input");