ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

l2: fix null deref in l2_to_bvi()

Browse Source 
Type: fix

Static analysis identified a possible null pointer dereference. It
was introduced by a recent patch which expanded the DMAC comparison
on inbound packets on a BVI interface to include any secondary MAC
addresses which were added to an interface.

Check if the pointer is null before dereferencing.

Change-Id: Ic2afe2b062eda32977e05bf3f98d82c1fe64620c
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
(cherry picked from commit 78681def21b931309a779dfc6a5cbc6ff8b1f814)
This commit is contained in:
Matthew Smith 2020-09-10 10:09:01 -05:00 committed by Andrew Yourtchenko
parent c13aab8ca1
commit 649ba152cb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vnet/l2/l2_bvi.h
View File

@ -72,7 +72,7 @@ l2_to_bvi (vlib_main_t * vlib_main,
ethernet_interface_t *ei = ethernet_get_interface (em, hi->hw_if_index);
u32 rv;
if (PREDICT_FALSE (vec_len (ei->secondary_addrs) > 0))
if (PREDICT_FALSE (ei && (vec_len (ei->secondary_addrs) > 0)))
rv = l2_to_bvi_dmac_check (hi, e0->dst_address, ei,
1 /* have_sec_dmac */ );
else