linux-cp: fix coverity defect

Type: fix

If no host interface name is passed to the CLI command which creates
an interface pair, NULL gets passed to lcp_itf_pair_create() and a
seg fault occurs. Check whether a host interface name was provided
and fail gracefully if none was given.

Change-Id: I82886f4c2ee710e206c751c34a74399112e9062c
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
This commit is contained in:
Matthew Smith
2021-02-16 10:02:46 -06:00
committed by Neale Ranns
parent 93c4b1bb3f
commit 6abdf34d3a
+6
View File
@@ -72,6 +72,12 @@ lcp_itf_pair_create_command_fn (vlib_main_t *vm, unformat_input_t *input,
unformat_free (line_input);
if (!host_if_name)
{
vec_free (ns);
return clib_error_return (0, "host interface name required");
}
if (sw_if_index == ~0)
{
vec_free (host_if_name);