ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

svm: release mem order for fifo chunk list CAS

Browse Source 
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ifad679f46abd6e9c18a3eaf7e55800a09f3791ab
(cherry picked from commit 324d161963025a595a79a10cf953b23250f825a1)
This commit is contained in:
Florin Coras 2021-06-02 11:17:29 -07:00 committed by Dave Wallace
parent 5b6d2c1ae2
commit 76189089b5
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/svm/fifo_segment.c
View File

@ -161,8 +161,9 @@ fss_chunk_free_list_push (fifo_segment_header_t *fsh,
c->next = old_head & FS_CL_HEAD_MASK;
new_head = csp + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
}
while (!clib_atomic_cmp_and_swap_acq_relax (
&fss->free_chunks[fl_index], &old_head, &new_head, 1 /* weak */));
while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
&new_head, 0 /* weak */, __ATOMIC_RELEASE,
__ATOMIC_ACQUIRE));
}
static void
@ -181,8 +182,9 @@ fss_chunk_free_list_push_list (fifo_segment_header_t *fsh,
tail->next = old_head & FS_CL_HEAD_MASK;
new_head = headsp + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
}
while (!clib_atomic_cmp_and_swap_acq_relax (
&fss->free_chunks[fl_index], &old_head, &new_head, 1 /* weak */));
while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
&new_head, 0 /* weak */, __ATOMIC_RELEASE,
__ATOMIC_ACQUIRE));
}
static svm_fifo_chunk_t *
@ -210,8 +212,9 @@ fss_chunk_free_list_pop (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss,
c = fs_chunk_ptr (fsh, old_head & FS_CL_HEAD_MASK);
new_head = c->next + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
}
while (!clib_atomic_cmp_and_swap_acq_relax (
&fss->free_chunks[fl_index], &old_head, &new_head, 1 /* weak */));
while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
&new_head, 0 /* weak */, __ATOMIC_RELEASE,
__ATOMIC_ACQUIRE));
return c;
}