ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vppinfra: deprecate clib_mem_is_vec

Browse Source 
Use of clib_mem_is_heap_object is not reliable enough for production use
as it relies on just few bytes of memory allocator chunk header.

Type: improvement
Change-Id: I48c8adde8b6348b15477e3a015ba515eb7ee7ec2
Signed-off-by: Damjan Marion <damarion@cisco.com>
This commit is contained in:
Damjan Marion
2022-03-23 18:53:29 +01:00
committed by Florin Coras
parent f87acfaf73
commit 8d7cdc808f
3 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/dpdk/device/format.c
View File

@ -238,8 +238,6 @@ format_offload (u8 * s, va_list * va)
uword i, l; uword i, l;
l = ~0; l = ~0;
if (clib_mem_is_vec (id))
l = vec_len (id);
if (id) if (id)
for (i = 0; id[i] != 0 && i < l; i++) for (i = 0; id[i] != 0 && i < l; i++)

2
src/vppinfra/std-formats.c
View File

@ -396,8 +396,6 @@ format_c_identifier (u8 * s, va_list * va)
uword i, l; uword i, l;
l = ~0; l = ~0;
if (clib_mem_is_vec (id))
l = vec_len (id);
if (id) if (id)
for (i = 0; i < l && id[i] != 0; i++) for (i = 0; i < l && id[i] != 0; i++)

12
src/vppinfra/vec.h
View File

@ -187,18 +187,6 @@ _vec_resize_will_expand (void *v, uword n_elts, uword elt_size)
#define vec_resize_will_expand(V, N) \ #define vec_resize_will_expand(V, N) \
_vec_resize_will_expand (V, N, sizeof ((V)[0])) _vec_resize_will_expand (V, N, sizeof ((V)[0]))
/** \brief Predicate function, says whether the supplied vector is a clib heap
object
@param v pointer to a vector
@return 0 or 1
*/
always_inline uword
clib_mem_is_vec (void *v)
{
return clib_mem_is_heap_object (vec_header (v));
}
/* Local variable naming macro (prevents collisions with other macro naming). */ /* Local variable naming macro (prevents collisions with other macro naming). */
#define _v(var) _vec_##var #define _v(var) _vec_##var