ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tests: use self.assertNotIn().

Browse Source 
Many tests use self.assertEqual(error.find("failed"), -1)
Use self.assertNotIn("failed", error) to provide more meaningful errors such as
AssertionError: 'Failed' not found in '' instead of 0 != -1.

Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
This commit is contained in:
Paul Vinciguerra
2019-03-06 15:11:28 -08:00
committed by Ole Trøan
parent f70cead5eb
commit 9a6dafd569
13 changed files with 35 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/test_bihash.py
View File

@ -25,7 +25,7 @@ class TestBihash(VppTestCase):
if error:
self.logger.critical(error)
self.assertEqual(error.find("failed"), -1)
self.assertNotIn('failed', error)
def test_bihash_thread(self):
""" Bihash Thread Test """
@ -34,7 +34,7 @@ class TestBihash(VppTestCase):
if error:
self.logger.critical(error)
self.assertEqual(error.find("failed"), -1)
self.assertNotIn('failed', error)
if __name__ == '__main__':
unittest.main(testRunner=VppTestRunner)