vppinfra: fix clib_bitmap_will_expand() result inversion
Pool's pool_put_will_expand() calls clib_bitmap_will_expand(), so every put except ones that leads to free_bitmap reallocation will get false positive results and vice versa. Unfortunatelly there's no related test and existing bitmap tests are failing silently with false positive result as well. Fortunatelly neither clib_bitmap_will_expand() nor pool_put_will_expand() are being used by current vpp codebase. Type: fix Signed-off-by: Vladislav Grishenko <themiron@yandex-team.ru> Change-Id: Id5bb900cf6a1b1002d37670f5c415c74165b5421
This commit is contained in:
committed by
Damjan Marion
parent
1ee334c6f8
commit
a20afdc845
@@ -8,8 +8,6 @@ from asfframework import VppTestCase, VppTestRunner
|
||||
class TestVppinfra(VppTestCase):
|
||||
"""Vppinfra Unit Test Cases"""
|
||||
|
||||
vpp_worker_count = 1
|
||||
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
super(TestVppinfra, cls).setUpClass()
|
||||
@@ -25,16 +23,15 @@ class TestVppinfra(VppTestCase):
|
||||
super(TestVppinfra, self).tearDown()
|
||||
|
||||
def test_bitmap_unittest(self):
|
||||
"""Bitmap Code Coverage Test"""
|
||||
"""Bitmap unit tests"""
|
||||
|
||||
cmds = ["test bitmap"]
|
||||
|
||||
for cmd in cmds:
|
||||
r = self.vapi.cli_return_response(cmd)
|
||||
if r.retval != 0:
|
||||
if hasattr(r, "reply"):
|
||||
self.logger.info(cmd + " FAIL reply " + r.reply)
|
||||
else:
|
||||
self.logger.info(cmd + " FAIL retval " + str(r.retval))
|
||||
error = self.vapi.cli(cmd)
|
||||
if error:
|
||||
self.logger.critical(error)
|
||||
self.assertNotIn("failed", error)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
|
||||
Reference in New Issue
Block a user