ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IPSEC: Tunnel SA not deleted

Browse Source 
p is overwritten by hash_unset so an incorrect value is passed to
ipsec_sa_del

Change-Id: I97300dd4421c62d7cfa47b8e7e9789becb2370e9
Signed-off-by: Neale Ranns <nranns@cisco.com>
This commit is contained in:
Neale Ranns
2019-03-20 14:10:23 +00:00
committed by Damjan Marion
parent b966e8bfdd
commit c80cc9ab84
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/vnet/ipsec/ipsec_if.c
View File

@ -382,11 +382,14 @@ ipsec_add_del_tunnel_if_internal (vnet_main_t * vnm,
} }
else else
{ {
u32 ti;
/* check if exists */ /* check if exists */
if (!p) if (!p)
return VNET_API_ERROR_INVALID_VALUE; return VNET_API_ERROR_INVALID_VALUE;
t = pool_elt_at_index (im->tunnel_interfaces, p[0]); ti = p[0];
t = pool_elt_at_index (im->tunnel_interfaces, ti);
hi = vnet_get_hw_interface (vnm, t->hw_if_index); hi = vnet_get_hw_interface (vnm, t->hw_if_index);
vnet_sw_interface_set_flags (vnm, hi->sw_if_index, 0); /* admin down */ vnet_sw_interface_set_flags (vnm, hi->sw_if_index, 0); /* admin down */
@ -401,8 +404,8 @@ ipsec_add_del_tunnel_if_internal (vnet_main_t * vnm,
pool_put (im->tunnel_interfaces, t); pool_put (im->tunnel_interfaces, t);
/* delete input and output SA */ /* delete input and output SA */
ipsec_sa_del (ipsec_tun_mk_input_sa_id (p[0])); ipsec_sa_del (ipsec_tun_mk_input_sa_id (ti));
ipsec_sa_del (ipsec_tun_mk_output_sa_id (p[0])); ipsec_sa_del (ipsec_tun_mk_output_sa_id (ti));
} }
if (sw_if_index) if (sw_if_index)