ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

session: always clear rx evt flag on ntf

Browse Source 
Apps may drain fifos prior to handling of accept notification, e.g.,
vcl session relying on epoll lt mode.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7d105d35a6bf33c419f4f137a5132e6a5d294fe7
This commit is contained in:
Florin Coras
2023-11-16 21:16:13 -08:00
committed by Dave Wallace
parent dac9e566cd
commit cfe6462fd2
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vnet/session/session_input.c
View File

@ -113,20 +113,22 @@ app_worker_flush_events_inline (app_worker_t *app_wrk, u32 thread_index,
{ {
case SESSION_IO_EVT_RX: case SESSION_IO_EVT_RX:
s = session_get (evt->session_index, thread_index); s = session_get (evt->session_index, thread_index);
s->flags &= ~SESSION_F_RX_EVT;
/* Application didn't confirm accept yet */ /* Application didn't confirm accept yet */
if (PREDICT_FALSE (s->session_state == SESSION_STATE_ACCEPTING || if (PREDICT_FALSE (s->session_state == SESSION_STATE_ACCEPTING ||
s->session_state == SESSION_STATE_CONNECTING)) s->session_state == SESSION_STATE_CONNECTING))
break; break;
s->flags &= ~SESSION_F_RX_EVT;
app->cb_fns.builtin_app_rx_callback (s); app->cb_fns.builtin_app_rx_callback (s);
break; break;
/* Handle sessions that might not be on current thread */ /* Handle sessions that might not be on current thread */
case SESSION_IO_EVT_BUILTIN_RX: case SESSION_IO_EVT_BUILTIN_RX:
s = session_get_from_handle_if_valid (evt->session_handle); s = session_get_from_handle_if_valid (evt->session_handle);
if (!s || s->session_state == SESSION_STATE_ACCEPTING || if (!s)
s->session_state == SESSION_STATE_CONNECTING)
break; break;
s->flags &= ~SESSION_F_RX_EVT; s->flags &= ~SESSION_F_RX_EVT;
if (PREDICT_FALSE (s->session_state == SESSION_STATE_ACCEPTING ||
s->session_state == SESSION_STATE_CONNECTING))
break;
app->cb_fns.builtin_app_rx_callback (s); app->cb_fns.builtin_app_rx_callback (s);
break; break;
case SESSION_IO_EVT_TX: case SESSION_IO_EVT_TX: