ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pci: fix non NULL-terminated vector used as C string overflow

Browse Source 
Type: fix

Change-Id: Iab512ba8c72c9e20aeba2d4265276bcabf095d46
Signed-off-by: Benoît Ganne <bganne@cisco.com>
This commit is contained in:
Benoît Ganne
2020-07-24 17:04:06 +02:00
committed by Dave Wallace
parent c7fd24e30b
commit e3a24300d0
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/vlib/linux/vfio.c
View File

@ -185,8 +185,9 @@ linux_vfio_group_get_device_fd (vlib_pci_addr_t * addr, int *fdp,
int fd; int fd;
*is_noiommu = 0; *is_noiommu = 0;
s = format (s, "/sys/bus/pci/devices/%U/iommu_group", format_vlib_pci_addr, s =
addr); format (s, "/sys/bus/pci/devices/%U/iommu_group%c", format_vlib_pci_addr,
addr, 0);
tmpstr = clib_sysfs_link_to_name ((char *) s); tmpstr = clib_sysfs_link_to_name ((char *) s);
if (tmpstr) if (tmpstr)
{ {
@ -201,8 +202,8 @@ linux_vfio_group_get_device_fd (vlib_pci_addr_t * addr, int *fdp,
} }
vec_reset_length (s); vec_reset_length (s);
s = format (s, "/sys/bus/pci/devices/%U/iommu_group/name", s = format (s, "/sys/bus/pci/devices/%U/iommu_group/name%c",
format_vlib_pci_addr, addr); format_vlib_pci_addr, addr, 0);
err = clib_sysfs_read ((char *) s, "%s", &tmpstr); err = clib_sysfs_read ((char *) s, "%s", &tmpstr);
if (err == 0) if (err == 0)
{ {