ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

init / exit function ordering

Browse Source 
The vlib init function subsystem now supports a mix of procedural and
formally-specified ordering constraints. We should eliminate procedural
knowledge wherever possible.

The following schemes are *roughly* equivalent:

static clib_error_t *init_runs_first (vlib_main_t *vm)
{
   clib_error_t *error;

   ... do some stuff...

   if ((error = vlib_call_init_function (init_runs_next)))
     return error;
   ...
}
VLIB_INIT_FUNCTION (init_runs_first);

and

static clib_error_t *init_runs_first (vlib_main_t *vm)
{
   ... do some stuff...
}
VLIB_INIT_FUNCTION (init_runs_first) =
{
    .runs_before = VLIB_INITS("init_runs_next"),
};

The first form will [most likely] call "init_runs_next" on the
spot. The second form means that "init_runs_first" runs before
"init_runs_next," possibly much earlier in the sequence.

Please DO NOT construct sets of init functions where A before B
actually means A *right before* B. It's not necessary - simply combine
A and B - and it leads to hugely annoying debugging exercises when
trying to switch from ad-hoc procedural ordering constraints to formal
ordering constraints.

Change-Id: I5e4353503bf43b4acb11a45fb33c79a5ade8426c
Signed-off-by: Dave Barach <dave@barachs.net>
This commit is contained in:
Dave Barach
2019-05-14 18:01:44 -04:00
committed by Florin Coras
parent c1f93067ed
commit f8d50682cd
62 changed files with 959 additions and 476 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/nsh/nsh-md2-ioam/nsh_md2_ioam_trace.c
View File

@@ -354,13 +354,6 @@ nsh_md2_ioam_trace_init (vlib_main_t * vm)
{
nsh_md2_ioam_trace_main_t *hm = &nsh_md2_ioam_trace_main;
nsh_md2_ioam_main_t *gm = &nsh_md2_ioam_main;
clib_error_t *error;
if ((error = vlib_call_init_function (vm, nsh_init)))
return (error);
if ((error = vlib_call_init_function (vm, nsh_md2_ioam_init)))
return (error);
hm->vlib_main = vm;
hm->vnet_main = vnet_get_main ();
@@ -384,7 +377,12 @@ nsh_md2_ioam_trace_init (vlib_main_t * vm)
return (0);
}
VLIB_INIT_FUNCTION (nsh_md2_ioam_trace_init);
/* *INDENT-OFF* */
VLIB_INIT_FUNCTION (nsh_md2_ioam_trace_init) =
{
.runs_after = VLIB_INITS ("nsh_init", "nsh_md2_ioam_init"),
};
/* *INDENT-ON* */
int
nsh_md2_ioam_trace_profile_cleanup (void)