Commit Graph

9905 Commits

Author SHA1 Message Date
Florin Coras
52dd29ff51 vcl: stop tracking vpp event queues and thread index
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Icbee02a39650bc792532adc714bcf4f47f3fbe59
2020-11-19 22:14:39 +00:00
Neale Ranns
8b276df32f ipip: Don't crash when showing non-existant tunnel index
Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I9717d420e42098e291c5b6c7d18e935ad78fdc3d
2020-11-19 21:56:49 +00:00
Dmitry Vakhrushev
4a98cf9648 lldp: allow to configure restricted interfaces
This improvement intended to allow sending of LLDP packets on an
interface even if the interface cannot support programming an extra
MAC address in order to receive LLDP messages from the attached
link peer.
  vnet_hw_interface_add_del_mac_address function fails on some
'virtio' interfaces due to limitation to set MAC addresses.

Type: improvement

Change-Id: I636de148736a0797d1fd70c6ab14759ff8fa42be
Signed-off-by: Dmitry Vakrhushev <dmitry@netgate.com>
2020-11-19 21:54:57 +00:00
Florin Coras
91b364010c svm: init chunk rb tree indices in fifo
Type: improvement

Let fifo segment mainly deal with fifo and chunk allocations not
initialization.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1f1eb5a1423ba52cb950ae771641fd7eeff4e76c
2020-11-19 21:36:32 +00:00
Benoît Ganne
d9ed0b6786 ikev2: respect punting only for ipv4
IPSec punting to IKEv2 is valid only for NAT-T in IPv4.
Fix coverity CID 214915.

Type: fix

Change-Id: I6f2db38abf179565316f50c5d47c78acce3a0d01
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-19 21:32:54 +00:00
Dmitry Vakrhushev
83f37fc3bd dpdk: Telemetry thread is off by default.
Currently thread with telemetry is enabled by default, to prevent
to use resources, thread should be off. The thread can be switch on
back using additional option in the dpdk's stanza.

dpdk {
	telemetry
}

Type: feature

Change-Id: I1c25e8ee99f31dd01dc372f54e77e81a5bb67126
Signed-off-by: Dmitry Vakrhushev <dmitry@netgate.com>
2020-11-19 20:54:53 +00:00
Damjan Marion
97d6860b22 dpdk: remove dpdk_early_init
We cannot disable dpdk plugin if hugepages are not present, as there
are some valid uses cases where dpdk works unpriviledged without
hugepages.

Type: fix
Change-Id: If67d8c941617ac0f16d496655d2bb6e489d34ad4
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-11-19 18:03:22 +00:00
Benoît Ganne
e3e9d8af46 svm: fix high segment base address for ASan
AddressSanitizer has specific requirements on memory map. In particular,
the range [0x00007fff8000, 0x10007fff7fff] is reserved for ASan use.

Type: fix
Fixes: f260eb9786

Change-Id: Ie96c4dd88b4f02d7fc5c24464572ff72cb6fd96b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-19 15:35:00 +00:00
Ole Troan
2064047b9e papi: add paul back as maintainer
Paul accidentially got removed as maintainer for papi. Add him back.

Fixes: 6df2c79541
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I697342e0c3793d9f5ea5b39a0d37a8522b34858e
2020-11-19 14:01:37 +00:00
Benoît Ganne
4b73b55d70 build: bump libbpf to v0.2
Type: improvement

Change-Id: Ic97ed8c8ef8ba3b1bf3727810e7312456c52d808
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-19 10:03:49 +00:00
Benoît Ganne
a54fce3a26 build: bump rdma-core to 31.1
Type: improvement

Change-Id: I434d2013763e32bedf2188aea5b0c519ea0e06bb
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-19 10:03:35 +00:00
Florin Coras
473c846047 svm: fifo segment cleanup
- consolidate chunk freelist functions
- remove redundant functions

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Idd7e6700e2cc98a0fb9cfe20a2b739218fd48043
2020-11-18 21:54:59 +00:00
Matthew Smith
9585d79f7a dpdk: change mlx5 pmd name in foreach_dpdk_pmd
Type: fix

With DPDK 20.08, mlx5 devices get bound to the mlx5_pci PMD instead
of net_mlx5. Update the name in foreach_dpdk_pmd so the PMD will be
correctly recognized during initialization.

Change-Id: I1863ec55da9fcf6a289959dff22ca2dcc5d114bc
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2020-11-18 13:37:22 -06:00
Filip Tehlar
727082016f ikev2: fix memleak when tunnel protect fails
Type: fix

Change-Id: I1d278fc2b03b948c054ff1686315635ac0278ae8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-18 08:14:46 +00:00
Mohsin Kazmi
b977d3f7c2 virtio: virtio: implement packed queues from virtio 1.1
Type: feature

Change-Id: I12703371541298efa029903d6762b1cd1f7322ca
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-11-17 16:43:26 +00:00
Neale Ranns
b18796092b geneve: Remove one bucket load-balance objects
Type: improvement

geneve uses the UDP source port for the flow hash to get load-balancing
over multiple paths to the tunnel destination. However, if there is only
one path, then we can elide the LB object, contributed by the resolving
FIB entry, from the dasta path.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I13a1bedc307a474d258a757bc1bae28564798730
2020-11-17 12:26:40 +00:00
Paul Vinciguerra
2e8760628d papi: remove dependency on aenum
remove the dependency on the aenum package which was used to
provide Enum.IntFlag which is now available in the python stdlib.

aenum is not provided as a .deb and causes issues in packaging.

Type: fix

Change-Id: Ie45ec2130a767345f0aad038451780a5ddc7e8db
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-11-17 08:36:30 +00:00
Dave Wallace
ff1f089c3a tests: move crypto tests to src/vnet/crypto/test
- Refactor make test code to be co-located with
  the vpp feature source code

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I089bda44c31cbb217132e5b385cd9ea96ea5239e
2020-11-17 00:51:50 +00:00
Dave Wallace
b5c6d08f03 tests: move classifier tests to src/vnet/classify/test
- Refactor make test code to be co-located with
  the vpp feature source code.

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ibae85a18df0d5a53e2a59c678a2a27499f54ce6d
2020-11-17 00:51:22 +00:00
Dave Wallace
e1887c1765 tests: move vpp-api tests to src/vpe-api/test
- Refactor make test code to be co-located with
  the vpp feature source code

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ic42bbd4e13606a5fdc91143ecc6452102ec337fe
2020-11-17 00:47:31 +00:00
Dave Wallace
634c293949 tests: move gre tests to src/vnet/gre/test
- Refactor make test code to be co-located with
  the vpp feature source code

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I4fa716778712ebfb1b136df98775345372d3dfad
2020-11-17 00:46:44 +00:00
Dave Wallace
99bf1670c2 tests: move GSO/GRO tests to src/vnet/gso/test
- Refactor make test code to be co-located with
  the vpp feature source code

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Id9c5bf2cd01b6c1fd1750b4978d01597ee3bbf53
2020-11-17 00:45:30 +00:00
Dave Wallace
85b0f79126 tests: move cli tests to src/vlib/test
- Refactor make test code to be co-located with
  the vpp feature source code

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ic27fb8c476cfd95879dec645c3c0cd6db341ee00
2020-11-16 23:21:43 +00:00
Dave Wallace
2f10886a71 tests: move buffer tests to src/vlib/test
- Refactor make test code to be co-located with
  the vpp feature source code.

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Id3f856d9c8de1695edd5b968b8acfa2b382a0139
2020-11-16 20:59:20 +00:00
Dave Wallace
8de5fc2bd4 tests: move bihash tests to src/vppinfra/test
- Refactor make test code to be co-located with
  the vpp feature source code.

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I0133a00def595fe1c08ab881633ef9f89148a286
2020-11-16 14:18:51 -05:00
Benoît Ganne
34a19b2ddc docs: fix memory troubleshooting doc
Type: docs

Change-Id: Id9f8f6f13e4a41567adf7dc68e6c9be42dd82de7
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-16 13:03:19 +00:00
Miklos Tirpak
69842be389 fib: increase the reference counter size for mfib to 32 bits
The 16 bits counter size limits the number of interfaces to 65K which is
too low for certain use cases. GTP-U for example creates a new interface
for every tunnel.

This change makes the mfib reference counter size inline with the fib one.

Type: fix
Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: I9354367484f3232fc5a770f2df7e0959e22e626f
2020-11-16 09:57:52 +00:00
Benoît Ganne
fcee30d6f5 fib: remove misleading FIB_PATH_TYPE_LAST
FIB_PATH_TYPE_LAST seems to not have been updated accordingly. It is
unused anyway, just remove it.

Type: improvement

Change-Id: I195e556a6695e3250cc03070ffd9262349f2c77b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-16 09:55:00 +00:00
Mohammed Hawari
80ac72894c avf: add L4 checksum offload support
Change-Id: Ie90437cf597c5d53ab1cc41ea7db15b97614e2fc
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement
2020-11-15 08:52:15 +00:00
Mohammed Hawari
798267aaa2 rdma: implement multiseg rx without striding rq
Change-Id: I623617ad3c80610805dd3cf2a5f371e6677f4844
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement
2020-11-13 16:58:18 +00:00
yult
b8e129314a vlib: macro definition error
in 'VLIB_DECLARE_INIT_FUNCTION(x, tag)' '_vlib_init_function_##tag_##x'
should be '_vlib_init_function_##tag##_##x'

Type: fix

Signed-off-by: yult <oopsadm@gmail.com>
Change-Id: I091c8aa6091fe6e314e50fa00201d035869a1d96
2020-11-13 16:18:02 +00:00
Andrew Yourtchenko
fba2732ec8 avf: actually delete ethernet address if deletion was requested
fixes the coverity issue 214893.

Type: fix
Fixes: 1ab533cba2
Change-Id: I1159f5e23d1cdfcf6575c29d11e884703afee20f
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-11-13 15:49:50 +00:00
Andrew Yourtchenko
66d10589f4 cnat: zero-initialize structs
fixes coverity errors 215294, 215295

Type: fix
Fixes: af897c5e3f
Change-Id: Ie5da2bcddb465020d827d9f7c519a528cf2bd035
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-11-13 15:48:14 +00:00
Filip Varga
25fd8ad03e nat: cleanup & reorganization
Fixed compatibility issue between
nat ei and nat ed modes. Moved nat
syslogging to nat librarry. Deprecating
apis that will be integrated in upcoming
candidate configuration patch.

Type: refactor

Change-Id: I334b1b05b81b74667c5c76a05f768442e0dcf7e8
Signed-off-by: Filip Varga <fivarga@cisco.com>
2020-11-13 15:45:23 +00:00
Florin Coras
e655240550 session: fix fifo tuning init on connect
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6f81d2010e98d0a5fbdc315abc04737bbcc1c434
2020-11-13 15:41:36 +00:00
Andrew Yourtchenko
a5180ba1b1 pg: fix uninitialized variable in pg mac filter CLI
Fixes coverity issue 214887

Change-Id: I81bfc009faabcb74f950a94715a0395fac264ee9
Type: fix
Fixes: 21fb4f71ee
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-11-13 15:38:17 +00:00
Nathan Skrzypczak
f260eb9786 svm: change high_seg_baseva
Type: fix

It appears that the session layer baseva is conflicting
with DPDK. 0x2000000000 seem to be working experimentally
Configurable with :

session {
  segment-baseva 0x2000000000
}

Change-Id: Ie93b9b9eb56a796877d614f78eb5801ea8e5ab31
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
2020-11-13 15:34:00 +00:00
Benoît Ganne
1ff3ee9553 af_xdp: fix doc
Type: docs

Change-Id: I1d28fb31032412f0231d677e45281ca88185502e
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-13 15:29:07 +00:00
Benoît Ganne
7d2094c12b interface: add multiarch support for per-interface tx node
Type: improvement

Change-Id: Ia4ce47c0f727cf7b02294f05b94f14e788f52f30
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-13 11:46:41 +00:00
Damjan Marion
6807b77f24 vlib: vlib_buffer_t should be always 128 bytes, not 2 cachelines
Fixes issues on systems with 128-byte cacheline.

Type: fix
Change-Id: I33689ffa5ef0a879b4bf93c25d48618dd43daf58
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-11-13 11:32:56 +00:00
Benoît Ganne
b44c77d01d ethernet: mac must support 64-bits loads
ethernet dataplane loads MAC addresses as 64-bits loads for efficiency.
We must make sure it is valid, especially for the vector of secondary
MACs.

Type: fix

Change-Id: I851e319b8a973c154e85ff9f05f3b8e385939788
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-11-13 11:17:50 +00:00
Ray Kinsella
41c0f45a56 crypto-native: fix multi-arch variant initialization
crypto_native/main.h is being built as default,
and crypto_native_main is initialized with a size of 64 bytes.

crypto_native/aes_gcm.c and crypto_native/aes_cbc.c are march
variants, their ICL variants are expecting crypto_native_main
to be 256 bytes.

Type: fix

Signed-off-by: Georgii Tkachuk <georgii.tkachuk@intel.com>
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I4cddb75b712ea83c9cfca621887605d7bae104ec
2020-11-13 10:32:10 +00:00
Filip Varga
b227aa699f nat: api,cli and test update & cleanup
Cleanup of print functions in api file,
splitting functionality of cleanup callbacks for ED
and EI NAT. Updating and fixing API & CLI calls.

Type: refactor

Change-Id: I7a9dc4c8b1d2ca29db4754be7dfa4f698942127a
Signed-off-by: Filip Varga <fivarga@cisco.com>
2020-11-13 10:06:57 +00:00
Ahmed Abdelsalam
80f0b88fc3 sr: show the hop-limit value used for SRv6 encapsulation
Implements CLI to show the hop-limit value used for the
outer IPv6 header of the SRv6 encapsulation.

Type: feature
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I1f3d8f71fb94494ae6ab8104b9fcf989c5585d5c
2020-11-13 09:54:13 +00:00
Damjan Marion
ccbb0665ae avf: don't switch process if already running process node
Type: fix
Change-Id: I82b11339402b5848b27c600f6484aaeee66cc888
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-11-12 16:39:38 +00:00
Florin Coras
fb9d374020 tcp: push last buffered sequence
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba914ac69585e89f174f09e74ae716df1b080c59
2020-11-12 16:31:29 +00:00
Matthew Smith
aeb7d80c84 nat: use table ID for nat44 ipfix session events
Type: fix

IPfix messages about NAT44 session create/delete were being populated
with the FIB table index instead of the table ID. The table ID is the
correct identifier to report externally (NAT64 IPfix messages for BIB
and session create/delete use table ID, as does NAT syslogging). Convert
the table index to an ID before adding it to the IPfix NAT44 session
create/delete message data.

Change-Id: I0166384752b17ff3a8c55aa19fa2af7a8140791e
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2020-11-12 15:16:46 +00:00
Damjan Marion
2db9273155 devices: remove unused code
Type: refactor
Change-Id: I3f561818bc7c221f676477a52c7c7781624c185a
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-11-12 14:37:56 +00:00
Mohsin Kazmi
81dac0670b virtio: fix the index issue
Type: fix

Fixes: 587f913042

Change-Id: I230993a54c84e22e324de2a8defeda83c517d733
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-11-12 14:22:14 +00:00
Florin Coras
c67724a224 tcp: validate fin seq in closing states
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id8673cff699cfdc1ac68797b9ab5cdf6f6b578a3
2020-11-11 16:47:50 +00:00