855 Commits

Author SHA1 Message Date
Dave Barach
f9c231ec12 vpp-189 Clean up more coverity warnings
Time to make the donuts

Change-Id: I528937800f7daefce19723dda0216e58d857942c
Signed-off-by: Dave Barach <dave@barachs.net>
2016-08-05 10:10:38 -04:00
Dave Barach
56faee8372 VPP-189 Clean up more coverity warnings
Change-Id: I1b971ab326dc334a4743fd7d4184cef106b0523d
Signed-off-by: Dave Barach <dave@barachs.net>
2016-08-05 13:21:59 +00:00
Filip Tehlar
91c7d387fb VPP-197: LISP Source/Dest control plane support
Change-Id: I0db53af96b925ec0d975dd77f471804b61351aec
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-08-04 22:04:29 +00:00
Keith Burns (alagalah)
114e8a91a0 Update coding style for hash_foreach_mem
Change-Id: I2f336331463cedb2703150b003761e5c6e4431e8
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-08-04 17:06:01 +00:00
Dave Barach
72d7223163 VPP-237 vpp-api-test coding style cleanup
Change-Id: I50a5412463e9346149a7504344a68c8b5762dc97
Signed-off-by: Dave Barach <dave@barachs.net>
2016-08-04 10:15:21 -04:00
John Lo
c08f5a7aef ENIC driver patch for PKT_RX_VLAN_PKT packet flag backward compatibility
The PKT_RX_VLAN_PKT flag will be totally obsolete by 16.11. We still need
this ENIC driver patch for 16.07.

Change-Id: I287035525d2d1b5313e88e9e74b6310536de2c32
Signed-off-by: John Lo <loj@cisco.com>
2016-08-04 12:13:05 +00:00
Florin Coras
bb5c22f1b6 LISP multihoming API changes and cleanup
Change-Id: I106352a6da0fad2b91dc8593f8d6d664af3113a8
Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-08-04 11:58:07 +00:00
Keith Burns (alagalah)
f3f2541690 VPP-166 Documentation changes for ip4_forward.c
Change-Id: Ia9f80bea9ca8a94430ed37ececbe4434f9f5ad48
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-08-03 23:29:34 +00:00
Keith Burns (alagalah)
9d3a879d9d VPP-226 - adding UDP TCP to port-range
Change-Id: I5f4261279dcdbb03e182b18d05602407c0e55f89
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-08-03 22:02:27 +00:00
Keith Burns (alagalah)
79b5f638e5 VPP-166 Documentation changes for ip4.h/lookup.h
Change-Id: Ia9f18b0eeba3a7cee35e66dbd15d3efb567acfc6
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-08-03 20:39:40 +00:00
Dave Barach
3389bbcad0 VPP-180 Clean up multi-socket / multi-chunk mempool discovery
Change the default DPDK version to 16.07, and rename the indicated
patch directory. Use the native vhost-user driver.

Change-Id: Ie3d17e90e363ce86f0233b58c152de683b5d9456
Signed-off-by: Dave Barach <dave@barachs.net>
2016-08-03 15:18:37 +00:00
Florin Coras
429e795197 LISP API/VAT cleanup
- cleaned up some of the LISP APIs
- added support for mac in dp APIs

Change-Id: I11d419a30d73ddbf6554768d6dc2a09cc5a6e072
Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-08-03 11:48:32 +00:00
Marek Gradzki
8a1531dfb7 VPP-233: disallow array[0] in reply messages
- updates jvpp generator to raise exception
  if array[0] is present in reply/detail/counter message

- fixes vpe.api reply/detail/counter messages
  that use incorrect variable array syntax.

Additional info:

Variable arrays in reply/detail/counter messages needs to have
lenght defined in other variable within the message.
The other variable can have any name, so it is impossible to
generate Java/Python code handling.

New syntax introduced by
https://gerrit.fd.io/r/#/c/1617/
fixes the problem:

u32 some_var;
XX array[some_var];

Change-Id: I0af50f1ef1d94d95b56d9326d4e944e72b4edcdd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-08-03 11:42:34 +02:00
Filip Tehlar
5ca5dc8651 API support for src/dst based routing policy in LISP
Change-Id: I0ae90f884378acabeda310a6431c89f3ec195d0e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-08-02 19:48:09 +02:00
Marek Gradzki
8e5458caea VPP-229: fix NPE in JNI array handling
Change-Id: Ieb5182a7a3612e09bd2b28eb6a4abbdb4d29d34b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-08-02 14:27:33 +00:00
Thomas F Herbert
7b75d211ae Fix for broken vagrant installs when using Vagrant 1.8.5.
I upgraded Fedora23 which installed kernel 4.6.4 which in turn required
VirtualBox 5.1.2 which in turn required Vagrant 1.8.5.

Workaround for a change in Vagrant 1.8.5 that breaks Centos. The
newer version of Vagrant doesn't chmod the ssh directory before trying to copy
new public key during installs. This will be fixed upstream in Vagrant 1.8.6.
Bug doesn't affect Ubuntu because it uses a different umask whereas Centos uses
0002.

Change-Id: I8108d4cc208fc47fa69f8a5cf27b2bba7e34293e
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
2016-08-02 14:20:21 +00:00
Sachin
734d291c2e VPP: Fixed dpdk-16.07 BAD checksum error
- Updated tarball name and checksum value

Change-Id: If06581285e506859bd1edb516b690e963c7de5d0
Signed-off-by: Sachin <sachin.saxena@nxp.com>
2016-08-02 11:35:48 +05:30
Dave Barach
6f9bca2194 VPP-226 IPv4 src-address + port range checker
Change-Id: Ia251e9d7d53e894a5666109f69e9626d27ea74cb
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-08-01 18:16:24 -07:00
Florin Coras
f7643fd9e1 Fix new LISP Coverity warnings
Change-Id: I60ef5218110e596f77d11e3949284a7a7af7dedb
Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-08-01 17:21:17 +00:00
Jan
cb34a1fb3b Update CSIT test 160727 -> 160731
- update of CSIT operational branch to be user for VPP-patch test

Change-Id: I4c5200fbf0fcdc2f8fef2913a9b9a5981a6ecec1
Signed-off-by: Jan <jgelety@cisco.com>
2016-08-01 17:41:41 +02:00
Marek Gradzki
b6737a10ac Jvpp: add handling for mising unsigned array types
Change-Id: I239082622ceabdd1d0a7b6b6489a2789096a01fc
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-08-01 07:41:16 +02:00
Florin Coras
1a1adc7121 Initial L2 LISP support
This introduces support for layer 2 overlays with LISP. Similarly to L3,
all tenant packets to be encapsulated are captured by an interface, but
the mapping (layer binding) instead of being between an L3 VRF and a
LISP VNI, it is between and an L2 bridge domain and a VNI. At a high
level, this results in two important properties:
1) the source and destinations of all packets flooded in the
   bridge-domain are mapped via the LISP control plane and the replies are
   converted into data-plane tunnels tracked via a LISP specific
   source/dest L2 FIB
2) All packets reaching the interface and matching a source/dest L2 LISP
   FIB entry are L3 (IP4/6) encapsulated.

This is solely a unicast feature, therefore at this time ARPs are not
handled in any special way.

Change-Id: I0b7badcd7c6d5166db07d4acd2cc4ae7fba3e18e
Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-07-31 15:52:42 +02:00
Keith Burns (alagalah)
d038dbf4aa Addition of u16[] to JVPP generator
Change-Id: I8d746cfae4d64ae200ff0053de23b80ee951c290
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-07-30 11:43:14 -07:00
Dave Barach
a4525d5d8f VPP-189: Fix another batch of coverity warnings
Change-Id: I2b13894cca950ddb6732714f3acc180443552b5f
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-30 11:01:37 -04:00
Damjan Marion
8719fc4968 Remove per-worker destination frame queue
This frame queue is not part of the dpdk code anymore,
so it can be removed. It will save some space in the
1st cacelineof dpdk device data struct.

Change-Id: If839861961548750601400a511a609be7ae84b30
Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-30 13:09:58 +00:00
Shesha Sreenivasamurthy
819e0f4845 enic: fix bug introduced with scatter rx
Author: Nelson Escobar <neescoba@cisco.com>
    Date:   Mon Jun 13 17:24:41 2016 -0700

    We did not properly set the rq pointers we pass up to dpdk when
    rx scatter was introduced.  This resulted in segfaults whenever
    more than one rq was being used.

Change-Id: I77a9793ea9035baa1ada77d3af7bc83baf58d097
Signed-off-by: Shesha Sreenivasamurthy <shesha@cisco.com>
2016-07-29 14:35:33 -07:00
Andrej Kozemcak
ae2d252039 LISP - fix bug in ip_prefix_normalize_ip6
- fix bug
- refactoring code

Change-Id: I2c330f3fbdead567b65c889cfffc2562d99b61db
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-29 16:07:05 +02:00
Michael Qiu
c11ce3ee25 plugins/vcgn-plugin: Fix vpp hang with pthread spinlock
Currently, pthread spinlock is initialized in macro ASSERT, thus
the spinlock only will be initialized when CLIB_ASSERT_ENABLE is true.
But CLIB_ASSERT_ENABLE depends on CLIB_DEBUG been set.

Mostly, CLIB_DEBUG is zero, so spinlock will never been initialized,
which will lead vpp hang when try to hold the lock.

This patch fix this issue.

Change-Id: If01982b5df849834ccbc705f8e9291f2b6c32d0a
Signed-off-by: Michael Qiu <qiudayu@chinac.com>
2016-07-29 13:01:38 +00:00
Michael Qiu
2828efcfb9 plugin/vcgn:Remove local defined ip4_interface_first_address
Function ip4_interface_first_address has been defined in
vnet/ip/ip4.h, and result an compile issue.

  CC       vcgn/cnat_ipv4_icmp_error_outside_input.lo
  CC       vcgn/cnat_logging.lo
vcgn/cnat_logging.c:361:1: error: conflicting types for 'ip4_interface_first_address'
 ip4_interface_first_address (ip4_main_t * im, u32 sw_if_index)
 ^
In file included from /usr/include/vnet/ip/ip.h:57:0,
                 from vcgn/cnat_logging.c:24:
/usr/include/vnet/ip/ip4.h:390:1: note: previous declaration of 'ip4_interface_first_address' was here
 ip4_interface_first_address (ip4_main_t * im, u32 sw_if_index,
 ^
make: *** [vcgn/cnat_logging.lo] Error 1

Change-Id: I1165c9bb778263c195ed34ab438dcb27dfd207bc
Signed-off-by: Michael Qiu <qiudayu@chinac.com>
2016-07-29 13:01:37 +00:00
John Lo
a2f27af214 VPP-142 Follow up fix for shared_count of indirect adjacencies
Clean up dead code path added in previous attempt.

Change-Id: Ib95b07bfd7699496f6808da97200993e2104d796
Signed-off-by: John Lo <loj@cisco.com>
2016-07-29 00:25:55 +00:00
Dave Barach
16ad6ae79f VPP-189 More coverity bug fixes
Change-Id: I6e9290b26b1e74fc5652b689c8d5cc2972ac11d5
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-28 18:41:31 -04:00
Dave Barach
dd3a57f36e VPP-223 Bounded-index extensible hash documentation
Change-Id: If162252062014dbd8ef44f7f10649d54d9a288b0
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-28 13:02:37 -04:00
Pierre Pfister
4c3f39353d Add IP adjacency registration function
Given that it is possible and easy to add dynamic
IP adjacencies, it might be helpful to have an explicit
call to do so.
This way, additional information such as how to display
the adjacency can be provided at the same time.

Change-Id: I5c735ae45ed763560352f637e3462f2931dc97d9
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-07-28 12:19:21 +00:00
Andrej Kozemcak
6cc6f9175c Edit eid table dump
- change output from eid table
- add eid filter:
	all - dump all eid
	local - dump local eid
	remote - dump remote eid

Change-Id: Ifaaad8abf44cf70c4c22d05252e501456f1f1083
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-28 11:55:27 +00:00
Andrej Kozemcak
438109d576 LISP - Bug fix, can`t remove static remote mapping
Fix bug, can`t remove static remote mapping,
small update in LISP remote mapping API.

Change-Id: Ide32485a1a0d2cf08829d544500fa2755214b8cc
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-28 10:52:34 +00:00
Andrej Kozemcak
d983118bf6 Edit Lisp locator_set API
Change the output format of lisp locator_set API.
Create new API for lisp locator.
Change lisp_enable_disable_status_dump -> show_lisp_status, not use dump
function.

Change-Id: Ie2024cbf5e55b22ba077266220bf8584d5cac07a
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-28 10:40:56 +00:00
Andrej Kozemcak
5b43fd45b3 VPE_API small fix for LISP locator_set
- add documentation
- use new feature in vpe_api

Change-Id: I2708383aa886494d948feea1869c3fabae94c7bf
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-28 10:03:20 +00:00
Andrej Kozemcak
829c51a2f5 Update CSIT test 160710 -> 160727
Change-Id: Ia6e4e951a409a3b8caef16bb62d9969ae030b667
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-28 09:28:32 +02:00
root
dd9f133176 VPP-210: Clearer error codes in vlib-api for API trace save
Change-Id: Ic02eaaaa8cf7a0f1c75eca8e3b87956d5e9045e7
Signed-off-by: root <calvin.ference@gmail.com>
2016-07-27 22:12:23 +00:00
Dave Barach
b2a6e25067 VPP-189 coverity warning cleanups
Change-Id: Ia4fbf4352119504e022b89d10d44a5259d94f316
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-27 11:15:44 -04:00
Pierre Pfister
5afccb2578 Vhost-User: Fix bind sockaddr length
The sockaddr length argument provided to bind was wrong.
This patch also adds an error message in the CLI when the
vhost-user add function fails.

Change-Id: Ib4466accffe49c8c3f4951ebf3a83a24529f6a5b
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-07-27 13:37:03 +00:00
Andrej Kozemcak
a8691754d2 VAT add_locator_set api support multiple locators
Change-Id: I22df3d4407bd7fdd953783f00605380a2d6fb46e
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-07-27 13:23:24 +00:00
Matus Fabian
683d3ee1b1 VPP-214: IPSec cli/api vector ck and ik initialization
Change-Id: I34e19d1feb350c47987b9764b642ef9baa000581
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-07-26 23:54:07 -07:00
Chris Luke
8e5b041f2b VPP-223 General documentation updates
Per the TWS session...

- Some simple treatment of the contents of pool.h
- Changing some \brief commands to @brief. (will do a more
  complete pass at this later.)

Change-Id: I050ee69c59c4b572ac295b5f86940b7f4c934cd9
Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-07-26 13:29:58 -04:00
Chris Luke
b52c40abf5 VPP-165 Update directory list in README
Change-Id: I7bc983860d6cc40f264e509e74b92978667324bc
Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-07-26 17:04:35 +00:00
Chris Luke
4aa76c1c16 Fix missing include dirs in doxygen
Also allow a developer to alter the directories scanned at runtime to
facilitate shorter run-times when writing documentation.

Change-Id: I2a09519661a3abe1fbc0cfc294000934852af951
Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-07-26 17:04:19 +00:00
Matus Fabian
70e6a8dd52 policer classify
JIRA: VPP-114

If the classifier finds a matching entry, it sends packet to the policer,
packet should be pre-colored for color-aware policers.

Change-Id: I10cb53b49907137769418f230df2cab577d0f3a0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-07-26 15:52:03 +00:00
Dave Barach
ac0798db35 Fix coverity warnings
Change-Id: I37131f2d814a608fe9098daff83ff395f7ce99d7
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-26 10:31:05 -04:00
Florin Coras
0f1c29c9d4 Fix Coverty warning in lisp_add_del_map_resolver_command_fn
Change-Id: I074d9e026ae42aa14caedc56287816ab64968425
Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-07-26 12:12:17 +02:00
Dave Barach
5c55e6bd04 Author: Dave Barach <dave@barachs.net>
--- log message follows this line --
Coverity: fix minor bug in test code

Change-Id: I5921874b4902fc7fe140a9b22852e7d18583e7ae
Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-25 22:47:19 +00:00