8210 Commits

Author SHA1 Message Date
Florin Coras
2f04cb9f14 tcp: fix rate samples for old acks
Type: fix

Change-Id: Ieab35bbfba81faae61b1267d8661df5195877824
Signed-off-by: Florin Coras <fcoras@cisco.com>
2020-01-03 22:24:14 +00:00
Florin Coras
1aaa891864 hsa: fix coverity warning
Type:fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I38b155f7617d002ac16943c2c031269a17f4ba73
2020-01-03 21:38:11 +00:00
Florin Coras
8d0149d74c session: fix per slice fifo prealloc
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6db37af6c2863a80d0787a98026b3b8171dad37
2020-01-03 17:39:05 +00:00
Neale Ranns
04d1a34350 fib: Add dpo FEATURE.yaml file
Type: docs

Change-Id: I9c4727db8d498d0b513157b19ad306b7aaacc222
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-01-03 14:12:47 +00:00
Klement Sekera
aa6a29f6b8 bfd: add feature.yaml
Type: docs

Change-Id: Ica2b4a9d4fe2ceaafd6d707ebe3c4a7fa0af1c07
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2020-01-03 14:00:34 +00:00
Jakub Grajciar
956819afa9 tcp: api clenup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I48f08cc657c28ad1eef50c917a560425137bb70e
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
2020-01-03 13:14:47 +00:00
Klement Sekera
99c7b395e9 lldp: add feature.yaml
Type: docs

Change-Id: I713ced931e26d5db70cd4678a9d02c5285a1a909
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2020-01-03 13:14:07 +00:00
Jakub Grajciar
58989a37d6 ip: API cleanup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I17b95bba2327049d2b99e59cea79208814a24b22
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
2020-01-03 13:13:19 +00:00
Jakub Grajciar
2c504f89c6 devices: virtio API cleanup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I38a409af770c88c1eb2c68b24abef2a5a91e1b9a
2020-01-03 11:44:17 +01:00
Jakub Grajciar
4b76c58be0 qos: api clenup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia66810293e41427c686fbf1ab9be5c8a7db4056a
2020-01-03 10:13:42 +00:00
Jakub Grajciar
3eb8f207bb mpls: api cleanup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I44633df6d189da707657fbf9f9ba49c5f3879e9f
2020-01-03 10:13:14 +00:00
Jakub Grajciar
fb27096eec vxlan-gbp: api cleanup
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I26bd57ba506165bf2dd574fa39a81adc4295d796
2020-01-03 10:12:28 +00:00
Jon Loeliger
171577e129 build: Fix Subject-line feature list extraction
Bang on sed until a better incantation appears.

Change-Id: Ib8ad0996b6325db0fe983c86dd7dc553c9d388c4
Type: fix
Fixes: 26ce6ca1fe6f524a9049444fe8d55042fd7530a6
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2020-01-03 10:11:41 +00:00
Vladimir Ratnikov
87663cdf64 map: fix ip4-map-t DF behavior
ip4_is_fragment(header)
or ip4_is_first_fragment(header) didn't changed
when packet with fragmentation needed arrives.

This patch checks DF flag and MTU with packet
length and if DF is set and length > MTU, packet
is dropped. In case if ignore_df is set, DF flag
makes no sense.

Type: fix
Fixes: d6d50cebde647f9a5ee7251a7fef977506f315d7

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I720e25167c19a0b13ac5fdfb41b12c0bbdc00d09
2020-01-03 10:11:05 +00:00
Klement Sekera
f126e746fc nat: use SVR
Remove NAT's implementation of shallow virtual reassembly with
corresponding CLIs, APIs & tests. Replace with standalone shallow
virtual reassembly provided by ipX-sv-reass* nodes.

Type: refactor
Change-Id: I7e6c7487a5a500d591f6871474a359e0993e59b6
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2020-01-03 10:10:15 +00:00
Neale Ranns
3535501b19 abf: add feature.yaml
Type: docs

Change-Id: I4959010617b0fb51652beafe6967afd556f27e92
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 05:16:38 +00:00
Florin Coras
a6b175d3db tls: add features.yaml
Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I847463fd38b9d569d2607b8a17f6d45a04b6fe09
2020-01-03 05:15:31 +00:00
Florin Coras
93e053ebe5 tcp: add FEATURE.yaml
Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I21f822b597bfa44004bf2afaaf54463cb0ae2efc
2020-01-03 05:05:25 +00:00
Neale Ranns
c9e4b3000e fib: add adjacency feature.yaml
Type: docs

Change-Id: I6cdfbae5a0eab8a69dfa2ae054945c510a3c63f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-01-03 04:40:40 +00:00
Neale Ranns
3ff2ae24ca bier: add FEATURE.yaml
Type: docs

Change-Id: I843a410b7a14c7c61e44ea38cf7cb74f40ccf853
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 04:36:33 +00:00
Neale Ranns
9abfbb2213 arp: add FEATURE.yaml
Type: docs

Change-Id: If03488de772204a984e1785c33646833f2de6e1e
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 04:32:54 +00:00
Neale Ranns
115487c40f igmp: Add feature.yaml
Type: docs

Change-Id: I8d6ab1b4fd9f059a3f4c8ba28fc9f20debfb65cb
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 04:04:41 +00:00
Neale Ranns
d4dd1f8175 l3xc: add feature.yaml
Type: docs

Change-Id: I0d939b26079e9e45fba1cbb7c8e668918c128526
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 04:01:14 +00:00
Florin Coras
f9b5dcf338 udp: add features.yaml
Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2a7d509a2aaed6dba7d821b469c6de90d487f068
2020-01-03 03:58:15 +00:00
Ole Troan
e774a8b389 nat: add feature.yaml
And add support for multiple maintainers in JSON schema.

Type: docs
Change-Id: Ice430927ceecf53526a3fdf46c075a95206bf0ac
Signed-off-by: Ole Troan <ot@cisco.com>
2020-01-03 03:57:29 +00:00
Florin Coras
8ef8f8f793 session: add feature.yaml
Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If9065b03c0cd7d567c54eda383d6297ef554d9f0
2020-01-03 03:55:35 +00:00
Florin Coras
b3f7d9ba6c vcl: add feature.yaml
Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifda0404cfc6710d7ecf21da96eb1cb92750b495f
2020-01-03 03:54:07 +00:00
Florin Coras
a2dd5e08c6 lisp: add feature.yaml
Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba2203e98c627d550021beee2ec1cfe3cb02686f
2020-01-03 03:52:51 +00:00
Neale Ranns
0ea672e36a svs: add feature.yaml
Type: docs

Change-Id: Ie75368f64201f2f6623413bc2ba015d9dc8fbc9f
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-03 01:00:03 +00:00
Neale Ranns
822d6899dd crypto-ipsecmb: Add FEATURE.yaml for all crypto engine plugins
Type: docs

Change-Id: Ia00e3167e954271c9eb7618792fd86df288d5c19
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-01-02 23:25:05 +00:00
Dave Barach
9ce3b74750 http_static: add FEATURE.yaml
Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2f9a74541183af6c10abea2c29002842ddb88815
2020-01-02 16:44:19 +00:00
Florin Coras
95cd864382 session: fix listener global endpoint lookup
Type: fix

Ensure listeners for app transport protocols are added to lookup tables
using their session endpoints instead of their transport connections,
which can override the network connection id in the transport connection.

Change-Id: I56fa3666bb1422c0799fc7143cd099751ff6e2e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
2020-01-02 16:34:33 +00:00
Dave Barach
4ed2598562 tests: configure 32 mb physmem
Absolutely nothing good happens when we force the kernel to briefly
map and then unmap 16gb as vpp starts. Effect exacerbated when
TEST_JOBS = 20...40, and so forth.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id8e3ce1763cad3a0891d5d6c8d2c1e3e610682d7
2020-01-02 16:29:19 +00:00
Benoît Ganne
15d7fd0fe0 virtio: fix checksum offload support
Checksum offload and GSO are independent. We must support checksum
offload if it has been negotiated, independently of GSO.

Ticket: VPPSUPP-47
Type: fix

Change-Id: I8cb6dd58b61714ebb2726eb4aab0d74d49fdab99
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2020-01-02 12:54:38 +00:00
Mohsin Kazmi
222b709ad9 gso: fix number of buffers required for segmentation
Type: fix

Change-Id: I73ef0ce81b2d6a799f6a6e59908ec24cc2290a2c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-01-02 12:50:19 +00:00
Paul Vinciguerra
7ade2f51ad tests: bfd - move test_poll_response to EXTENDED_TESTS
test_bfd.BFD4TestCase.test_poll_response providing
  inconsistent results is the per-patch tests.

Type: test

Change-Id: I8f1864511526fd330a7da1abfa19be3f565c683a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2020-01-02 12:49:27 +00:00
Neale Ranns
306c3080d9 ip: indent format typo fix
Type: style

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Idfcd4a363d4582ce69fac83ddc760f2dc4feed52
2020-01-01 21:55:41 +00:00
Neale Ranns
fca3c6a3aa ip-neighbor: set link-type ARP on incomplete adjacencies
Type: fix

Change-Id: I05d74da311d6a86ec4eb3df50d53ecaa9c622f50
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-12-31 03:49:56 +00:00
Florin Coras
fea813ae3d svm: broadcast on raw dequeues and full rings
Type: fix

Change-Id: I0cac9001290e7ed4e2e318ae62c56e97ec75a3db
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-12-30 19:50:38 +00:00
hanlin
9f3f18f99f vcl: hold errno when calling LDBG
Type: fix

Call trace of LDBG:
LDBG->clib_warning->_clib_error->dispatch_message->os_puts->writev
However, writev will hijacked by LDP, and then execute following code:
if ((errno = -ldp_init ()))
    return -1;
Now, errno will be set.

Because we always call LDBG just before return from ldp_accept4, listen,
and etc. So errno will be overwritted after LDBG called.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: I7a90f3a14772994f11f09650481411796e3f5630
2019-12-30 17:26:18 +00:00
Florin Coras
b7f035ff4c tcp: validate port reuse
Type: fix

Make sure existing connection is in time-wait

Change-Id: I8e8bef151f81bcd589b4da0d4bf63cc59f9f451b
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-12-27 09:27:52 -08:00
Yu Ping
b092b77cf2 tcp: Enable TCP timewait port use
Improve host stack CPS test, and it help improve 10x performance

Type: feature

Change-Id: I6af61e0bad7c16ee2d30a1422cc46bb89f1cedb4
Signed-off-by: Yu Ping <ping.yu@intel.com>
Signed-off-by: Yuwei Zhang <yuwei1.zhang@intel.com>
2019-12-27 17:17:51 +00:00
Paul Vinciguerra
a42c6ee973 tests: test_mpls_v6_ebgp_pic - don't write to stdout
Type: test

Change-Id: I2cccc68b1b4b6c576580ae0eb5d4511ca2f4663d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-12-27 00:17:01 -05:00
hanlin
475c9d7bcd vcl: EPOLLOUT should be generated when epoll_ctl called with EPOLLOUT
event

Type: fix

When we call epoll_ctl to add or mod fd with EPOLLOUT event, mostly to
check if we can write. So we expect a EPOLLOUT event should be generated
immediately unless tx queue is full.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: Ie99986a44dbb07b6ff2fba6512171056f79e77bd
2019-12-27 04:53:22 +00:00
Paul Vinciguerra
3f7b0f4a7c tests: tls - don't print skip info to stdout
Type: test

Change-Id: Id1bffbfe698113d85c4c6bf432ddf4908ed2b788
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-12-26 19:13:02 -05:00
Dave Barach
29c6132108 classify: "classify filter ..." debug CLI cleanup
The pcap trace filter initial table index lives in
cm->filter_set_by_sw_if_index [0], which corresponds to the "local0"
interface. Debug cli makes sure that folks don't accidentally specify
the "local0" interface. At least it does now...

Fix the "vlib format.c code coverage" test in test/test_vlib.py.

Type: fix
Change-Id: I35320bc2c8f0c6f1f8c12e3529d1938548185151
Signed-off-by: Dave Barach <dave@barachs.net>
2019-12-25 13:01:48 +00:00
Dave Barach
1decd98e2e unittest: test_bihash call clib_time_init(...)
Fix "Rejecting large frequency change of +infinity" errors.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I8efca1291e38c48bb98e7f8109253224a4f0a2a1
2019-12-24 15:26:05 -05:00
Paul Vinciguerra
de35cdb778 tests: fix skip logic on test_tap
log.txt message:
17:52:59,969 API call failed, expected 0 return value instead of -13 in tap_create_v2_reply(_0=58, context=77019, retval=-13, sw_if_index=4294967295)

Test was failing with log message:
  tap: tap0: tap_create_if: ioctl(TUNSETIFF): Operation not permitted

Type: test
Change-Id: I5bcd9d2b0c870ea5eef92b79314b97821399722f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-12-24 12:49:55 +00:00
Matthew Smith
5002e7f26f ip-neighbor: ip_neighbor_advertise() handles null
Type: fix
Fixes: cbe25aab3b

ip_neighbor_advertise() was calling one of both of
ip4_neighbor_advertise() and/or ip6_neighbor_advertise() with
&addr->{ip4|ip6} as an argument. If addr is null, which is likely
a requirement when the type is IP46_TYPE_BOTH, this results in a
SEGV.

Check addr and pass a pointer to one of it's members if it is not
null, otherwise pass null.

Change-Id: I6261bb8fe947365fe3d6c58788ea27d5cb28ff05
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2019-12-23 19:37:38 -06:00
Neale Ranns
4a56f4e48f ipsec: Test and fix IPSec worker hand-off
Type: fix

Change-Id: I5cb9a3845ddbc5f4de4eb4e9c481f606fe5cec9a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-12-23 21:39:23 +00:00