vpp/scripts at aaeb341086b99ae01a133fd0b56fb3f881f36e44 - vpp

ligang/vpp

History

Chris Luke aaeb341086 Simple script to 'git blame' on new Coverity issues

- Pass an email in to stdin and the script produces output similar
to:

Hi,

Please find the latest report on new defect(s) introduced to fd.io VPP
found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 167726:  Resource leaks  (RESOURCE_LEAK)
/src/vnet/devices/af_packet/device.c: 215 in
af_packet_interface_admin_up_down()

________________________________________________________________________________________________________
*** CID 167726:  Resource leaks  (RESOURCE_LEAK)
/src/vnet/devices/af_packet/device.c: 215 in
af_packet_interface_admin_up_down()
>>>     CID 167726:  Resource leaks  (RESOURCE_LEAK)
>>>     Handle variable "fd" going out of scope leaks the handle.
00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17
209)   af_packet_if_t *apif =
00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17
210)     pool_elt_at_index (apm->interfaces, hw->dev_instance);
83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel  2016-04-05
211)   u32 hw_flags;
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
212)   int rv, fd = socket (AF_UNIX, SOCK_DGRAM, 0);
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
213)   struct ifreq ifr;
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
214)
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
215)   /* if interface is a bridge ignore */
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
216)   if (apif->host_if_index < 0)
2038ad01 src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-05-18
217)     goto error;			/* no error */
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
218)
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
219)   /* use host_if_index in case host name has changed */
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
220)   ifr.ifr_ifindex = apif->host_if_index;
** CID 167725:  Error handling issues  (NEGATIVE_RETURNS)
/src/vnet/devices/af_packet/device.c: 252 in
af_packet_interface_admin_up_down()

________________________________________________________________________________________________________
*** CID 167725:  Error handling issues  (NEGATIVE_RETURNS)
/src/vnet/devices/af_packet/device.c: 252 in
af_packet_interface_admin_up_down()
>>>     CID 167725:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "fd" is passed to a parameter that cannot be negative.
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
246)     }
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
247)
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
248)   if ((rv = ioctl (fd, SIOCSIFFLAGS, &ifr)) < 0)
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
249)     {
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
250)       clib_unix_warning ("af_packet_%s error: %d",
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
251) 			 apif->is_admin_up ? "up" : "down", rv);
2038ad01 src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-05-18
252)       goto error;
c855b73f src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-04-21
253)     }
83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel  2016-04-05
254)
00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17
255)   vnet_hw_interface_set_flags (vnm, hw_if_index, hw_flags);
83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel  2016-04-05
256)
2038ad01 src/vnet/devices/af_packet/device.c  (Ray Kinsella  2017-05-18
257) error:

Change-Id: I9756c16ea24e7520704155ae1f6c5f132087e3bc
Signed-off-by: Chris Luke <chrisy@flirble.org>

2017-05-24 07:39:43 +00:00

checkstyle.sh

Move emacs stuff to extras/

2017-04-24 14:49:00 +00:00

coverity-blame.sh

Simple script to 'git blame' on new Coverity issues

2017-05-24 07:39:43 +00:00

coverity-build.sh

Prep work for Coverity upload processing via Jenkins

2017-01-31 20:40:11 +00:00

csit-test-branch

Update CSIT tests 170504 -> 170518