lunny/changelog
1
0
Fork 2
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Changelog Overhaul 2 #19

Merged
jolheiser merged 25 commits from refs/pull/19/head into master 2020-01-24 16:30:19 +00:00
Conversation 9 Commits 25 Files Changed 18 +663 -239
jolheiser commented 2020-01-13 21:31:16 +00:00 (Migrated from gitea.com)
Copy Link

Resolves #4
Continues #6
Resolves #15
Resolves #25

This PR:

  • Branches out services (GitHub and Gitea)
  • Allows users to pass in a token (for private repos/instances)
  • Allows users to generate a details list
  • Allows users to filter out PRs based on minimum index
Resolves #4 Continues #6 Resolves #15 Resolves #25 This PR: * Branches out services (GitHub and Gitea) * Allows users to pass in a token (for private repos/instances) * Allows users to generate a details list * Allows users to filter out PRs based on minimum index
6543 commented 2020-01-17 06:24:42 +00:00 (Migrated from gitea.com)
Copy Link

@jolheiser fix is merged

@jolheiser fix is merged
jolheiser commented 2020-01-17 18:19:14 +00:00 (Migrated from gitea.com)
Copy Link

This is ready for review, with one more caveat. Currently the SDK doesn't allow us to search milestones by anything other than open state, so this tool can only find open milestones until that is fixed.

This is ready for review, with one more caveat. Currently the SDK doesn't allow us to search milestones by anything other than `open` state, so this tool can only find open milestones until that is fixed.
6543 commented 2020-01-17 19:02:30 +00:00 (Migrated from gitea.com)
Copy Link

what !?! - I'll look at this!

what !?! - I'll look at this!
6543 commented 2020-01-17 19:58:32 +00:00 (Migrated from gitea.com)
Copy Link

@jolheiser for milestones -> https://gitea.com/gitea/go-sdk/issues/230

@jolheiser for milestones -> https://gitea.com/gitea/go-sdk/issues/230
6543 (Migrated from gitea.com) reviewed 2020-01-22 23:42:28 +00:00
guillep2k (Migrated from gitea.com) reviewed 2020-01-23 02:42:02 +00:00
6543 (Migrated from gitea.com) approved these changes 2020-01-23 02:49:43 +00:00
lunny (Migrated from gitea.com) reviewed 2020-01-23 02:50:23 +00:00
lunny (Migrated from gitea.com) reviewed 2020-01-23 02:51:05 +00:00
6543 (Migrated from gitea.com) reviewed 2020-01-23 02:53:13 +00:00
6543 (Migrated from gitea.com) reviewed 2020-01-23 02:53:34 +00:00
6543 (Migrated from gitea.com) reviewed 2020-01-23 02:54:07 +00:00
6543 (Migrated from gitea.com) reviewed 2020-01-23 02:54:17 +00:00
jolheiser commented 2020-01-23 04:16:09 +00:00 (Migrated from gitea.com)
Copy Link

All copyrights should be updated, except the example config because I don't think there's any reason to?

All copyrights should be updated, except the example config because I don't think there's any reason to?
👍 1
guillep2k (Migrated from gitea.com) approved these changes 2020-01-23 07:09:13 +00:00
6543 (Migrated from gitea.com) approved these changes 2020-01-23 08:00:53 +00:00
6543 commented 2020-01-23 16:49:15 +00:00 (Migrated from gitea.com)
Copy Link

go test -race go: code.gitea.io/sdk/gitea@v0.0.0-20200116035226-b24cfd841cda: Get https://goproxy.cn/code.gitea.io/sdk/gitea/@v/v0.0.0-20200116035226-b24cfd841cda.mod: No such domain

???

`go test -race go: code.gitea.io/sdk/gitea@v0.0.0-20200116035226-b24cfd841cda: Get https://goproxy.cn/code.gitea.io/sdk/gitea/@v/v0.0.0-20200116035226-b24cfd841cda.mod: No such domain` ???
6543 commented 2020-01-23 17:03:59 +00:00 (Migrated from gitea.com)
Copy Link

@jolheiser tested my fix with your PR: https://drone.gitea.com/gitea/changelog/9/1/2

works :)

fix is here: #26

@jolheiser tested my fix with your PR: https://drone.gitea.com/gitea/changelog/9/1/2 works :) fix is here: #26
jolheiser commented 2020-01-23 17:28:36 +00:00 (Migrated from gitea.com)
Copy Link

@6543 It worked with my latest push. It's sometimes just a luck thing.

@6543 It worked with my latest push. It's sometimes just a luck thing.
6543 commented 2020-01-23 17:43:29 +00:00 (Migrated from gitea.com)
Copy Link

@jolheiser I thin #26 is still a Improvement

@jolheiser I thin #26 is still a Improvement
guillep2k (Migrated from gitea.com) approved these changes 2020-01-23 18:37:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
guillep2k
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
lgtm/done

   
lgtm/need 1

   
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm/done
lgtm/need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/changelog#19
No description provided.
Delete Branch "refs/pull/19/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?