ssh: redirect stdin from /dev/null

When using SSH cloning with a ControlMaster socket and a password on a
Unix system, we're unable to read from standard input and consequently
the SSH process fails. The redirect from standard input was intended to
fix an issue on Windows that is due to /dev/tty disappearing, but it
doesn't appear to work and causes issues on Unix systems. Revert this
change so we can explore other options.

This reverts commit 59ed04855afd7e8f1bb126eb6f6a5c5297f59253.
This commit is contained in:
brian m. carlson 2019-07-19 13:55:14 +00:00
parent e31a1e0a02
commit 296311634c
No known key found for this signature in database
GPG Key ID: 2D0C9BC12F82B3A1

@ -4,7 +4,6 @@ import (
"bytes"
"encoding/json"
"fmt"
"os"
"os/exec"
"path/filepath"
"regexp"
@ -88,7 +87,6 @@ func (c *sshAuthClient) Resolve(e Endpoint, method string) (sshAuthResponse, err
// Save stdout and stderr in separate buffers
var outbuf, errbuf bytes.Buffer
cmd.Stdin = os.Stdin
cmd.Stdout = &outbuf
cmd.Stderr = &errbuf