lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

githistory: split out tag updates into a function

Browse Source 
In a future commit, we'll call this code multiple times, so split it out
into a function.
This commit is contained in:
brian m. carlson 2019-06-21 17:27:40 +00:00
parent 92cb839cf9
commit 5346eb49fb
No known key found for this signature in database
GPG Key ID: 2D0C9BC12F82B3A1
1 changed files with 24 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
git/githistory/ref_updater.go
View File

@ -57,6 +57,27 @@ func (r *refUpdater) UpdateRefs() error {
return nil
}
func (r *refUpdater) updateOneTag(tag *gitobj.Tag) ([]byte, error) {
toObj, okObj := r.CacheFn(tag.Object)
if !okObj {
return nil, nil
}
newTag, err := r.db.WriteTag(&gitobj.Tag{
Object: toObj,
ObjectType: tag.ObjectType,
Name: tag.Name,
Tagger: tag.Tagger,
Message: tag.Message,
})
if err != nil {
return nil, errors.Wrapf(err, "could not rewrite tag: %s", tag.Name)
}
return newTag, nil
}
func (r *refUpdater) updateOneRef(list *tasklog.ListTask, maxNameLen int, seen map[string]struct{}, ref *git.Ref) error {
sha1, err := hex.DecodeString(ref.Sha)
if err != nil {
@ -76,24 +97,10 @@ func (r *refUpdater) updateOneRef(list *tasklog.ListTask, maxNameLen int, seen m
// Assume that a non-nil error is an indication
// that the tag is bare (without annotation).
toObj, okObj := r.CacheFn(tag.Object)
if !okObj {
return nil
newTag, err := r.updateOneTag(tag)
if newTag == nil {
return err
}
newTag, err := r.db.WriteTag(&gitobj.Tag{
Object: toObj,
ObjectType: tag.ObjectType,
Name: tag.Name,
Tagger: tag.Tagger,
Message: tag.Message,
})
if err != nil {
return errors.Wrapf(err, "could not rewrite tag: %s", tag.Name)
}
to = newTag
ok = true
}