Review fixes

- Close instead of Sync since we are already done with the file
- Style: Omit return value for os.Remove()
This commit is contained in:
Jukka Lehtniemi 2016-04-05 22:34:23 +03:00
parent bfb28d25a1
commit ec586945c4

@ -335,7 +335,7 @@ func CopyFileContents(src string, dst string) error {
}
defer func() {
tmp.Close()
_ = os.Remove(tmp.Name())
os.Remove(tmp.Name())
}()
in, err := os.Open(src)
if err != nil {
@ -346,7 +346,7 @@ func CopyFileContents(src string, dst string) error {
if err != nil {
return err
}
err = tmp.Sync()
err = tmp.Close()
if err != nil {
return err
}