[Feature request] Define admin username and passowrd using kubernetes secret, not directly in values #169

Closed
opened 2021-06-08 12:00:58 +00:00 by lord-kyron · 5 comments
lord-kyron commented 2021-06-08 12:00:58 +00:00 (Migrated from gitea.com)

Hi all,
I think in cases (like mine) when using FluxCD with Helm Operator and my helm values files are sitting in git repo, having the admin username and pass configured there is really insecure. That is why I think that it will be best if you guys make support for admin username and password to come from existing secret in kubernetes.
That way we can use the sealed secrets extension to encode the username and password in the git repo and this chart to take it from the created kubernets secret directly instead of hardcoding them in plain text!

Thanks!

Hi all, I think in cases (like mine) when using FluxCD with Helm Operator and my helm values files are sitting in git repo, having the admin username and pass configured there is really insecure. That is why I think that it will be best if you guys make support for admin username and password to come from existing secret in kubernetes. That way we can use the sealed secrets extension to encode the username and password in the git repo and this chart to take it from the created kubernets secret directly instead of hardcoding them in plain text! Thanks!
luhahn commented 2021-06-08 14:08:37 +00:00 (Migrated from gitea.com)

True, there was some similiar request to this one. Haven't had time but I might have a nice idea in how to include it. Will try and prepare a PR for this :)

True, there was some similiar request to this one. Haven't had time but I might have a nice idea in how to include it. Will try and prepare a PR for this :)
luhahn commented 2021-06-08 15:44:28 +00:00 (Migrated from gitea.com)

Done, feel free to test this :) #170

Done, feel free to test this :) #170
lord-kyron commented 2021-06-08 16:27:10 +00:00 (Migrated from gitea.com)

Seems working fine! Thank you for the quick reaction!

Seems working fine! Thank you for the quick reaction!
lord-kyron commented 2021-06-09 13:58:33 +00:00 (Migrated from gitea.com)

When can we expect this to be merged to master branch?

When can we expect this to be merged to master branch?
luhahn commented 2021-06-10 11:26:01 +00:00 (Migrated from gitea.com)

@lord-kyron just released 3.1.4 containing the update

@lord-kyron just released 3.1.4 containing the update
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#169
No description provided.