lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Allow existing secrets for passwords #170

Merged
luhahn merged 1 commits from refs/pull/170/head into master 2021-06-10 11:13:33 +00:00
Conversation 9 Commits 1 Files Changed 2
+41 -2
luhahn commented 2021-06-08 15:43:50 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Allow admin user and password to be configured via existing secrets

Allow LDAP bindDn and bindPassword to be configured via existing secrets

Update Readme

Fixes: #169

Allow admin user and password to be configured via existing secrets Allow LDAP bindDn and bindPassword to be configured via existing secrets Update Readme Fixes: #169
luhahn commented 2021-06-08 15:44:39 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Tested on my cluster

Tested on my cluster
lord-kyron commented 2021-06-08 15:57:48 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Tested on my cluster too.
Seems working fine!
Thank you!

Tested on my cluster too. Seems working fine! Thank you!
techknowlogick (Migrated from gitea.com) approved these changes 2021-06-08 17:04:01 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2021-06-09 14:00:57 +00:00
luhahn commented 2021-06-09 14:57:09 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Fixed another bug and updated the branch with the current master

Fixed another bug and updated the branch with the current master
lord-kyron commented 2021-06-10 07:42:18 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@luhahn shouldn't you approve this also?

@luhahn shouldn't you approve this also?
luhahn commented 2021-06-10 09:27:16 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

@luhahn shouldn't you approve this also?

You can't approve your own PRs :)

> @luhahn shouldn't you approve this also? You can't approve your own PRs :)
lunny (Migrated from gitea.com) approved these changes 2021-06-10 11:12:57 +00:00
viceice commented 2021-06-15 17:05:31 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

This pr is again a breaking change for existing users ? see #179

This pr is again a breaking change for existing users ? see #179
Sign in to join this conversation.
Reviewers
No Reviewers
techknowlogick
lunny
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
lunny (Lunny Xiao)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#170