lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix admin + ldap configuration #183

Merged
justusbunsi merged 1 commits from refs/pull/183/head into master 2021-06-21 13:28:19 +00:00
Conversation 4 Commits 1 Files Changed 1 +2 -2
justusbunsi commented 2021-06-16 20:10:06 +00:00 (Migrated from gitea.com)
Copy Link

This fixes several flaws introduced by commits for #169 (see c49dc047a4).

  • Respect kebab-case ldap bind inline definition
  • Prevent camelCase ldap bind inline definition from being overridden by empty string
  • Create admin account when existingSecret is used
This fixes several flaws introduced by commits for #169 (see c49dc047a498973920e6743fa6c330fd2f81dd47). - Respect kebab-case ldap bind inline definition - Prevent camelCase ldap bind inline definition from being overridden by empty string - Create admin account when `existingSecret` is used
zeripath (Migrated from gitea.com) approved these changes 2021-06-16 20:27:18 +00:00
luhahn (Migrated from gitea.com) reviewed 2021-06-17 09:38:20 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Just a small issue here, the rest seems okay

Just a small issue here, the rest seems okay
luhahn (Migrated from gitea.com) approved these changes 2021-06-17 09:40:59 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Nevermind, i should not review after getting the covid vaccine. Im dizzy, sorry:D

Nevermind, i should not review after getting the covid vaccine. Im dizzy, sorry:D
luhahn commented 2021-06-21 09:58:33 +00:00 (Migrated from gitea.com)
Copy Link

Just tested this and it works fine. However the next release needs to be 3.2.0 because of the database updates.

Just tested this and it works fine. However the next release needs to be 3.2.0 because of the database updates.
Sign in to join this conversation.
Reviewers
No Reviewers
zeripath
luhahn
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#183
No description provided.
Delete Branch "refs/pull/183/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?