lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Drop custom probes #248

Merged
justusbunsi merged 1 commits from refs/pull/248/head into master 2021-12-13 08:50:09 +00:00
Conversation 3 Commits 1 Files Changed 3 +61 -69
justusbunsi commented 2021-11-16 19:33:44 +00:00 (Migrated from gitea.com)
Copy Link

As a replacement, the default probes are now fully configurable and used
as-is during Chart deployment.

Fixes: #189

⚠️ BREAKING ⚠️

Users have to remove the custom prefix from their probes, if customized.

As a replacement, the default probes are now fully configurable and used as-is during Chart deployment. Fixes: #189 ⚠️ BREAKING ⚠️ --- Users have to remove the `custom` prefix from their probes, if customized.
luhahn (Migrated from gitea.com) reviewed 2021-11-17 14:27:49 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

just a small typo

just a small typo
luhahn (Migrated from gitea.com) approved these changes 2021-11-18 10:35:10 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Looks good to me, also tested the changes :)

Looks good to me, also tested the changes :)
zeripath (Migrated from gitea.com) approved these changes 2021-12-04 11:11:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
zeripath
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/breaking
kind/enhancement
Milestone
No items
No Milestone 5.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#248
No description provided.
Delete Branch "refs/pull/248/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?