Remove mysql and mariadb chart deps #417
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: lunny/helm-chart#417
Reference in New Issue
Block a user
No description provided.
Delete Branch "refs/pull/417/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As discussed in Discord.
Supersedes #412 and #407.
⚠️ BREAKING
Users depending on the built-in MySQL or MariaDB chart have to switch to an self-managed database, or Postgres
Besides the commented parts, L-G-T-M.
@ -892,1 +601,4 @@| `global.hostAliases` | global hostAliases which will be added to the pod's hosts files | `[]` || `replicaCount` | number of replicas for the statefulset | `1` || `clusterDomain` | cluster domain | `cluster.local` |I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.
@ -407,3 +236,3 @@Any external database listed in [https://docs.gitea.com/installation/database-prep](https://docs.gitea.com/installation/database-prep) can be used instead of the built-in PostgreSQL.Any external Database listed in [https://docs.gitea.io/en-us/database-prep/](https://docs.gitea.io/en-us/database-prep/) can be used instead of the built-in PostgreSQL.In fact, it is **highly recommended** to use an external database to ensure a stable Gitea installation longterm.While I agree with the recommendation to use an external database for a longterm stable Gitea installation, I don't agree that the built-in dependency is mainly for testing an development purposes. If that would be the case, we wouldn't release the dependency but instead have it located somewhere in a
testingfolder or similar to boostrap the dev environment with it.If users decide to rely on the built-in database, they can do so by accepting all the changes we make - e.g. updating. That is totally fine in my opinion.
@ -1385,3 +851,3 @@<summary>To 5.0.0</summary>### To 5.0.0> 💥 The Helm Chart now requires Gitea versions of at least 1.11.0.I don't think we should remove MySQL and MariaDB from older changelog entries. In those versions they are still valid.
@ -892,1 +601,4 @@| `global.hostAliases` | global hostAliases which will be added to the pod's hosts files | `[]` || `replicaCount` | number of replicas for the statefulset | `1` || `clusterDomain` | cluster domain | `cluster.local` |Agreed!
@ -407,3 +236,3 @@Any external database listed in [https://docs.gitea.com/installation/database-prep](https://docs.gitea.com/installation/database-prep) can be used instead of the built-in PostgreSQL.Any external Database listed in [https://docs.gitea.io/en-us/database-prep/](https://docs.gitea.io/en-us/database-prep/) can be used instead of the built-in PostgreSQL.In fact, it is **highly recommended** to use an external database to ensure a stable Gitea installation longterm.Fair point! I removed the respective sentence.
LGTM