Update mysql chart from 6.x to 9.x #412
Reference in New Issue
Block a user
No description provided.
Delete Branch "refs/pull/412/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In line with #391 and #407
Please see my comments below.
@ -2,0 +4,4 @@
version: 6.3.7
- name: mysql
repository: oci://registry-1.docker.io/bitnamicharts
version: 9.5.2
Current version would be 9.7.0. Sorry for the delay. :D
@ -456,3 +280,3 @@
# existingSecret: gitea-admin-secret
#existingSecret: gitea-admin-secret
existingSecret:
username: gitea_admin
Based on version 6.14.10, this persistence override was never applied. It should've been
master.persistence.size
andslave.persistence.size
. Since it was never applied the default 8Gi are used.Specifying
primary.persistence.size
andsecondary.persistence.size
as 10Gi will change the size of the allocated storage. But since the Chart also changes their default (master+slave) to only one primary instance as default installation, they also use a different PVC name and everything must be migrated. So I am not fully sure if this is an actual breaking. But definitely noteworthy, I'd say.@ -692,0 +447,4 @@
## @param mysql.secondary.persistence.size Enable persistence on MySQL secondary replicas using a `PersistentVolumeClaim`
mysql:
enabled: false
auth:
The current drone build seems to only render the Chart template for Postgres, which is enabled by default.
Running
helm template --set postgresql.enabled=false --set mysql.enabled=true gitea ./
on this branch causes an error:A unittest like below would for each DB type identifies rendering issues immediately, so we don't need an explicit
helm template
at all. But that is something for #409.@ -692,0 +454,4 @@
password: gitea
service:
ports:
mysql: 3306
mysql.service.ports.mysql
must bemysql.primary.service.ports.mysql
and secondary respectively. And the helpers.tpl files must be updated as well. Otherwise, the database configuration for app.ini would now renderHOST=gitea-mysql.default.svc.cluster.local:%!g(<nil>)
instead ofHOST=gitea-mysql.default.svc.cluster.local:3306
.Closed in favor of #417.
Pull request closed