Further improvement on DRY principle support #529

2023-10-10T13:17:41Z

Ceddaerrix commented

2023-10-10 13:17:41 +00:00

(Migrated from gitea.com)

Description of the change

Adding TPL use into './templates/_helpers.tpl' in "gitea.inline_configuration.defaults.server" since '.Values.ingress.hosts' referred

Benefits

Avoid error in deployment using Gitea CHart 9.5.0 such as "Invalid ROOT_URL 'https://{{ .Values.global.giteaHostName }}': parse "https://{{ .Values.global.giteaHostName }}": invalid character "{" in host name"

Possible drawbacks

N/A

Applicable issues

fixes #530

Checklist

Fixing './templates/_helpers.tpl' "gitea.inline_configuration.defaults.server
Templating unittests are added

### Description of the change - Adding TPL use into './templates/_helpers.tpl' in "gitea.inline_configuration.defaults.server" since '.Values.ingress.hosts' referred ### Benefits - Avoid error in deployment using Gitea CHart 9.5.0 such as "Invalid ROOT_URL 'https://{{ .Values.global.giteaHostName }}': parse "https://{{ .Values.global.giteaHostName }}": invalid character "{" in host name" ### Possible drawbacks N/A ### Applicable issues - fixes #530 ### Checklist - [x] Fixing './templates/_helpers.tpl' "gitea.inline_configuration.defaults.server - [x] Templating unittests are added

pat-s (Migrated from gitea.com) reviewed 2023-10-10 14:44:12 +00:00

justusbunsi (Migrated from gitea.com) reviewed 2023-10-10 14:44:26 +00:00

Ceddaerrix commented

2023-10-10 14:49:22 +00:00

(Migrated from gitea.com)

@justusbunsi, @pat-s,

There is an issue the check-and-test workflow. It stops after 'Starting container'.
Is anyone looking into it?

@justusbunsi, @pat-s, There is an issue the _check-and-test_ workflow. It stops after 'Starting container'. Is anyone looking into it?

Ceddaerrix commented

2023-10-10 14:53:37 +00:00

(Migrated from gitea.com)

@justusbunsi, @pat-s,

There is an issue the check-and-test workflow. It stops after 'Starting container'.
Is anyone looking into it?

After merging the main branch changes onto this, now the check-and-test workflow fails during the dependency update stage:

Downloading postgresql from repo oci://registry-1.docker.io/bitnamicharts
Save error occurred:  could not download oci://registry-1.docker.io/bitnamicharts/postgresql: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Abitnamicharts%2Fpostgresql%3Apull&service=registry.docker.io: 401 Unauthorized
Error: could not download oci://registry-1.docker.io/bitnamicharts/postgresql: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Abitnamicharts%2Fpostgresql%3Apull&service=registry.docker.io: 401 Unauthorized

> @justusbunsi, @pat-s, > > There is an issue the _check-and-test_ workflow. It stops after 'Starting container'. > Is anyone looking into it? After merging the main branch changes onto this, now the _check-and-test_ workflow fails during the _dependency update_ stage: ``` Downloading postgresql from repo oci://registry-1.docker.io/bitnamicharts Save error occurred: could not download oci://registry-1.docker.io/bitnamicharts/postgresql: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Abitnamicharts%2Fpostgresql%3Apull&service=registry.docker.io: 401 Unauthorized Error: could not download oci://registry-1.docker.io/bitnamicharts/postgresql: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://auth.docker.io/token?scope=repository%3Abitnamicharts%2Fpostgresql%3Apull&service=registry.docker.io: 401 Unauthorized ```

pat-s commented

2023-10-10 14:56:28 +00:00

(Migrated from gitea.com)

After merging the main branch changes onto this, now the check-and-test workflow fails during the dependency update stage:

All PRs currently fail until #526

On a different note: The PR seems to replace helpers.tpl entirely - could you check what's causing this? A "clean" diff would be better.

> After merging the main branch changes onto this, now the check-and-test workflow fails during the dependency update stage: All PRs currently fail until #526 On a different note: The PR seems to replace `helpers.tpl` entirely - could you check what's causing this? A "clean" diff would be better.

Ceddaerrix commented

2023-10-11 05:57:03 +00:00

(Migrated from gitea.com)

After merging the main branch changes onto this, now the check-and-test workflow fails during the dependency update stage:

All PRs currently fail until #526

On a different note: The PR seems to replace helpers.tpl entirely - could you check what's causing this? A "clean" diff would be better.

I assume that it was due to the fact that my fork was initially out of sync until the revision 3297d86e94.
I just compared the helpers.tpl from main and the one from my fork and the only difference is my change at line 322

> > After merging the main branch changes onto this, now the check-and-test workflow fails during the dependency update stage: > > All PRs currently fail until #526 > > On a different note: The PR seems to replace `helpers.tpl` entirely - could you check what's causing this? A "clean" diff would be better. I assume that it was due to the fact that my fork was initially out of sync until the revision 3297d86e94778c50b25aadc03aa6894bb4d65e4e. I just compared the `helpers.tpl` from main and the one from my fork and the only difference is my change at line [322](https://gitea.com/gitea/helm-chart/src/commit/c50e719ad3c200fff62d52f483ea5cc4a591fc3d/templates/_helpers.tpl#L322)

Ceddaerrix commented

2023-10-11 06:07:00 +00:00

(Migrated from gitea.com)

All PRs currently fail until #526

From what I see PR #528 fails at stage install toolss as this PR.
Could there be an issue with the underlying "infrastructure"?

> All PRs currently fail until #526 From what I see PR #528 fails at stage `install tools`s as this PR. Could there be an issue with the underlying "infrastructure"?

pat-s commented

2023-10-11 08:35:22 +00:00

(Migrated from gitea.com)

The diff is not on point. I'd suggest a hard reset and adding the change again. We cannot merge it in it's current state.

We're working on the CI issues, please have patience :)

The diff is not on point. I'd suggest a hard reset and adding the change again. We cannot merge it in it's current state. We're working on the CI issues, please have patience :)

pat-s commented

2023-10-12 09:19:38 +00:00

(Migrated from gitea.com)

@Ceddaerrix The diff issue is likely due to whitespace/EOL changes

justusbunsi commented

2023-10-13 16:09:02 +00:00

(Migrated from gitea.com)

The recent failing build is due to test errors. @Ceddaerrix please have a look.

justusbunsi (Migrated from gitea.com) reviewed 2023-10-13 18:02:33 +00:00

unittests/deployment/inline-config.yaml

justusbunsi (Migrated from gitea.com) commented

2023-10-13 18:02:33 +00:00

Using matchRegex with the correct content will work.

https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md#assertion-types

And please also check SSH_DOMAIN string.

Using `matchRegex` with the correct content will work. https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md#assertion-types And please also check `SSH_DOMAIN` string.

justusbunsi (Migrated from gitea.com) commented

2023-10-27 15:39:47 +00:00

Thanks for the input. I will have a look into it.

unittests/deployment/inline-config.yaml

justusbunsi (Migrated from gitea.com) commented

2023-10-13 18:02:38 +00:00

Using matchRegex with the correct content will work.

https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md#assertion-types

And please also check SSH_DOMAIN string.

Using `matchRegex` with the correct content will work. https://github.com/helm-unittest/helm-unittest/blob/main/DOCUMENT.md#assertion-types And please also check `SSH_DOMAIN` string.

justusbunsi (Migrated from gitea.com) commented

2023-10-27 15:39:55 +00:00

Thanks for the input. I will have a look into it.