Fix helm dependency build once and for all #535

2023-10-13T15:39:18Z

justusbunsi commented

2023-10-13 15:39:18 +00:00

(Migrated from gitea.com)

Description of the change

We are affected by a regression of a Helm bug from May 2023. I've tested
the Helm versions 3.13.1, 3.13.0 and 3.12.3. Both 3.13.x are affected.
3.12.3 works. So let's downgrade and drop the docker login in PR builds.

I've also switched the apt install helm with an official alpine/helm
image I am using at work. Pinning the helm version and receiving updates
helps us identifying such issues in the future.

For the release workflow I was a bit more reluctant with changes, since
I cannot easily test them. That's why I just pinned the Helm version.

Renovate will provide one PR changing both files because it's the same
dependency (alpine/helm) from the same datasource (docker).

https://github.com/helm/helm/issues/12062

Applicable issues

implicitly fixes #527
dropping changes from #526

### Description of the change We are affected by a regression of a Helm bug from May 2023. I've tested the Helm versions 3.13.1, 3.13.0 and 3.12.3. Both 3.13.x are affected. 3.12.3 works. So let's downgrade and drop the docker login in PR builds. I've also switched the `apt install helm` with an official `alpine/helm` image I am using at work. Pinning the helm version and receiving updates helps us identifying such issues in the future. For the release workflow I was a bit more reluctant with changes, since I cannot easily test them. That's why I just pinned the Helm version. Renovate will provide one PR changing both files because it's the same dependency (alpine/helm) from the same datasource (docker). https://github.com/helm/helm/issues/12062 ### Applicable issues - implicitly fixes #527 - dropping changes from #526

pat-s (Migrated from gitea.com) reviewed 2023-10-13 15:58:05 +00:00

pat-s (Migrated from gitea.com) left a comment

Ah awesome! So it was not about rate limiting at all...

I was anyhow a bit confused since it worked initially and then stopped at some point.

Happy to use containers instead of host commands.

Ah awesome! So it was not about rate limiting at all... I was anyhow a bit confused since it worked initially and then stopped at some point. Happy to use containers instead of host commands.

.gitea/workflows/test-pr.yml

pat-s (Migrated from gitea.com) commented

2023-10-13 15:58:05 +00:00

alpine/helm is missing npm for running the checkout step.
I think it requires a step before the checkout step which runs apk add --update npm?

`alpine/helm` is missing npm for running the `checkout` step. I think it requires a step before the `checkout` step which runs `apk add --update npm`?

pat-s (Migrated from gitea.com) commented

2023-10-13 16:02:00 +00:00

Yep, already added.

justusbunsi commented

2023-10-13 16:02:20 +00:00

(Migrated from gitea.com)

@pat-s Build succeeds now.

pat-s (Migrated from gitea.com) reviewed 2023-10-13 16:02:52 +00:00

justusbunsi commented

2023-10-13 16:03:58 +00:00

(Migrated from gitea.com)

I've verified that the renovate.json5 change does what it should.

pat-s (Migrated from gitea.com) approved these changes 2023-10-13 16:04:20 +00:00

pat-s (Migrated from gitea.com) left a comment

Jep nice. Let's do the release WF in a separate PR.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#535

Fix helm dependency build once and for all #535

Description of the change

Applicable issues

Fix `helm dependency build` once and for all #535