Improve experience on writing unittests #570

2023-11-18T12:29:53Z

justusbunsi commented

2023-11-18 12:29:53 +00:00

(Migrated from gitea.com)

While working on #409, I noticed that some unittests contains either
invalid assertion methods (isNotEmpty) or invalid properties (any)
for a specific assertion method (notContains).

As our tests pass - and I have ensured that they can fail - this seems
related to the YAML schema validation in the IDE.

I've noticed that isNotEmpty was replaced by isNotNullOrEmpty¹
in version v0.3.2². At least from a schema validation point of view.
It is still working. Maybe deprecated? I don't know.

Regarding the any property, the documentation seems incorrect. I've
filed a PR for it³. As soon as that PR is merged and released, we
could probably validate the test YAML files in our PR workflow.

Last, since we renovate the used helm-unittest version, we should also
renovate the used YAML schema file.

While working on #409, I noticed that some unittests contains either invalid assertion methods (`isNotEmpty`) or invalid properties (`any`) for a specific assertion method (`notContains`). As our tests pass - and I have ensured that they can fail - this seems related to the YAML schema validation in the IDE. I've noticed that `isNotEmpty` was replaced by `isNotNullOrEmpty`[^1] in version v0.3.2[^2]. At least from a schema validation point of view. It is still working. Maybe deprecated? I don't know. Regarding the `any` property, the documentation seems incorrect. I've filed a PR for it[^3]. As soon as that PR is merged and released, we could probably validate the test YAML files in our PR workflow. Last, since we renovate the used helm-unittest version, we should also renovate the used YAML schema file. [^1]: https://github.com/helm-unittest/helm-unittest/pull/139 [^2]: https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.2 [^3]: https://github.com/helm-unittest/helm-unittest/pull/243

pat-s (Migrated from gitea.com) reviewed 2023-11-18 12:30:04 +00:00

pat-s (Migrated from gitea.com) approved these changes 2023-11-18 17:10:45 +00:00

pat-s (Migrated from gitea.com) left a comment

Nice find.

I guess renovate won't be able to fetch schema diffs in the changelog but anyhow - surely good to fix it!

Nice find. I guess renovate won't be able to fetch schema diffs in the changelog but anyhow - surely good to fix it!

justusbunsi commented

2023-11-18 17:20:37 +00:00

(Migrated from gitea.com)

Yep, Renovate most likely doesn't detect those changes. But we will receive one single dependency bump for all occurrences of the unittest plugin. And that should have the changelog from its GitHub release.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#570